From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: dired-warning Date: Fri, 12 Oct 2007 09:06:27 +0200 Message-ID: <470F1CF3.6050101@gmx.at> References: <200708271732.22306.zslevin@gmail.com> <46DD9F41.8090700@gmx.at> <46DE63EE.3070509@gmx.at> <46DE7DBA.90408@gmx.at> <46DEE8AB.9050203@gmx.at> <46DFBF17.4010702@gmx.at> <87ve9dut5o.fsf_-_@jurta.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1192176417 8455 80.91.229.12 (12 Oct 2007 08:06:57 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 12 Oct 2007 08:06:57 +0000 (UTC) Cc: emacs-devel@gnu.org To: Juri Linkov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 12 10:06:45 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IgFXI-00081z-IX for ged-emacs-devel@m.gmane.org; Fri, 12 Oct 2007 10:06:20 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IgFXC-0000Dq-F7 for ged-emacs-devel@m.gmane.org; Fri, 12 Oct 2007 04:06:14 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IgFX9-0000DS-6Y for emacs-devel@gnu.org; Fri, 12 Oct 2007 04:06:11 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IgFX7-0000D4-Pa for emacs-devel@gnu.org; Fri, 12 Oct 2007 04:06:10 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IgFX7-0000Cx-GJ for emacs-devel@gnu.org; Fri, 12 Oct 2007 04:06:09 -0400 Original-Received: from mail.gmx.net ([213.165.64.20]) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1IgFX6-000234-Kv for emacs-devel@gnu.org; Fri, 12 Oct 2007 04:06:09 -0400 Original-Received: (qmail invoked by alias); 12 Oct 2007 07:06:07 -0000 Original-Received: from N906P011.adsl.highway.telekom.at (EHLO [62.47.57.43]) [62.47.57.43] by mail.gmx.net (mp042) with SMTP; 12 Oct 2007 09:06:07 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/KLl57ilXKlhO0JGp7pXAAGe0bee8WuAdOezEr1h SmXsuUIlt9PUuw User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: de-DE, de, en-us, en In-Reply-To: <87ve9dut5o.fsf_-_@jurta.org> X-Y-GMX-Trusted: 0 X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:80698 Archived-At: > Since this change was synced to the trunk and I see it in action now, > I agree it was a bad idea. The problem provoking that change was that with eight colors `font-lock-comment-delimiter-face' usurpated `font-lock-comment-face' leaving the latter without foreground. > I propose to add a new face font-lock-error-face, to copy its definition > from font-lock-warning-face, and to copy the definition of compilation-warning > to font-lock-warning-face. So dired-warning inheriting now from > font-lock-warning-face will use the new definition. > > Making this distinction between two faces font-lock-error-face and > font-lock-warning-face will be useful for other packages where > error text should be displayed in the strong color, and warnings in > more subdued color. Would this fit into an eight colors scheme? > PS: This proposal is for the trunk. For Emacs-22 I think we should > restore the old color by copying definitions of font-lock-comment-face > and font-lock-comment-delimiter-face to dired-warning like: > > (defface dired-warning > '((((class color) (min-colors 88) (background light)) > (:foreground "Firebrick")) > (((class color) (min-colors 88) (background dark)) > (:foreground "chocolate1")) > (((class color) (min-colors 8) (background light)) > :foreground "red") > (((class color) (min-colors 8) (background dark)) > :foreground "red1")) > "Face used to highlight a part of a buffer that needs user attention." > :group 'dired-faces > :version "22.1") dired.el face specs are based on inheriting, hence this might break some people's customizations.