From: martin rudalics <rudalics@gmx.at>
To: "Jan Djärv" <jan.h.d@swipnet.se>
Cc: rms@gnu.org, emacs-devel@gnu.org
Subject: Re: [Fwd: Frame Height Different for Default Frame and Additional Frames]
Date: Wed, 10 Oct 2007 08:51:24 +0200 [thread overview]
Message-ID: <470C766C.1010503@gmx.at> (raw)
In-Reply-To: <470C695D.5010906@swipnet.se>
> It has not been fixed. Further more, different toolkits/ports needs
> different fixes, so the w32 port needs its own unique fix.
I see. But isn't this frame size increase hardcoded in the following
section of frame.c?
/* This used to be done _before_ calling x_figure_window_size, but
since the height is reset here, this was really a no-op. I
assume that moving it here does what Gerd intended (although he
no longer can remember what that was... ++KFS, 2003-03-25. */
/* Add the tool-bar height to the initial frame height so that the
user gets a text display area of the size he specified with -g or
via .Xdefaults. Later changes of the tool-bar height don't
change the frame size. This is done so that users can create
tall Emacs frames without having to guess how tall the tool-bar
will get. */
if (toolbar_p && FRAME_TOOL_BAR_LINES (f))
{
...
bar_height = DEFAULT_TOOL_BAR_IMAGE_HEIGHT + 2 * margin + 2 * relief;
FRAME_LINES (f) += (bar_height + FRAME_LINE_HEIGHT (f) - 1) / FRAME_LINE_HEIGHT (f);
}
If I understand this code correctly, it always adds some lines to the
default frame when a toolbar is present. Apparently it fails to do so
for the initial frame on w32. The first comment is not really an
enlightment in this regard.
Could you clarify two things: (1) How is this code related to initial
frames and default frames; does (should) it affect only the latter or
both ? (2) Doesn't the (toolbar_p && FRAME_TOOL_BAR_LINES (f))
condition hardcode a size increase whenever a toolbar is present ?
Also, the second comment seems to indicate that the frame size should
remain constant regardless of whether a toolbar is present or not. Is
this correct ?
next prev parent reply other threads:[~2007-10-10 6:51 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-01 16:56 Frame Height Different for Default Frame and Additional Frames Rocco Pigneri
2007-10-02 7:52 ` martin rudalics
[not found] ` <E1Iewxc-0004U8-CC@fencepost.gnu.org>
2007-10-08 21:12 ` [Fwd: Frame Height Different for Default Frame and Additional Frames] martin rudalics
2007-10-09 20:02 ` Richard Stallman
2007-10-09 21:25 ` martin rudalics
2007-10-10 5:55 ` Jan Djärv
2007-10-10 6:51 ` martin rudalics [this message]
2007-10-10 7:39 ` Jan Djärv
2007-10-10 7:50 ` Jason Rumney
2007-10-10 20:41 ` martin rudalics
2007-10-11 6:15 ` Jan Djärv
2007-10-11 8:52 ` martin rudalics
2007-10-11 14:01 ` Stefan Monnier
2007-10-14 16:29 ` Richard Stallman
2007-10-11 5:19 ` Richard Stallman
2007-10-11 8:52 ` martin rudalics
2007-10-11 18:03 ` Jan Djärv
2007-12-25 17:17 ` Richard Stallman
2007-12-27 19:10 ` martin rudalics
2007-12-28 13:56 ` Richard Stallman
2007-12-28 20:06 ` martin rudalics
2007-12-28 23:09 ` Robert J. Chassell
2007-12-28 23:51 ` martin rudalics
2008-01-05 11:22 ` Jan Djärv
2008-01-05 13:08 ` martin rudalics
2008-01-05 17:33 ` Jan Djärv
2008-01-05 18:08 ` Drew Adams
2008-01-05 22:42 ` Robert J. Chassell
2008-01-05 23:00 ` Jan Djärv
2008-01-06 8:08 ` Richard Stallman
2008-01-06 20:19 ` Stefan Monnier
2008-01-06 20:45 ` [Fwd: Frame Height Different for Default Frame and AdditionalFrames] Drew Adams
2007-10-10 21:03 ` [Fwd: Frame Height Different for Default Frame and Additional Frames] Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=470C766C.1010503@gmx.at \
--to=rudalics@gmx.at \
--cc=emacs-devel@gnu.org \
--cc=jan.h.d@swipnet.se \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.