From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.devel Subject: Re: 23.0.50 compile problem on Windows XP Date: Thu, 04 Oct 2007 23:11:56 +0100 Message-ID: <4705652C.5070803@gnu.org> References: <47035169.8070402@gnu.org> <4703869F.6070909@gnu.org> <47038922.10105@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1191535947 6453 80.91.229.12 (4 Oct 2007 22:12:27 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 4 Oct 2007 22:12:27 +0000 (UTC) Cc: emacs-devel@gnu.org To: Sridhar Boovaraghavan Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Oct 05 00:12:23 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IdYvR-0004cI-Ke for ged-emacs-devel@m.gmane.org; Fri, 05 Oct 2007 00:12:09 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IdYvN-0001WD-0J for ged-emacs-devel@m.gmane.org; Thu, 04 Oct 2007 18:12:05 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IdYvK-0001UC-26 for emacs-devel@gnu.org; Thu, 04 Oct 2007 18:12:02 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IdYvI-0001Qy-Af for emacs-devel@gnu.org; Thu, 04 Oct 2007 18:12:01 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IdYvI-0001Qr-7f for emacs-devel@gnu.org; Thu, 04 Oct 2007 18:12:00 -0400 Original-Received: from outmail1.freedom2surf.net ([194.106.33.237]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IdYvH-0000Rs-Vu for emacs-devel@gnu.org; Thu, 04 Oct 2007 18:12:00 -0400 Original-Received: from [127.0.0.1] (i-83-67-23-108.freedom2surf.net [83.67.23.108]) by outmail1.freedom2surf.net (Postfix) with ESMTP id 4248F50D24; Thu, 4 Oct 2007 23:11:59 +0100 (BST) User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) In-Reply-To: X-Detected-Kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:80254 Archived-At: Sridhar Boovaraghavan wrote: > Thank you for looking into and diagnosing the problem. I have moved > the inclusion of above "lisp.h" in the affected files and > here's a patch against HEAD that solves this issue. > There are several other files that include stdlib.h after lisp.h conditional on WINDOWSNT too. Does that not also cause the same problem? Also msdos.c includes lisp.h before stdlib.h, so there could be a problem there too. I think it is better to remove this definition from lisp.h and include stdlib.h in the files that need it. But perhaps there is a good reason not to do that in the first place, so I'll wait and let others comment on my mail from yesterday before making that change.