From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.devel Subject: Re: Please install and ack Date: Wed, 03 Oct 2007 14:35:52 +0100 Message-ID: <47039AB8.8060006@gnu.org> References: <20070912100811.GC12104@saeurebad.de> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1191418604 826 80.91.229.12 (3 Oct 2007 13:36:44 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 3 Oct 2007 13:36:44 +0000 (UTC) To: hannes@saeurebad.de, emacs-devel@gnu.org Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Oct 03 15:36:41 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Id4P0-0004F8-36 for ged-emacs-devel@m.gmane.org; Wed, 03 Oct 2007 15:36:38 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Id4Ov-00065W-RO for ged-emacs-devel@m.gmane.org; Wed, 03 Oct 2007 09:36:33 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Id4Os-00064z-KA for emacs-devel@gnu.org; Wed, 03 Oct 2007 09:36:30 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Id4Or-00064T-IB for emacs-devel@gnu.org; Wed, 03 Oct 2007 09:36:30 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Id4Or-00064K-Dv for emacs-devel@gnu.org; Wed, 03 Oct 2007 09:36:29 -0400 Original-Received: from outmail1.freedom2surf.net ([194.106.33.237]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Id4Or-00056o-1r for emacs-devel@gnu.org; Wed, 03 Oct 2007 09:36:29 -0400 Original-Received: from [192.168.249.28] (i-83-67-23-108.freedom2surf.net [83.67.23.108]) by outmail1.freedom2surf.net (Postfix) with ESMTP id 32CF252DDF; Wed, 3 Oct 2007 14:36:28 +0100 (BST) User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) In-Reply-To: <20070912100811.GC12104@saeurebad.de> X-Detected-Kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:80183 Archived-At: Johannes Weiner wrote: >> --- src/xterm.c.orig 2007-05-25 12:43:35.000000000 +0000 >> +++ src/xterm.c 2007-08-31 03:43:32.106444418 +0000 >> >> +#ifndef abs >> #define abs(x) ((x) < 0 ? -(x) : (x)) >> +#endif >> > Wouldn't it be better to centralize that macro? It's trivial, sure. But > repetition is not beautiful. Rather than centralising it, which has caused problems with at least one compiler due to the order of includes, and the fact that the system headers do not protect against redefinition with an #ifdef abs, wouldn't it be better to include in those files that require it?