From: Jason Rumney <jasonr@gnu.org>
To: hannes@saeurebad.de, emacs-devel@gnu.org
Subject: Re: Please install and ack
Date: Wed, 03 Oct 2007 14:35:52 +0100 [thread overview]
Message-ID: <47039AB8.8060006@gnu.org> (raw)
In-Reply-To: <20070912100811.GC12104@saeurebad.de>
Johannes Weiner wrote:
>> --- src/xterm.c.orig 2007-05-25 12:43:35.000000000 +0000
>> +++ src/xterm.c 2007-08-31 03:43:32.106444418 +0000
>>
>> +#ifndef abs
>> #define abs(x) ((x) < 0 ? -(x) : (x))
>> +#endif
>>
> Wouldn't it be better to centralize that macro? It's trivial, sure. But
> repetition is not beautiful.
Rather than centralising it, which has caused problems with at least one
compiler due to the order of includes, and the fact that the system
headers do not protect against redefinition with an #ifdef abs, wouldn't
it be better to include <stdlib.h> in those files that require it?
next prev parent reply other threads:[~2007-10-03 13:35 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-11 20:31 Please install and ack Richard Stallman
2007-09-12 10:08 ` Johannes Weiner
2007-09-12 14:05 ` Stefan Monnier
2007-09-12 20:02 ` Johannes Weiner
2007-09-12 20:08 ` Johannes Weiner
2007-09-12 18:52 ` Richard Stallman
2007-10-03 13:35 ` Jason Rumney [this message]
2007-09-16 8:56 ` Jan Djärv
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47039AB8.8060006@gnu.org \
--to=jasonr@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=hannes@saeurebad.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.