Gtk+ stock tool bar icons

Gtk+ stock tool bar icons

[Reiner Steib]

Hi,

Emacs trunk and EMACS_22_BASE (=> Emacs 22.2) now have:

,----[ NEWS ]
| * Changes in Emacs 22.2
| 
| ** The Gtk+ build now uses stock tool bar icons, so that a theme change
| is visible in Emacs tool bar.
`----

Up to now (AFAIK [1]), only the default Emacs tool bar has been
updated completely [2].  So for other modes, the user will get a
mixture of themed and un-themed icons (e.g. Info, Gnus, Message,
probably also MH-E).  Here are some screen shots from CVS trunk
(including my attempt to add mappings for Gnus icons to
`x-gtk-stock-map' [3]).

I'm not sure if its a good idea to enable the GTK stock mapping in
EMACS_22_BASE by default if we plan to release Emacs 22.2 soon.
What is better:

(a) A consistent icons style within Emacs (like in Emacs 22.1)

or

(b) Consistent icons between the (Gnome) desktop environment and parts
    of (GTK-) Emacs and inconsistent icons within several tool bars in
    Emacs.  See the screen shots on [4].

Some related questions:

- Is (setq x-gtk-stock-map nil) the recommended way to disable themed
  icons?  Shouldn't we provide this as a custom option (also in Emacs
  trunk) and mention it in NEWS?  (BTW, the custom version should read
  22.2 if we keep it in EMACS_22_BASE, shouldn't it?)

- Is my patch [3] correct?

- For Gnus, we have at least two icons where no corresponding
  Gnome/GTK icon was (is) available.  How can we should we deal with
  this?  (Probably the same is relevant for prev-node, next-node and
  up-node?)

  mail/preview.xpm (combining stock_mail and stock_zoom)
  mail/save.xpm    (combining stock_mail, stock_save and stock_convert)

- How is possible to try different icon styles for non-Gnome user?

Bye, Reiner.

[1] Maybe I missed some discussion on emacs-devel as I was on vacation.

[2] Info mode is only partially updated.  Previous, Next and Up node
    have un-themed icons.

[3]
--8<---------------cut here---------------start------------->8---
--- x-win.el	23 Sep 2007 18:33:46 +0200	1.210
+++ x-win.el	29 Sep 2007 15:18:32 +0200	
@@ -2587,7 +2587,43 @@
     ("etc/images/jump-to" . "gtk-jump-to")
     ("etc/images/index" . "gtk-index")
     ("etc/images/search" . "gtk-find")
-    ("etc/images/exit" . "gtk-quit"))
+    ("etc/images/exit" . "gtk-quit")
+    ;; Used in MH-E and/or Gnus:
+    ("etc/images/attach.xpm" . "gtk-attach")
+    ("etc/images/connect.xpm" . "gtk-connect")
+    ("etc/images/contact.xpm" . "gtk-contact")
+    ("etc/images/delete.xpm" . "gtk-delete")
+    ("etc/images/describe.xpm" . "gtk-properties")
+    ("etc/images/disconnect.xpm" . "gtk-disconnect")
+    ;; ("etc/images/exit.xpm" . "gtk-exit")
+    ("etc/images/lock-broken.xpm" . "gtk-lock_broken")
+    ("etc/images/lock-ok.xpm" . "gtk-lock_ok")
+    ("etc/images/lock.xpm" . "gtk-lock")
+    ("etc/images/next-page.xpm" . "gtk-next-page")
+    ("etc/images/refresh.xpm" . "gtk-refresh")
+    ("etc/images/sort-ascending.xpm" . "gtk-sort-ascending")
+    ("etc/images/sort-column-ascending.xpm" . "gtk-sort-column-ascending")
+    ("etc/images/sort-criteria.xpm" . "gtk-sort-criteria")
+    ("etc/images/sort-descending.xpm" . "gtk-sort-descending")
+    ("etc/images/sort-row-ascending.xpm" . "gtk-sort-row-ascending")
+    ("etc/images/gnus/toggle-subscription.xpm" . "gtk-task-recurring")
+    ("etc/images/mail/compose.xpm" . "gtk-mail-compose")
+    ("etc/images/mail/copy.xpm" . "gtk-mail-copy")
+    ("etc/images/mail/forward.xpm" . "gtk-mail-forward")
+    ("etc/images/mail/inbox.xpm" . "gtk-inbox")
+    ("etc/images/mail/move.xpm" . "gtk-mail-move")
+    ("etc/images/mail/not-spam.xpm" . "gtk-not-spam")
+    ("etc/images/mail/outbox.xpm" . "gtk-outbox")
+    ("etc/images/mail/reply-all.xpm" . "gtk-mail-reply-to-all")
+    ("etc/images/mail/reply.xpm" . "gtk-mail-reply")
+    ("etc/images/mail/save-draft.xpm" . "gtk-mail-handling")
+    ("etc/images/mail/send.xpm" . "gtk-mail-send")
+    ("etc/images/mail/spam.xpm" . "gtk-spam")
+    ;; No themed versions available:
+    ;; mail/preview.xpm (combining stock_mail and stock_zoom)
+    ;; mail/save.xpm    (combining stock_mail, stock_save and stock_convert)
+    ;;
+    )
   "How icons for tool bars are mapped to Gtk+ stock items.
 Emacs must be compiled with the Gtk+ toolkit for this to have any effect.
 A value that begins with n: denotes a named icon instead of a stock icon."
--8<---------------cut here---------------end--------------->8---

[4] Screen shots of Gnus on openSUSE 10.2 using fluxbox: 
<http://theotp1.physik.uni-ulm.de/~ste/comp/emacs/gnus/tool-bar/gtk-stock-map/>

$ rpm -qa|grep -Ee '-icon|-theme'|sort
gnome-icon-theme-2.16.0.1-12
gnome-themes-2.16.1.1-21
gtk2-themes-0.1-671
tango-icon-theme-0.7.2-36
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Gtk+ stock tool bar icons

[Jan Djärv]

Reiner Steib skrev:
> Hi,

Hi.

> What is better:
> 
> (a) A consistent icons style within Emacs (like in Emacs 22.1)
> 
> or
> 
> (b) Consistent icons between the (Gnome) desktop environment and parts
>     of (GTK-) Emacs and inconsistent icons within several tool bars in
>     Emacs.  See the screen shots on [4].
> 

I prefer (b), but then I am often a Gnome user.  An occational icon that isn't 
from the proper theme happens with other Gnome applications as well, depending 
on the theme used.

> Some related questions:
> 
> - Is (setq x-gtk-stock-map nil) the recommended way to disable themed
>   icons?  Shouldn't we provide this as a custom option (also in Emacs
>   trunk) and mention it in NEWS?  (BTW, the custom version should read
>   22.2 if we keep it in EMACS_22_BASE, shouldn't it?)

The custom version should indeed be 22.2, I've fixed that.  If you think we 
need another customize option to disable this, please feel free to add it.

> 
> - Is my patch [3] correct?

No, the files should be "images/mail/...".

> 
> - For Gnus, we have at least two icons where no corresponding
>   Gnome/GTK icon was (is) available.  How can we should we deal with
>   this?  (Probably the same is relevant for prev-node, next-node and
>   up-node?)
> 
>   mail/preview.xpm (combining stock_mail and stock_zoom)
>   mail/save.xpm    (combining stock_mail, stock_save and stock_convert)

There will always be icons that don't correspond to stock or theme icons. 
There are themes out there that don't have a complete set of icons for all 
purposes also.

> 
> - How is possible to try different icon styles for non-Gnome user?

AFAIK, it isn't.

	Jan D.

> 
> Bye, Reiner.
> 
> [1] Maybe I missed some discussion on emacs-devel as I was on vacation.
> 
> [2] Info mode is only partially updated.  Previous, Next and Up node
>     have un-themed icons.
> 
> [3]
> --8<---------------cut here---------------start------------->8---
> --- x-win.el	23 Sep 2007 18:33:46 +0200	1.210
> +++ x-win.el	29 Sep 2007 15:18:32 +0200	
> @@ -2587,7 +2587,43 @@
>      ("etc/images/jump-to" . "gtk-jump-to")
>      ("etc/images/index" . "gtk-index")
>      ("etc/images/search" . "gtk-find")
> -    ("etc/images/exit" . "gtk-quit"))
> +    ("etc/images/exit" . "gtk-quit")
> +    ;; Used in MH-E and/or Gnus:
> +    ("etc/images/attach.xpm" . "gtk-attach")
> +    ("etc/images/connect.xpm" . "gtk-connect")
> +    ("etc/images/contact.xpm" . "gtk-contact")
> +    ("etc/images/delete.xpm" . "gtk-delete")
> +    ("etc/images/describe.xpm" . "gtk-properties")
> +    ("etc/images/disconnect.xpm" . "gtk-disconnect")
> +    ;; ("etc/images/exit.xpm" . "gtk-exit")
> +    ("etc/images/lock-broken.xpm" . "gtk-lock_broken")
> +    ("etc/images/lock-ok.xpm" . "gtk-lock_ok")
> +    ("etc/images/lock.xpm" . "gtk-lock")
> +    ("etc/images/next-page.xpm" . "gtk-next-page")
> +    ("etc/images/refresh.xpm" . "gtk-refresh")
> +    ("etc/images/sort-ascending.xpm" . "gtk-sort-ascending")
> +    ("etc/images/sort-column-ascending.xpm" . "gtk-sort-column-ascending")
> +    ("etc/images/sort-criteria.xpm" . "gtk-sort-criteria")
> +    ("etc/images/sort-descending.xpm" . "gtk-sort-descending")
> +    ("etc/images/sort-row-ascending.xpm" . "gtk-sort-row-ascending")
> +    ("etc/images/gnus/toggle-subscription.xpm" . "gtk-task-recurring")
> +    ("etc/images/mail/compose.xpm" . "gtk-mail-compose")
> +    ("etc/images/mail/copy.xpm" . "gtk-mail-copy")
> +    ("etc/images/mail/forward.xpm" . "gtk-mail-forward")
> +    ("etc/images/mail/inbox.xpm" . "gtk-inbox")
> +    ("etc/images/mail/move.xpm" . "gtk-mail-move")
> +    ("etc/images/mail/not-spam.xpm" . "gtk-not-spam")
> +    ("etc/images/mail/outbox.xpm" . "gtk-outbox")
> +    ("etc/images/mail/reply-all.xpm" . "gtk-mail-reply-to-all")
> +    ("etc/images/mail/reply.xpm" . "gtk-mail-reply")
> +    ("etc/images/mail/save-draft.xpm" . "gtk-mail-handling")
> +    ("etc/images/mail/send.xpm" . "gtk-mail-send")
> +    ("etc/images/mail/spam.xpm" . "gtk-spam")
> +    ;; No themed versions available:
> +    ;; mail/preview.xpm (combining stock_mail and stock_zoom)
> +    ;; mail/save.xpm    (combining stock_mail, stock_save and stock_convert)
> +    ;;
> +    )
>    "How icons for tool bars are mapped to Gtk+ stock items.
>  Emacs must be compiled with the Gtk+ toolkit for this to have any effect.
>  A value that begins with n: denotes a named icon instead of a stock icon."
> --8<---------------cut here---------------end--------------->8---
> 
> [4] Screen shots of Gnus on openSUSE 10.2 using fluxbox: 
> <http://theotp1.physik.uni-ulm.de/~ste/comp/emacs/gnus/tool-bar/gtk-stock-map/>
> 
> $ rpm -qa|grep -Ee '-icon|-theme'|sort
> gnome-icon-theme-2.16.0.1-12
> gnome-themes-2.16.1.1-21
> gtk2-themes-0.1-671
> tango-icon-theme-0.7.2-36

Re: Gtk+ stock tool bar icons

[Reiner Steib]

On Sat, Sep 29 2007, Jan Djärv wrote:

> Reiner Steib skrev:
>> - Is (setq x-gtk-stock-map nil) the recommended way to disable themed
>>   icons?  Shouldn't we provide this as a custom option (also in Emacs
>>   trunk) and mention it in NEWS?  (BTW, the custom version should read
>>   22.2 if we keep it in EMACS_22_BASE, shouldn't it?)
>
> The custom version should indeed be 22.2, I've fixed that.  If you think we
> need another customize option to disable this, please feel free to add it.

On a second thought: Maybe `icon-map-list' seems more suitable to
disable it.  How about making it `icon-map-list' customizable and
improving the custom type of `x-gtk-stock-map' as follows?

--8<---------------cut here---------------start------------->8---
--- x-win.el	29 Sep 2007 16:23:59 -0000	1.211
+++ x-win.el	29 Sep 2007 19:48:04 -0000
@@ -2592,11 +2592,14 @@
 Emacs must be compiled with the Gtk+ toolkit for this to have any effect.
 A value that begins with n: denotes a named icon instead of a stock icon."
   :version "22.2"
-  :type 'alist
+  :type '(choice (repeat (choice symbol
+				 (cons (string :tag "Emacs icon")
+				       (regexp :tag "Stock/named")))))
+
   :group 'x)
 
-(defvar icon-map-list '(x-gtk-stock-map)
-  "*A list of alists that maps icon file names to stock/named icons.
+(defcustom icon-map-list '(x-gtk-stock-map)
+  "A list of alists that maps icon file names to stock/named icons.
 The alists are searched in the order they appear.  The first match is used.
 The keys in the alists are file names without extension and with two directory
 components.  For example, to map /usr/share/emacs/22.1.1/etc/images/open.xpm
@@ -2608,7 +2611,14 @@
 
   (\"etc/images/diropen\" . \"n:system-file-manager\")
 
-The list elements are either the symbol name for the alist or the alist itself.")
+The list elements are either the symbol name for the alist or the
+alist itself."
+  :version "22.2"
+  :type '(choice (const :tag "Don't use stock icons" nil)
+		 (repeat (choice symbol
+				 (cons (string :tag "Emacs icon")
+				       (regexp :tag "Stock/named")))))
+  :group 'x)
 
 (defun x-gtk-map-stock (file)
   "Map icon with file name FILE to a Gtk+ stock name, using `x-gtk-stock-map'."
--8<---------------cut here---------------end--------------->8---


>> - Is my patch [3] correct?
>
> No, the files should be "images/mail/...".

Are you saying without "etc/"?  I did it exactly like the present
elements:

     ("etc/images/search" . "gtk-find")
-    ("etc/images/exit" . "gtk-quit"))
+    ("etc/images/exit" . "gtk-quit")
+    ;; Used in MH-E and/or Gnus:
+    ("etc/images/attach.xpm" . "gtk-attach")
+    ("etc/images/connect.xpm" . "gtk-connect")

BTW, wouldn't it be better to strip "etc/images/" in the icon names
for consistency with the specification of the icons e.g. in
`tool-bar-add-item-from-menu' (cf. `image-load-path')?

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Gtk+ stock tool bar icons

[Richard Stallman]

    I'm not sure if its a good idea to enable the GTK stock mapping in
    EMACS_22_BASE by default if we plan to release Emacs 22.2 soon.
    What is better:

    (a) A consistent icons style within Emacs (like in Emacs 22.1)

For Emacs 22.2, let's not change this.

Re: Gtk+ stock tool bar icons

[Jan Djärv]

Reiner Steib skrev:
> On Sat, Sep 29 2007, Jan Djärv wrote:
> 
>> Reiner Steib skrev:
>>> - Is (setq x-gtk-stock-map nil) the recommended way to disable themed
>>>   icons?  Shouldn't we provide this as a custom option (also in Emacs
>>>   trunk) and mention it in NEWS?  (BTW, the custom version should read
>>>   22.2 if we keep it in EMACS_22_BASE, shouldn't it?)
>> The custom version should indeed be 22.2, I've fixed that.  If you think we
>> need another customize option to disable this, please feel free to add it.
> 
> On a second thought: Maybe `icon-map-list' seems more suitable to
> disable it.  How about making it `icon-map-list' customizable and
> improving the custom type of `x-gtk-stock-map' as follows?

Ok with me.



> 
>>> - Is my patch [3] correct?
>> No, the files should be "images/mail/...".
> 
> Are you saying without "etc/"?  I did it exactly like the present
> elements:

Yes I know.  But the document string says "file names without extension and 
with two directory components".  The reason for this is to avoid having to 
search the image path first and then do the translation.  Also, two is enough 
to distinguish the default setup.


> 
>      ("etc/images/search" . "gtk-find")
> -    ("etc/images/exit" . "gtk-quit"))
> +    ("etc/images/exit" . "gtk-quit")
> +    ;; Used in MH-E and/or Gnus:
> +    ("etc/images/attach.xpm" . "gtk-attach")
> +    ("etc/images/connect.xpm" . "gtk-connect")
> 
> BTW, wouldn't it be better to strip "etc/images/" in the icon names
> for consistency with the specification of the icons e.g. in
> `tool-bar-add-item-from-menu' (cf. `image-load-path')?
> 

I guess that would work also.  I'll fix that.

	Jan D.

Re: Gtk+ stock tool bar icons

[Jan Djärv]

Richard Stallman skrev:
>     I'm not sure if its a good idea to enable the GTK stock mapping in
>     EMACS_22_BASE by default if we plan to release Emacs 22.2 soon.
>     What is better:
> 
>     (a) A consistent icons style within Emacs (like in Emacs 22.1)
> 
> For Emacs 22.2, let's not change this.

Let's not change what?  Let's not change what is already checked in for 22.2 
or let's not change this so it differs from 22.1?

	Jan D.

Re: Gtk+ stock tool bar icons

[Reiner Steib]

On Sun, Sep 30 2007, Jan Djärv wrote:

> Richard Stallman skrev:
>>     I'm not sure if its a good idea to enable the GTK stock mapping in
>>     EMACS_22_BASE by default if we plan to release Emacs 22.2 soon.
>>     What is better:
>>
>>     (a) A consistent icons style within Emacs (like in Emacs 22.1)
>>
>> For Emacs 22.2, let's not change this.
>
> Let's not change what?  Let's not change what is already checked in for 22.2
> or let's not change this so it differs from 22.1?

I'd suggest to modify EMACS_22_BASE to achieve...
>>     (a) A consistent icons style within Emacs (like in Emacs 22.1)
... as follows:

Add/keep the relevant code as well (I assume these changes are safe
enough for Emacs 22.2), but change the default of `icon-map-list' to
nil.  Users who prefer...
>> (b) Consistent icons between the (Gnome) desktop environment and parts
>>     of (GTK-) Emacs [...]
... can customize it to include `x-gtk-stock-map'.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Gtk+ stock tool bar icons

[Reiner Steib]

On Sun, Sep 30 2007, Jan Djärv wrote:

> Reiner Steib skrev:
>> On a second thought: Maybe `icon-map-list' seems more suitable to
>> disable it.  How about making it `icon-map-list' customizable and
>> improving the custom type of `x-gtk-stock-map' as follows?
>
> Ok with me.

I have committed the following changes (only in the trunk yet):

	* term/x-win.el (x-gtk-stock-map): Add Gnus and MH-E icons.
	Improve custom type.
	(icon-map-list): Make it customizable.  Document how to disable
	stock icons.

Please take a look if and correct if necessary.  Thanks.

>>>> - Is my patch [3] correct?
>>> No, the files should be "images/mail/...".
>>
>> Are you saying without "etc/"?  I did it exactly like the present
>> elements:
>
> Yes I know.  But the document string says "file names without extension and
> with two directory components".  

Ah, it's only in the doc string of `icon-map-list' and not
`x-gtk-stock-map'.  To avoid duplication of the description, shouldn't
we describe the format in detail only in the doc string of
`icon-map-list' and refer to it in the doc string of
`x-gtk-stock-map'?

FWIW, removing "etc/" doesn't improve the Gnus tool bars for me.

> The reason for this is to avoid having to search the image path
> first and then do the translation.  Also, two is enough to
> distinguish the default setup.

So it's more or less an implementation detail?  For a user variable,
it would be nicer to make it consistent with
`tool-bar-add-item-from-menu' etc., I think.

>> BTW, wouldn't it be better to strip "etc/images/" in the icon names
>> for consistency with the specification of the icons e.g. in
>> `tool-bar-add-item-from-menu' (cf. `image-load-path')?
>
> I guess that would work also.  I'll fix that.

Thanks.

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Gtk+ stock tool bar icons

[Richard Stallman]

    >     (a) A consistent icons style within Emacs (like in Emacs 22.1)
    > 
    > For Emacs 22.2, let's not change this.

    Let's not change what?  Let's not change what is already checked in for 22.2 
    or let's not change this so it differs from 22.1?

Let's not change it from Emacs 22.1, at least not by default.

I would also prefer not to install the source changes for stock icons
into Emacs 22.2 unless they are very simple.
The goal for 22.2 is to fix the bugs and release it
soon.

Re: Gtk+ stock tool bar icons

[Yavor Doganov]

> ,----[ NEWS ]
> | * Changes in Emacs 22.2
> |
> | ** The Gtk+ build now uses stock tool bar icons, so that a theme 
> | change is visible in Emacs tool bar.
> `----

Unfortunately this change (great improvement, BTW!) causes some 
applications like Wanderlust not to display icons at all.  So it might be 
wiser to postpone this for 23 or at least 22.3 until their developers 
keep up.

Re: Gtk+ stock tool bar icons

[Jan Djärv]

Yavor Doganov skrev:
>> ,----[ NEWS ]
>> | * Changes in Emacs 22.2
>> |
>> | ** The Gtk+ build now uses stock tool bar icons, so that a theme 
>> | change is visible in Emacs tool bar.
>> `----
> 
> Unfortunately this change (great improvement, BTW!) causes some 
> applications like Wanderlust not to display icons at all.  So it might be 
> wiser to postpone this for 23 or at least 22.3 until their developers 
> keep up.
> 

That is strange.  I have disabled this in the 22 branch.

	Jan D.

Re: Gtk+ stock tool bar icons

[Masaru Nomiya]

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=ISO-2022-JP-2, Size: 1041 bytes --]

Hello,

In the Message; 

  Subject    : Re: Gtk+ stock tool bar icons
  Message-ID : <4700B856.90807@swipnet.se>
  Date & Time: Mon, 01 Oct 2007 11:05:26 +0200

[Jan] == Jan Dj^[.A^[Ndrv <jan.h.d@swipnet.se> has written:

>>> ,----[ NEWS ]
>>> | * Changes in Emacs 22.2
>>> |
>>> | ** The Gtk+ build now uses stock tool bar icons, so that a theme
>>> | change is visible in Emacs tool bar.
-

Yavor>> Unfortunately this change (great improvement, BTW!) causes some
Yavor>> applications like Wanderlust not to display icons at all.  So it
Yavor>> might be wiser to postpone this for 23 or at least 22.3 until their
Yvor>> developers keep up.

Jan> That is strange.  I have disabled this in the 22 branch.

No, Wanderlust could display icons on the tool-bar until 

    GNU Emacs 22.1.50.1 (x86_64-unknown-linux-gnu, X toolkit, Xaw3d scroll bars) of 2007-09-30 on linux

Regards,

---
  Masaru Nomiya       mail-to: nomiya @ galaxy.dti.ne.jp

          "Bill! You married with Computers.
           Not with Me!"
          "No..., with money."

Re: Gtk+ stock tool bar icons

[Yavor Doganov]

В Mon, 01 Oct 2007 20:23:26 +0900, Masaru Nomiya написа:

> No, Wanderlust could display icons on the tool-bar until

I was talking about the Wanderlust icons, namely

    (setq wl-icon-directory "/usr/share/pixmaps/wl/")

which most WL users have in their ~/.emacs or site startup file.  CVS 
trunk as of today (and in the past few weeks) shows an empty toolbar.

Re: Gtk+ stock tool bar icons

[Jan Djärv]

Yavor Doganov skrev:
> В Mon, 01 Oct 2007 20:23:26 +0900, Masaru Nomiya написа:
> 
>> No, Wanderlust could display icons on the tool-bar until
> 
> I was talking about the Wanderlust icons, namely
> 
>     (setq wl-icon-directory "/usr/share/pixmaps/wl/")
> 
> which most WL users have in their ~/.emacs or site startup file.  CVS 
> trunk as of today (and in the past few weeks) shows an empty toolbar.

Can you show an ls on that directory?

	Jan D.

Re: Gtk+ stock tool bar icons

[Yavor Doganov]

В Tue, 02 Oct 2007 17:56:27 +0200, Jan Djärv написа:
> Yavor Doganov skrev:
>> 
>>     (setq wl-icon-directory "/usr/share/pixmaps/wl/")
> 
> Can you show an ls on that directory?

Sure:

access.xpm
archive.xpm
closed.xpm
draft.xpm
elmo.xpm
file.xpm
filter.xpm
imap.xpm
internal.xpm
letter.xpm
localnews.xpm
local.xpm
maildir.xpm
multi.xpm
news.xpm
nmz.xpm
no-letter.xpm
opened.xpm
pipe.xpm
plugged.xpm
pop.xpm
queue.xpm
shimbun.xpm
trash-e.xpm
trash.xpm
unplugged.xpm
wl-alpha-logo.img
wl-alpha-logo.xbm
wl-alpha-logo.xpm
wl-alpha-xmas-logo.img
wl-alpha-xmas-logo.xbm
wl-alpha-xmas-logo.xpm
wl-beta-logo.img
wl-beta-logo.xbm
wl-beta-logo.xpm
wl-beta-xmas-logo.img
wl-beta-xmas-logo.xbm
wl-beta-xmas-logo.xpm
wl-draft-insert-signature-up.xpm
wl-draft-kill-up.xpm
wl-draft-save-and-exit-up.xpm
wl-draft-send-from-toolbar-down.xpm
wl-draft-send-from-toolbar-up.xpm
wl-draft-up.xpm
wl-draft-yank-original-up.xpm
wl-exit-up.xpm
wl-folder-check-current-entity-up.xpm
wl-folder-empty-trash-up.xpm
wl-folder-goto-draft-folder-up.xpm
wl-folder-jump-to-current-entity-no-sync-up.xpm
wl-folder-jump-to-current-entity-up.xpm
wl-folder-next-entity-up.xpm
wl-folder-prev-entity-up.xpm
wl-folder-read-up.xpm
wl-folder-select-entity-up.xpm
wl-folder-sync-current-entity-up.xpm
wl-folder-zoom-entity-up.xpm
wl-message-extract-content-up.xpm
wl-message-next-content-up.xpm
wl-message-play-content-up.xpm
wl-message-prev-content-up.xpm
wl-message-quit-up.xpm
wl-message-read-up.xpm
wl-stable-logo.img
wl-stable-logo.xbm
wl-stable-logo.xpm
wl-stable-xmas-logo.img
wl-stable-xmas-logo.xbm
wl-stable-xmas-logo.xpm
wl-summary-delete-up.xpm
wl-summary-dispose-up.xpm
wl-summary-exit-up.xpm
wl-summary-forward-up.xpm
wl-summary-jump-to-current-message-up.xpm
wl-summary-next-page-up.xpm
wl-summary-next-up.xpm
wl-summary-prev-page-up.xpm
wl-summary-prev-up.xpm
wl-summary-read-up.xpm
wl-summary-reply-up.xpm
wl-summary-reply-with-citation-up.xpm
wl-summary-set-flags-up.xpm
wl-summary-sync-force-update-up.xpm
wl-write-current-folder-up.xpm

Re: Gtk+ stock tool bar icons

[Jan Djärv]

Something is wrong in wl itself.  It probably uses an old mechanism for 
specifying images that is no longer valid.  I get a lot of byte compiler 
warnings about obsolete things being used when installing wl and the other 
things it depends on.  All image specifications from wl look like this:

(space :align-to 5)

and that is obviously not a valid image.

	Jan D.


Yavor Doganov skrev:
> В Tue, 02 Oct 2007 17:56:27 +0200, Jan Djärv написа:
>> Yavor Doganov skrev:
>>>     (setq wl-icon-directory "/usr/share/pixmaps/wl/")
>> Can you show an ls on that directory?
> 
> Sure:
> 
> access.xpm
> archive.xpm
> closed.xpm
> draft.xpm
> elmo.xpm
> file.xpm
> filter.xpm
> imap.xpm
> internal.xpm
> letter.xpm
> localnews.xpm
> local.xpm
> maildir.xpm
> multi.xpm
> news.xpm
> nmz.xpm
> no-letter.xpm
> opened.xpm
> pipe.xpm
> plugged.xpm
> pop.xpm
> queue.xpm
> shimbun.xpm
> trash-e.xpm
> trash.xpm
> unplugged.xpm
> wl-alpha-logo.img
> wl-alpha-logo.xbm
> wl-alpha-logo.xpm
> wl-alpha-xmas-logo.img
> wl-alpha-xmas-logo.xbm
> wl-alpha-xmas-logo.xpm
> wl-beta-logo.img
> wl-beta-logo.xbm
> wl-beta-logo.xpm
> wl-beta-xmas-logo.img
> wl-beta-xmas-logo.xbm
> wl-beta-xmas-logo.xpm
> wl-draft-insert-signature-up.xpm
> wl-draft-kill-up.xpm
> wl-draft-save-and-exit-up.xpm
> wl-draft-send-from-toolbar-down.xpm
> wl-draft-send-from-toolbar-up.xpm
> wl-draft-up.xpm
> wl-draft-yank-original-up.xpm
> wl-exit-up.xpm
> wl-folder-check-current-entity-up.xpm
> wl-folder-empty-trash-up.xpm
> wl-folder-goto-draft-folder-up.xpm
> wl-folder-jump-to-current-entity-no-sync-up.xpm
> wl-folder-jump-to-current-entity-up.xpm
> wl-folder-next-entity-up.xpm
> wl-folder-prev-entity-up.xpm
> wl-folder-read-up.xpm
> wl-folder-select-entity-up.xpm
> wl-folder-sync-current-entity-up.xpm
> wl-folder-zoom-entity-up.xpm
> wl-message-extract-content-up.xpm
> wl-message-next-content-up.xpm
> wl-message-play-content-up.xpm
> wl-message-prev-content-up.xpm
> wl-message-quit-up.xpm
> wl-message-read-up.xpm
> wl-stable-logo.img
> wl-stable-logo.xbm
> wl-stable-logo.xpm
> wl-stable-xmas-logo.img
> wl-stable-xmas-logo.xbm
> wl-stable-xmas-logo.xpm
> wl-summary-delete-up.xpm
> wl-summary-dispose-up.xpm
> wl-summary-exit-up.xpm
> wl-summary-forward-up.xpm
> wl-summary-jump-to-current-message-up.xpm
> wl-summary-next-page-up.xpm
> wl-summary-next-up.xpm
> wl-summary-prev-page-up.xpm
> wl-summary-prev-up.xpm
> wl-summary-read-up.xpm
> wl-summary-reply-up.xpm
> wl-summary-reply-with-citation-up.xpm
> wl-summary-set-flags-up.xpm
> wl-summary-sync-force-update-up.xpm
> wl-write-current-folder-up.xpm
> 
> 
> 
> _______________________________________________
> Emacs-devel mailing list
> Emacs-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: Gtk+ stock tool bar icons

[Yavor Doganov]

Jan Djärv wrote:
> 
> Something is wrong in wl itself.  It probably uses an old mechanism for 
> specifying images that is no longer valid. 

Certainly; I never meant that something in Emacs is wrong.  The idea
was to allow such packages to adapt their code as time goes by.  It
would be a bit surprising for users to have Emacs 22.1 working but
22.2 not.

Re: Gtk+ stock tool bar icons

[Jan Djärv]

Yavor Doganov skrev:
> Jan Djärv wrote:
>> Something is wrong in wl itself.  It probably uses an old mechanism for 
>> specifying images that is no longer valid. 
> 
> Certainly; I never meant that something in Emacs is wrong.  The idea
> was to allow such packages to adapt their code as time goes by.  It
> would be a bit surprising for users to have Emacs 22.1 working but
> 22.2 not.

The byte compiler gives warnigs like these (in apel):

filename.el:94:1:Warning: !! The file uses old-style backquotes !!
This functionality has been obsolete for more than 10 years already
and will be removed soon.  See (elisp)Backquote in the manual.

I guess something like this is the cause.

	Jan D.

Re: Gtk+ stock tool bar icons

[Reiner Steib]

On Wed, Oct 03 2007, Jan Djärv wrote:

> The byte compiler gives warnigs like these (in apel):
>
> filename.el:94:1:Warning: !! The file uses old-style backquotes !!
> This functionality has been obsolete for more than 10 years already
> and will be removed soon.  See (elisp)Backquote in the manual.
>
> I guess something like this is the cause.

I didn't follow the discussion about old-style backquotes closely, but
IIRC old-style backquotes should still work (it's a warning, not an
error).

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Gtk+ stock tool bar icons

[Yavor Doganov]

I guess we're miscommunicating; I'm neither arguing nor insisting
about anyting.

Jan Djärv wrote:
> The byte compiler gives warnigs like these (in apel):
> 
> filename.el:94:1:Warning: !! The file uses old-style backquotes !!
> This functionality has been obsolete for more than 10 years already
> and will be removed soon.  

Right.  If you feel that you should not cater for such packages,
please do.  It is not possible to follow every Emacs package and check
if cute changes (to Emacs CVS trunk) of the day break it -- it's just
too many of them.

I welcome this change, because it's good on all points.  As a WL user,
I don't care if the icons don't show as I don't use them anyway (but
the majority of users probably do).  I am not arguing that the new
behaviour is bad or radical -- I just warn you that it doesn't work in
all cases.

It's up to you to decide whether to push it at a point release.