From: Daniel Colascione <dancol@dancol.org>
To: Syohei YOSHIDA <syohex@gmail.com>, 24932@debbugs.gnu.org
Subject: bug#24932: [PATCH] Update module function signature
Date: Sun, 13 Nov 2016 13:05:49 -0800 [thread overview]
Message-ID: <46bc4be5-c355-f47f-cb22-445a91d0bfc5@dancol.org> (raw)
In-Reply-To: <83e6fbf4-13ba-edac-5a06-072643f5c0f7@dancol.org>
On 11/13/2016 01:02 PM, Daniel Colascione wrote:
> On 11/12/2016 06:06 PM, Syohei YOSHIDA wrote:
>> Second argument of module function is ptrdiff_t, not int.
>> This fixes a compile warning.
>
> That's an ABI break. We should find another way to fix the warning or
> add a new function.
Err, never mind. The patch is fine. I just read it too fast.
>
>> ---
>> modules/modhelp.py | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/modules/modhelp.py b/modules/modhelp.py
>> index 5d8f89b..445cb3b 100755
>> --- a/modules/modhelp.py
>> +++ b/modules/modhelp.py
>> @@ -154,7 +154,7 @@ def main():
>> int plugin_is_GPL_compatible;
>>
>> static emacs_value
>> -${c_func} (emacs_env *env, int nargs, emacs_value args[], void *data)
>> +${c_func} (emacs_env *env, ptrdiff_t nargs, emacs_value args[], void
>> *data)
>> {
>> return env->intern (env, "t");
>> }
>>
>
>
>
>
next prev parent reply other threads:[~2016-11-13 21:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-13 2:06 bug#24932: [PATCH] Update module function signature Syohei YOSHIDA
2016-11-13 21:02 ` Daniel Colascione
2016-11-13 21:05 ` Daniel Colascione [this message]
2016-11-28 15:51 ` Paul Eggert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46bc4be5-c355-f47f-cb22-445a91d0bfc5@dancol.org \
--to=dancol@dancol.org \
--cc=24932@debbugs.gnu.org \
--cc=syohex@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.