From: Dmitry Gutov <dgutov@yandex.ru>
To: Robert Pluim <rpluim@gmail.com>
Cc: "36644@debbugs.gnu.org" <36644@debbugs.gnu.org>,
Juri Linkov <juri@linkov.net>
Subject: bug#36644: Git log search
Date: Wed, 24 Jul 2019 18:53:01 +0300 [thread overview]
Message-ID: <46b910fb-25f0-1b6e-df9b-fda1383cb1c9@yandex.ru> (raw)
In-Reply-To: <m2imrrmo49.fsf@gmail.com>
On 24.07.2019 18:46, Robert Pluim wrote:
>>>>>> On Wed, 24 Jul 2019 18:10:35 +0300, Dmitry Gutov <dgutov@yandex.ru> said:
>
> Dmitry> On 19.07.2019 1:32, Juri Linkov wrote:
> >>> We can't really use this approach. VC is a high level abstraction,
> >>> so we try to define the semantics well.
> >>
> >> I tend to agree with Robert. A string have to be passed to the backend as is.
> >> It seems such situations when these strings should be compatible between
> >> different backends (such as running the same command on one backend,
> >> and then repeating the same search on another backend by retrieving
> >> a previous argument from the history via M-p) are very rare.
>
> Dmitry> I might agree with you from the practical standpoint, but
> Dmitry> vc-log-search needs a docstring that actually describes what the
> Dmitry> function is going to do. Including info on how PATTERN is going to be
> Dmitry> interpreted.
>
> If it were implemented as 'backend show me all the logs and then emacs
> will search through them' then that would be required, but itʼs not,
> itʼs implemented as 'backend show me the logs which match STRING'
Again, it's about documentation and about commands doing things in a way
that the user can anticipate.
> Dmitry> E.g. whether "foo.txt" will only match literally, or whether "." can
> Dmitry> be substituted by any character.
>
> That will depend on the backend
>
> Dmitry> And if PATTERN is a regexp, what kind of regexp it's going to be
> Dmitry> interepreted as: basic RE, extended RE, Emacs RE, or Perl RE (probably
> Dmitry> not the last one anyway).
>
> As will this
>
> Dmitry> I suppose we can choose one of these and say e.g. that pattern is
> Dmitry> interpreted as an extended regular expression, except for some
> Dmitry> backends that don't support that. I wonder how we're going to convey
> Dmitry> the latter to the user.
>
> Itʼs not a pattern. Itʼs a string that is passed as-is to the backend,
> which is free to interpret it as it wishes. From my viewpoint, we can
> just say
>
> "Search for STRING, which is passed unsullied to the backend's log
> search command. Consult the documentation for your backend to
> understand the matching method it uses to search for STRING."
IME this doesn't match the way we try to document commands in Emacs, but
I wouldn't want to spend much time arguing about this.
Eli, could you weigh in in this discussion? Would you say Robert's
proposal is acceptable?
next prev parent reply other threads:[~2019-07-24 15:53 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-13 22:27 bug#36644: Git log search Juri Linkov
2019-07-15 15:05 ` Dmitry Gutov
2019-07-15 22:27 ` Juri Linkov
2019-07-16 14:25 ` Dmitry Gutov
2019-07-16 14:44 ` Andreas Schwab
2019-07-16 15:08 ` Robert Pluim
2019-07-16 20:20 ` Juri Linkov
2019-07-16 22:31 ` Noam Postavsky
2019-07-18 22:35 ` Juri Linkov
2019-07-24 14:57 ` Dmitry Gutov
2019-07-16 20:15 ` Juri Linkov
2019-07-18 15:01 ` Dmitry Gutov
2019-07-18 15:12 ` Robert Pluim
2019-07-18 18:02 ` Dmitry Gutov
2019-07-18 18:11 ` Robert Pluim
2019-07-18 22:32 ` Juri Linkov
2019-07-24 15:10 ` Dmitry Gutov
2019-07-24 15:46 ` Robert Pluim
2019-07-24 15:53 ` Dmitry Gutov [this message]
2019-07-24 16:13 ` Eli Zaretskii
2019-07-25 12:36 ` Dmitry Gutov
2019-07-25 13:08 ` Eli Zaretskii
2019-07-25 13:20 ` Dmitry Gutov
2019-07-25 13:37 ` Robert Pluim
2019-07-25 19:00 ` Juri Linkov
2019-07-25 18:55 ` Juri Linkov
2019-07-25 21:26 ` Dmitry Gutov
2019-07-25 21:38 ` Juri Linkov
2019-07-24 16:13 ` Robert Pluim
2019-07-24 17:04 ` Eli Zaretskii
2019-07-24 23:22 ` Juri Linkov
2019-07-25 12:44 ` Dmitry Gutov
2019-07-25 18:50 ` Juri Linkov
2019-07-25 19:19 ` Dmitry Gutov
2019-07-29 22:38 ` Juri Linkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46b910fb-25f0-1b6e-df9b-fda1383cb1c9@yandex.ru \
--to=dgutov@yandex.ru \
--cc=36644@debbugs.gnu.org \
--cc=juri@linkov.net \
--cc=rpluim@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.