From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: 22.1.1; Frame title no more updated after calling `set-frame-configuration' Date: Sat, 08 Sep 2007 10:45:02 +0200 Message-ID: <46E2610E.6040301@gmx.at> References: <46D7FD30.8020205@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1189243838 19473 80.91.229.12 (8 Sep 2007 09:30:38 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 8 Sep 2007 09:30:38 +0000 (UTC) Cc: emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Sep 08 11:30:38 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1ITweC-00035j-Cj for ged-emacs-devel@m.gmane.org; Sat, 08 Sep 2007 11:30:36 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ITwe9-0008IH-Q0 for ged-emacs-devel@m.gmane.org; Sat, 08 Sep 2007 05:30:33 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ITwe2-0008FC-HX for emacs-devel@gnu.org; Sat, 08 Sep 2007 05:30:26 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ITwe1-0008De-5P for emacs-devel@gnu.org; Sat, 08 Sep 2007 05:30:25 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ITwe0-0008DN-Rw for emacs-devel@gnu.org; Sat, 08 Sep 2007 05:30:24 -0400 Original-Received: from mail.gmx.net ([213.165.64.20]) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1ITwe0-0002fm-90 for emacs-devel@gnu.org; Sat, 08 Sep 2007 05:30:24 -0400 Original-Received: (qmail invoked by alias); 08 Sep 2007 09:30:22 -0000 Original-Received: from N842P001.adsl.highway.telekom.at (EHLO [62.47.49.33]) [62.47.49.33] by mail.gmx.net (mp037) with SMTP; 08 Sep 2007 11:30:22 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18kcL4c5REkoM3HM5kjRVot4lF0bp726Lmqb5dLBr 7tIFWTBZ+OMZWK User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: de-DE, de, en-us, en In-Reply-To: X-Y-GMX-Trusted: 0 X-Detected-Kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:78248 Archived-At: >>emacs -Q --eval '(set-frame-configuration (current-frame-configuration))' >> >>segfaults in x_set_frame_parameters. > > > > Seems (?) to work ok with the following extra change: > > > *** frame.c 25 Jul 2007 05:15:52 -0000 1.340.2.1 > --- frame.c 7 Sep 2007 22:51:56 -0000 > *** 2768,2773 **** > --- 2770,2778 ---- > icon_top = val; > else if (EQ (prop, Qicon_left)) > icon_left = val; > + else if (EQ (prop, Qexplicit_name)) > + /* Handled elsewhere. */ > + continue; > else if (EQ (prop, Qforeground_color) > || EQ (prop, Qbackground_color) > || EQ (prop, Qfont) > This would be needed in any case because "explicit-name" should never get assigned to by `modify-frame-parameters'. I'm not entirely sure though whether every possible setting of "name" gets correctly reflected in "explicit-name", but such a bug would have existed before. At least I'm tempted to move the f->explicit_name = ! NILP (name); in set_term_frame_name as f->explicit_name = Qt; to the end of the else branch below to catch the cases where there's no change either because the strings are equal or there's a name clash, but that's probably only a minor issue. I wouldn't care if anyone came up with a completely different solution ;-)