From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: bug of display-table & make-glyph-code Date: Thu, 06 Sep 2007 10:49:27 +0200 Message-ID: <46DFBF17.4010702@gmx.at> References: <200708271732.22306.zslevin@gmail.com> <46DD9F41.8090700@gmx.at> <46DE63EE.3070509@gmx.at> <46DE7DBA.90408@gmx.at> <46DEE8AB.9050203@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1189071257 6494 80.91.229.12 (6 Sep 2007 09:34:17 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 6 Sep 2007 09:34:17 +0000 (UTC) Cc: rms@gnu.org, emacs-devel@gnu.org To: Glenn Morris Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Sep 06 11:34:17 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1ITDkX-0005SO-BF for ged-emacs-devel@m.gmane.org; Thu, 06 Sep 2007 11:34:09 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ITDkV-0002yU-8m for ged-emacs-devel@m.gmane.org; Thu, 06 Sep 2007 05:34:07 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ITDkP-0002uk-JM for emacs-devel@gnu.org; Thu, 06 Sep 2007 05:34:01 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ITDkO-0002t5-Bw for emacs-devel@gnu.org; Thu, 06 Sep 2007 05:34:00 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ITDkO-0002sU-39 for emacs-devel@gnu.org; Thu, 06 Sep 2007 05:34:00 -0400 Original-Received: from mail.gmx.net ([213.165.64.20]) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1ITDkN-0006NH-Ez for emacs-devel@gnu.org; Thu, 06 Sep 2007 05:33:59 -0400 Original-Received: (qmail invoked by alias); 06 Sep 2007 09:33:57 -0000 Original-Received: from N761P020.adsl.highway.telekom.at (EHLO [62.47.39.20]) [62.47.39.20] by mail.gmx.net (mp030) with SMTP; 06 Sep 2007 11:33:57 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX18sJdRo6E4sAYK9FXzgOZPrxldgksniYuk1pKSNZ9 zUR4095qKIDs1Y User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: de-DE, de, en-us, en In-Reply-To: X-Y-GMX-Trusted: 0 X-Detected-Kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:77960 Archived-At: > Well, that's easy. :) I say; install your dired-warning fix, and cross > this off the list. Mapping dired-warning to font-lock-warning-face was a bad idea: The latter is already used for marking and flagging. It seems better to use `font-lock-comment-delimiter-face' just for the min-colors 8 case as in the patch below. *** dired.el.~1.359.2.6.~ Tue Aug 7 16:01:52 2007 --- dired.el Thu Sep 6 10:34:06 2007 *************** *** 335,341 **** "Face name used for flagged files.") (defface dired-warning ! '((t (:inherit font-lock-comment-face))) "Face used to highlight a part of a buffer that needs user attention." :group 'dired-faces :version "22.1") --- 335,343 ---- "Face name used for flagged files.") (defface dired-warning ! '((((class color) (min-colors 16)) (:inherit font-lock-comment-face)) ! (((class color) (min-colors 8)) (:inherit font-lock-comment-delimiter-face)) ! (t (:inherit font-lock-comment-face))) "Face used to highlight a part of a buffer that needs user attention." :group 'dired-faces :version "22.1")