From: Carsten Dominik <carsten.dominik@gmail.com>
To: Stephen Peters <portnoy@portnoy.org>
Cc: emacs-orgmode@gnu.org
Subject: Re: [PATCH] Alignment problem with org-format-org-table-html
Date: Thu, 29 Apr 2010 15:01:36 +0200 [thread overview]
Message-ID: <46DF2383-867C-4D8A-8A3A-265E39CAB70D@gmail.com> (raw)
In-Reply-To: <4BD72F7F.70607@portnoy.org>
Hi Stephen, nice catch, thank you very much!
I have applied the patch.
- Carsten
On Apr 27, 2010, at 8:39 PM, Stephen Peters wrote:
> When creating a table, I was noticing that the
> <colgroup><col>... provides useful alignment information based on
> whether or not the column has numbers in it. I think, however, that
> there is a mistake in this routine. Take, for example, the following
> table:
>
> | Id | Task | Developer | Estimate | Spent | Remaining |
> Comp.% | Updated |
> |-----+--------------+-----------+----------+-------+-----------
> +--------+-----------------|
> | 1 | Task One | SLP | 1 | 0 | 1
> | 0 | SLP, 2010-04-27 |
> | 2 | Task Two | SLP | 1 | 0 | 1
> | 0 | SLP, 2010-04-27 |
> | 3 | Task Three | SLP | 2 | 0 | 2
> | 0 | SLP, 2010-04-27 |
> | 4 | Task Four | SLP | 2 | 0 | 2
> | 0 | SLP, 2010-04-27 |
> | 5 | Task Five | SLP | .25 | 0 | 0.25
> | 0 | SLP, 2010-04-27 |
> | 5.1 | Another Task | XML team | 0 | 1 | 0
> | 0 | SLP, 2010-04-27 |
> | 6 | Task Six | SLP | .25 | 0 | 0.25
> | 0 | SLP, 2010-04-27 |
> | 6.1 | More Tasks | DB team | 3 | 0 | 3
> | 0 | SLP, 2010-04-27 |
> | 7 | Task Seven | SLP | 3 | 0 | 3
> | 0 | SLP, 2010-04-27 |
>
> When the colgroup list is created for this table, it reads:
>
> <colgroup><col align="right" /><col align="left" /><col
> align="left" /><col align="right" /><col align="right" /><col
> align="left" /><col align="left" /><col align="left" />
> </colgroup>
>
> Note that the first columns are correct, but the last few are not.
> It should read right, left, left, right, right, right, right, left.
>
> I believe that this is due to the (< i nline) comparison within org-
> format-org-table-html, which is nonsensical because it's trying to
> compare a column number with a number of rows. I've attached a
> patch for the problem.
>
>
>
> diff --git a/lisp/org-html.el b/lisp/org-html.el
> index 3ac2b18..0ffde15 100644
> --- a/lisp/org-html.el
> +++ b/lisp/org-html.el
> @@ -1659,8 +1659,7 @@ lang=\"%s\" xml:lang=\"%s\">
> (mapconcat
> (lambda (x)
> (setq i (1+ i))
> - (if (and (< i nline)
> - (string-match org-table-number-regexp x))
> + (if (string-match org-table-number-regexp x)
> (incf (aref fnum i)))
> (cond
> (head
> _______________________________________________
> Emacs-orgmode mailing list
> Please use `Reply All' to send replies to the list.
> Emacs-orgmode@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-orgmode
- Carsten
prev parent reply other threads:[~2010-04-29 13:02 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 18:39 [PATCH] Alignment problem with org-format-org-table-html Stephen Peters
2010-04-29 13:01 ` Carsten Dominik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46DF2383-867C-4D8A-8A3A-265E39CAB70D@gmail.com \
--to=carsten.dominik@gmail.com \
--cc=emacs-orgmode@gnu.org \
--cc=portnoy@portnoy.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.