From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Adrian Robert Newsgroups: gmane.emacs.bugs Subject: bug#5811: 23.1.94; Emacs Nextstep port crashes after graphical yes-or-no-p Date: Sat, 10 Apr 2010 09:11:43 +0300 Message-ID: <46DD2CEE-3447-4798-979F-30996C4F0776@gmail.com> References: <87ljd7b34s.fsf@stupidchicken.com> <877hoqlxtr.fsf@engster.org> <061906EB-995E-4697-BCCD-993141A6047F@gmail.com> <5A569396-58DA-4C91-A081-1D1866018E8A@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v1077) Content-Type: multipart/mixed; boundary=Apple-Mail-10-514927277 X-Trace: dough.gmane.org 1270880938 30446 80.91.229.12 (10 Apr 2010 06:28:58 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sat, 10 Apr 2010 06:28:58 +0000 (UTC) To: David Engster , Chong Yidong , 5811@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sat Apr 10 08:28:57 2010 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1O0UBZ-0006Y1-Hi for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Apr 2010 08:28:53 +0200 Original-Received: from localhost ([127.0.0.1]:36154 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O0UBY-0007C8-MC for geb-bug-gnu-emacs@m.gmane.org; Sat, 10 Apr 2010 02:28:52 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1O0UBR-0007Bw-Qg for bug-gnu-emacs@gnu.org; Sat, 10 Apr 2010 02:28:45 -0400 Original-Received: from [140.186.70.92] (port=40478 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1O0UBP-0007Bn-Sy for bug-gnu-emacs@gnu.org; Sat, 10 Apr 2010 02:28:45 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1O0UBO-0001vj-2L for bug-gnu-emacs@gnu.org; Sat, 10 Apr 2010 02:28:43 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:37018) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O0UBN-0001vf-Ua for bug-gnu-emacs@gnu.org; Sat, 10 Apr 2010 02:28:42 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1O0TvG-0005fp-3l; Sat, 10 Apr 2010 02:12:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Adrian Robert Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 10 Apr 2010 06:12:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 5811 X-GNU-PR-Package: emacs,ns X-GNU-PR-Keywords: Original-Received: via spool by 5811-submit@debbugs.gnu.org id=B5811.127087991421803 (code B ref 5811); Sat, 10 Apr 2010 06:12:02 +0000 Original-Received: (at 5811) by debbugs.gnu.org; 10 Apr 2010 06:11:54 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O0Tv8-0005fc-3w for submit@debbugs.gnu.org; Sat, 10 Apr 2010 02:11:54 -0400 Original-Received: from mail-ew0-f209.google.com ([209.85.219.209]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1O0Tv5-0005fX-Os for 5811@debbugs.gnu.org; Sat, 10 Apr 2010 02:11:52 -0400 Original-Received: by ewy1 with SMTP id 1so1532502ewy.15 for <5811@debbugs.gnu.org>; Fri, 09 Apr 2010 23:11:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:mime-version :content-type:subject:date:in-reply-to:to:references:message-id :x-mailer; bh=PGrYOGYvpVym6KB482j/vvU2ZhQW25J70QR17G3YS3Q=; b=nLObWlNYWmZF+IyBiUSt8gwrOEh178OrbJD4BYo5vk3Zmz2NMe65C+IM1Xc5C8Fv9q nl8F03lrQcZNOdy01hlp4HH19ZDRx5CLit3JBQc0ijn8CqVTRLofn9EXZel234q97X5c EPSYiUbO3yUe+Ox920ezqFyvyB9pPW8eaUrXI= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:mime-version:content-type:subject:date:in-reply-to:to :references:message-id:x-mailer; b=WKsy6VsIW+bYV8rYZQeNJgI+/q+EUA2TE19GAKZqMHh5YP1VH1zHZ40eD33lXtF4Ts BHlwEaQLfZIXDmWnlyTkjkPRfoojMkkFBHPv9x7D1TM6TA9nFr2wgPRRwsbXhcxScgOv 5+HA3GzruO7hm79FgyLsNrptZRh65oLvINrvc= Original-Received: by 10.213.37.11 with SMTP id v11mr545336ebd.60.1270879907766; Fri, 09 Apr 2010 23:11:47 -0700 (PDT) Original-Received: from [10.0.1.2] (dsl-hkibrasgw2-ff6ec300-110.dhcp.inet.fi [88.195.110.110]) by mx.google.com with ESMTPS id 15sm1217769ewy.4.2010.04.09.23.11.44 (version=TLSv1/SSLv3 cipher=RC4-MD5); Fri, 09 Apr 2010 23:11:45 -0700 (PDT) In-Reply-To: X-Mailer: Apple Mail (2.1077) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Sat, 10 Apr 2010 02:12:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:36140 Archived-At: --Apple-Mail-10-514927277 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii On Apr 6, 2010, at 4:17 PM, Adrian Robert wrote: >> Maybe you made a 32bit binary? >>=20 >> When I compile with >>=20 >> CC=3D"gcc -arch i386" ./configure --with-ns >>=20 >> the resulting binary does not crash on the test case. So it appears = to >> be a problem with 64bit only. >=20 > Hmm, possibly. Anyway this suggests maybe it is also some sort of = signature and/or argument-passing issue. The previous fix just = corrected some kind misalignment problem due to the wrong size for the = return type being allocated on the stack. This is roughly what it seemed to be. Here is a patch that fixes this = issue for me running 10.6.2 64-bit. (I tried to look for other problems = of this sort in the source but did not find any -- though that doesn't = mean they don't exist!) -Adrian Index: nsmenu.m =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D RCS file: /sources/emacs/emacs/src/nsmenu.m,v retrieving revision 1.31 diff -u -p -r1.31 nsmenu.m --- nsmenu.m 9 Nov 2009 06:21:03 -0000 1.31 +++ nsmenu.m 10 Apr 2010 06:09:44 -0000 @@ -1709,7 +1709,7 @@ void process_dialog (id window, Lisp_Obj =20 - (Lisp_Object)runDialogAt: (NSPoint)p { - int ret; + NSInteger ret; extern EMACS_TIME timer_check (int do_it_now); /* TODO: add to a = header */ =20 /* initiate a session that will be ended by pop_down_menu */ --Apple-Mail-10-514927277 Content-Disposition: attachment; filename=snowLeopard_dialog.patch Content-Type: application/octet-stream; name="snowLeopard_dialog.patch" Content-Transfer-Encoding: 7bit Index: nsmenu.m =================================================================== RCS file: /sources/emacs/emacs/src/nsmenu.m,v retrieving revision 1.31 diff -u -p -r1.31 nsmenu.m --- nsmenu.m 9 Nov 2009 06:21:03 -0000 1.31 +++ nsmenu.m 10 Apr 2010 06:09:44 -0000 @@ -1709,7 +1709,7 @@ void process_dialog (id window, Lisp_Obj - (Lisp_Object)runDialogAt: (NSPoint)p { - int ret; + NSInteger ret; extern EMACS_TIME timer_check (int do_it_now); /* TODO: add to a header */ /* initiate a session that will be ended by pop_down_menu */ --Apple-Mail-10-514927277 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii --Apple-Mail-10-514927277--