From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?ISO-8859-1?Q?Jan_Dj=E4rv?= Newsgroups: gmane.emacs.devel Subject: Re: [Itai Seggev] Bug#439559: emacs22-gtk: forward/back buttons backwards when GTK is set to RTL language Date: Mon, 03 Sep 2007 08:21:53 +0200 Message-ID: <46DBA801.7050404@swipnet.se> References: <87d4xad4f9.fsf@gmx.de> <46D3F6BF.9050605@swipnet.se> <20070828183637.GA809@knuth.cs.hmc.edu> <46D65F52.7050809@swipnet.se> <20070902234808.GA1718@knuth.cs.hmc.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1188800558 17115 80.91.229.12 (3 Sep 2007 06:22:38 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 3 Sep 2007 06:22:38 +0000 (UTC) Cc: Sven Joachim , 439559-forwarded@bugs.debian.org, emacs-devel@gnu.org To: Itai Seggev Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Sep 03 08:22:37 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IS5KW-0004oc-3k for ged-emacs-devel@m.gmane.org; Mon, 03 Sep 2007 08:22:36 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IS5KU-0003oC-TO for ged-emacs-devel@m.gmane.org; Mon, 03 Sep 2007 02:22:34 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IS5KR-0003nA-K3 for emacs-devel@gnu.org; Mon, 03 Sep 2007 02:22:31 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IS5KR-0003mo-1M for emacs-devel@gnu.org; Mon, 03 Sep 2007 02:22:31 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IS5KQ-0003mj-Mp for emacs-devel@gnu.org; Mon, 03 Sep 2007 02:22:30 -0400 Original-Received: from av8-1-sn3.vrr.skanova.net ([81.228.9.183]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IS5KQ-0006UF-1o for emacs-devel@gnu.org; Mon, 03 Sep 2007 02:22:30 -0400 Original-Received: by av8-1-sn3.vrr.skanova.net (Postfix, from userid 502) id E952C38139; Mon, 3 Sep 2007 08:22:28 +0200 (CEST) Original-Received: from smtp3-1-sn3.vrr.skanova.net (smtp3-1-sn3.vrr.skanova.net [81.228.9.101]) by av8-1-sn3.vrr.skanova.net (Postfix) with ESMTP id 9D97138114; Mon, 3 Sep 2007 08:22:28 +0200 (CEST) Original-Received: from husetbladh.homeip.net (81-235-205-78-no59.tbcn.telia.com [81.235.205.78]) by smtp3-1-sn3.vrr.skanova.net (Postfix) with ESMTP id EB76C37E47; Mon, 3 Sep 2007 08:22:27 +0200 (CEST) User-Agent: Thunderbird 2.0.0.6 (X11/20070728) In-Reply-To: <20070902234808.GA1718@knuth.cs.hmc.edu> X-Detected-Kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:77643 Archived-At: Itai Seggev skrev: > On Thu, Aug 30, 2007 at 08:10:26AM +0200, Jan Dj=E4rv wrote: >> >> Itai Seggev skrev: >>> On Tue, Aug 28, 2007 at 12:19:43PM +0200, Jan Dj=E4rv wrote: >>>> I've made a fix in CVS HEAD, can you try that? >>> OK, I've downloaded and compiled CVS HEAD. After about 2 minutes of >>> testing, it seems that the next-node/previous-node buttons are >>> correctly ordered for a RTL language, but that >>> forward-history/back-history are still in the LTR orientation. I'll >>> play some more with it after work and see if there are any additional= =20 >>> issues. >> It seems that some themes don't supply RTL information. Can you try s= ome=20 >> other themes and see if the forward-history/back-history are correct f= or=20 >> any of them? Crux, Bluecurve or Clearlooks works for me. >=20 > OK, so it is a problem with some themes and not others. In particular w= ith > gtk-qt. However, if the problem really is with the theme, why is it > that the next/previous buttons are OK, and only the back/forward > buttons don't look right. Perhaps whatever changes to next/previous > could also be applied to forward/back so that they also look OK in all > themes.=20 The difference is that next/previous are not Gtk+ stock icons (i.e. defin= ed by=20 the theme), but forward/back are. Gtk+ handles RTL/LTR by itself when st= ock=20 icons are used, but only if the theme supplies that information. So in theory we should ask Gtk+ if RTL is used, and if so, does the stock= =20 icons have any RTL information? Unfortunately, the Gtk+ API does not giv= e us=20 access to RTL information for individual themed icons. So sometimes Gtk+= does=20 the right thing, sometimes it does not, depending on the theme used. We could "untheme" forward/back, but that would be too drastic. The best= I=20 can think of for your situation is to a) file a bug report on the theme you are using. The root cuase is there= . b) As a workaround, you can "untheme" forward/back by customizing=20 x-gtk-stock-map (M-x customize-variablex-gtk-stock-map). Delete the rows for etc/images/left-arrow and etc/images/right-arrow. Th= e=20 downside is that forward/back are now not themed. But all themes will be= =20 correct RTL-wise. c) You can also swap icons in x-gtk-stock-map, so you map=20 etc/images/left-arrow to gtk-go-forward and etc/images/right-arrow to=20 gtk-go-back. But remember that you did this if you change theme or your = theme=20 is fixed so that it supplies RTL information. >=20 >> Well, it would look like a "normal" tool bar, like the one you get wit= h=20 >> locale "C". >=20 > So the menu bar would the RTL, but the toolbar would be LTR? That's a > bit wiered, but I guess better than the current situation.=20 Emacs 22 and emacs CVS HEAD now behave the same in this regard, so forcin= g LTR=20 is not an option anymore. Jan D.