From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.bugs Subject: Re: help-make-xrefs Date: Mon, 27 Aug 2007 10:10:48 +0200 Message-ID: <46D28708.4060202@gmx.at> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1188202440 21248 80.91.229.12 (27 Aug 2007 08:14:00 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 27 Aug 2007 08:14:00 +0000 (UTC) Cc: Bug-Gnu-Emacs To: Drew Adams Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Aug 27 10:13:58 2007 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IPZjS-0007kD-Bd for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 Aug 2007 10:13:58 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IPZjR-0007NX-Op for geb-bug-gnu-emacs@m.gmane.org; Mon, 27 Aug 2007 04:13:57 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IPZjQ-0007NQ-Gy for bug-gnu-emacs@gnu.org; Mon, 27 Aug 2007 04:13:56 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IPZjO-0007NE-TD for bug-gnu-emacs@gnu.org; Mon, 27 Aug 2007 04:13:56 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IPZjO-0007NB-LU for bug-gnu-emacs@gnu.org; Mon, 27 Aug 2007 04:13:54 -0400 Original-Received: from mail.gmx.net ([213.165.64.20]) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1IPZjO-0004gJ-6v for bug-gnu-emacs@gnu.org; Mon, 27 Aug 2007 04:13:54 -0400 Original-Received: (qmail invoked by alias); 27 Aug 2007 08:13:52 -0000 Original-Received: from N811P010.adsl.highway.telekom.at (EHLO [62.47.45.74]) [62.47.45.74] by mail.gmx.net (mp034) with SMTP; 27 Aug 2007 10:13:52 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX19PfgU4nyJPnrBtWnSMSAvgNOgcmHvQvnoyqWekdP 1rnXCn8LKgp0fI User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: de-DE, de, en-us, en In-Reply-To: X-Y-GMX-Trusted: 0 X-Detected-Kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: bug-gnu-emacs@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:16455 Archived-At: > help-make-xrefs tries to be smart about providing links, but it could > use some improvement. In the *Help* buffer from `C-h b', for instance, > it provides links for commands that follow `M-x', even for cases such > as `C-M-x'. The comment for this code says "An obvious case of a key > substitution", which is not correct in this case. The regexp should > at least be changed to prohibit a symbol character just before `M-x'. After C-h b I get the line C-M-x eval-defun with a `help-function' button labeled `eval-defun' which doesn't seem entirely wrong. We could change the regexp in question to "\\_ Another problem in the `describe-bindings' display is this code on > line 465 that tries to back up over non-whitespace: > > (skip-chars-backward "^\t\n") > > This works only if `indent-tabs-mode' is non-nil in the *Help* buffer. > The string should be "^ \t\n" or equivalent. Otherwise, no commands > are linked. I fixed this on 2007-07-02.