From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.devel Subject: Re: [andrew.maguire@ge.com: Emacs 22.1 hung after delete-process] Date: Fri, 17 Aug 2007 21:40:19 +0100 Message-ID: <46C607B3.7060809@gnu.org> References: <46C404AD.8040908@gnu.org> <46C5A60D.5010108@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1187383459 13597 80.91.229.12 (17 Aug 2007 20:44:19 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Fri, 17 Aug 2007 20:44:19 +0000 (UTC) Cc: Glenn Morris , rms@gnu.org, emacs-devel@gnu.org To: dhruva Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Aug 17 22:44:15 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1IM8g2-0007TL-HD for ged-emacs-devel@m.gmane.org; Fri, 17 Aug 2007 22:44:14 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IM8g2-00054n-3M for ged-emacs-devel@m.gmane.org; Fri, 17 Aug 2007 16:44:14 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1IM8cU-0000c1-Nn for emacs-devel@gnu.org; Fri, 17 Aug 2007 16:40:34 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1IM8cS-0000Y0-DB for emacs-devel@gnu.org; Fri, 17 Aug 2007 16:40:33 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1IM8cR-0000XH-RY for emacs-devel@gnu.org; Fri, 17 Aug 2007 16:40:31 -0400 Original-Received: from outmail1.freedom2surf.net ([194.106.33.237]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1IM8cO-0005Zj-Eq; Fri, 17 Aug 2007 16:40:28 -0400 Original-Received: from [127.0.0.1] (i-83-67-23-108.freedom2surf.net [83.67.23.108]) by outmail1.freedom2surf.net (Postfix) with ESMTP id 8698652DED; Fri, 17 Aug 2007 21:40:27 +0100 (BST) User-Agent: Thunderbird 2.0.0.6 (Windows/20070728) In-Reply-To: X-Detected-Kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:76706 Archived-At: dhruva wrote: > I have not modified the the call to WaitForSingleObject in the latest > patch. I doubt the implementation of read which could be different for > different compilers (C-runtime library). > It may be implemented as a macro in one or both compilers, that would explain it. The C runtime library is the same system library in both cases (CRTDLL.DLL) > It is the call to read in _sys_read_ahead which continues to block > even after the sub process is killed. If we change that read to use > ReadFile using OVERLAPPED structure, we could handle canceling of IO > when we want to terminate the thread more elegantly. But, that would > be more changes as we need to use the HANDLE and not fd. > This would be a good change, not just here, but in sys_select in w32proc.c, which is overcomplicated due to a past design decision to use winsock 1.1 rather than winsock 2. We have changed that in 22.1 since the versions of Windows NT that lack winsock 2 support have not been supported by Emacs for some years now.