Re: C-x v l does not move to current log entry

["Jan Djärv" <jan.h.d@swipnet.se>]

Richard Stallman skrev:
> [I sent this message a week ago but did not get a response.
> Could we get the discussion moving again?]
> 

Stefan Monnier has fixed this.

	Jan D.

> Bob, thanks for making some progress.  Would someone else please take
> this the rest of the way, DTRT, and ack?
> 
> MIME-Version: 1.0
> Content-Type: multipart/mixed; boundary="aPqeXV8Jxn"
> Date: Fri, 3 Aug 2007 23:08:33 -0400
> From: Bob Rogers <rogers-emacs@rgrjr.dyndns.org>
> To: rms@gnu.org
> CC: emacs-devel@gnu.org, esr@snark.thyrsus.com
> Subject: Re: C-x v l does not move to current log entry
> In-Reply-To: <E1IGcrV-000310-Cs@fencepost.gnu.org>
> 
> 
> --aPqeXV8Jxn
> Content-Type: text/plain; charset=iso-8859-1
> Content-Description: message body text
> Content-Transfer-Encoding: 8bit
> 
>    From: Richard Stallman <rms@gnu.org>
>    Date: Thu, 02 Aug 2007 11:45:17 -0400
> 
>    Would someone please DTRT and ack?
> 
>    Date: Wed, 01 Aug 2007 09:51:17 +0200
>    From: Jan Djärv <jan.h.d@swipnet.se>
> 
>    % emacs -Q src/gmalloc.c
>    C-x v l
> 
>    The cursor stays at the top of the log view buffer.
>    Contrast this to emacs 22.1 where the cursor is positioned to the current
>    log entry for the revision of src/gmalloc.c that you are editing.
> 
> Hmm.  vc-default-show-log-entry does appear to be going to the right
> place, but something is messing it up afterwards.  I think I'll go to
> bed now and let somebody who knows what they're doing have a crack at
> it.  ;-}
> 
>    This from *Messages* may be relevant:
> 
>    Running cvs log gmalloc.c in the background... done
>    Loading log-view...
>    Loading easy-mmode...done
>    Loading log-view...done
>    Error during redisplay: (void-function ,log-view-file-re) [2 times]
> 
> This turns out to be coming from log-view-font-lock-keywords, which has
> a value that looks something like this:
> 
> 	((eval \` (\,log-view-file-re (1 ...) (0 log-view-file-face append)))
>          (eval \` (\,log-view-message-re . log-view-message-face)))
> 
> The source (log-view.el:170) specifies backquoted forms inside a quoted
> form; it appears that the reader is not handling this correctly.  The
> attached patch replaces the backquotes with explicit "cons" calls; this
> is not a real fix, and I include it only to show that it does make the
> error messages go away.  Fixing the reader is undoubtedly hairier.
> 
>    However, fixing the "Error during redisplay" problem does not affect
> the original symptom.
> 
>    Hope this is of some use,
> 
> 					-- Bob Rogers
> 					   http://rgrjr.dyndns.org/
> 
> 
> --aPqeXV8Jxn
> Content-Type: text/plain
> Content-Description: 
> Content-Disposition: inline;
> 	filename="no-bq-in-log-view-flk-1.patch"
> Content-Transfer-Encoding: 7bit
> 
> Index: lisp/log-view.el
> ===================================================================
> RCS file: /sources/emacs/emacs/lisp/log-view.el,v
> retrieving revision 1.37
> diff -c -r1.37 log-view.el
> *** lisp/log-view.el	23 Jun 2007 03:06:21 -0000	1.37
> --- lisp/log-view.el	4 Aug 2007 02:41:52 -0000
> ***************
> *** 170,179 ****
>   (defvar log-view-font-lock-keywords
>     ;; We use `eval' so as to use the buffer-local value of log-view-file-re
>     ;; and log-view-message-re, if applicable.
> !   '((eval . `(,log-view-file-re
> !               (1 (if (boundp 'cvs-filename-face) cvs-filename-face))
> !               (0 log-view-file-face append)))
> !     (eval . `(,log-view-message-re . log-view-message-face))))
>   (defconst log-view-font-lock-defaults
>     '(log-view-font-lock-keywords t nil nil nil))
>   
> --- 170,180 ----
>   (defvar log-view-font-lock-keywords
>     ;; We use `eval' so as to use the buffer-local value of log-view-file-re
>     ;; and log-view-message-re, if applicable.
> !   '((eval . (cons log-view-file-re
> ! 		  '((1 (if (boundp 'cvs-filename-face) cvs-filename-face))
> ! 		    (0 log-view-file-face append))))
> !     (eval . (cons log-view-message-re
> ! 		  'log-view-message-face))))
>   (defconst log-view-font-lock-defaults
>     '(log-view-font-lock-keywords t nil nil nil))
>   
> 
> --aPqeXV8Jxn--
> 
> 
> 
> _______________________________________________
> Emacs-devel mailing list
> Emacs-devel@gnu.org
> http://lists.gnu.org/mailman/listinfo/emacs-devel