From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jan =?UTF-8?Q?Dj=C3=A4rv?= Newsgroups: gmane.emacs.bugs Subject: bug#9781: 24.0.90; VC can't commit removed files/directories. Date: Tue, 18 Oct 2011 08:36:58 +0200 Message-ID: <46BCC398-40FE-4CE0-AAD4-26EFA06A3FDC@swipnet.se> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 (Apple Message framework v1251.1) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1318919913 6899 80.91.229.12 (18 Oct 2011 06:38:33 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 18 Oct 2011 06:38:33 +0000 (UTC) To: 9781@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Oct 18 08:38:24 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RG3Jg-0006sZ-9W for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Oct 2011 08:38:24 +0200 Original-Received: from localhost ([::1]:56980 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RG3Jf-00067Z-JA for geb-bug-gnu-emacs@m.gmane.org; Tue, 18 Oct 2011 02:38:23 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:40479) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RG3JX-00067C-68 for bug-gnu-emacs@gnu.org; Tue, 18 Oct 2011 02:38:21 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RG3JR-0004Jk-9c for bug-gnu-emacs@gnu.org; Tue, 18 Oct 2011 02:38:15 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:54360) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RG3JR-0004Jg-7w for bug-gnu-emacs@gnu.org; Tue, 18 Oct 2011 02:38:09 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RG3KK-0002vT-2n for bug-gnu-emacs@gnu.org; Tue, 18 Oct 2011 02:39:04 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Jan =?UTF-8?Q?Dj=C3=A4rv?= Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 18 Oct 2011 06:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 9781 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Original-Received: via spool by submit@debbugs.gnu.org id=B.131891990511190 (code B ref -1); Tue, 18 Oct 2011 06:39:02 +0000 Original-Received: (at submit) by debbugs.gnu.org; 18 Oct 2011 06:38:25 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RG3Jg-0002uR-Ix for submit@debbugs.gnu.org; Tue, 18 Oct 2011 02:38:24 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RG3Jc-0002uB-NG for submit@debbugs.gnu.org; Tue, 18 Oct 2011 02:38:22 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RG3IY-00048H-H9 for submit@debbugs.gnu.org; Tue, 18 Oct 2011 02:37:20 -0400 Original-Received: from lists.gnu.org ([140.186.70.17]:57963) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RG3IY-00048D-Fd for submit@debbugs.gnu.org; Tue, 18 Oct 2011 02:37:14 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:40279) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RG3IS-00066B-OX for bug-gnu-emacs@gnu.org; Tue, 18 Oct 2011 02:37:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RG3IL-00046W-TA for bug-gnu-emacs@gnu.org; Tue, 18 Oct 2011 02:37:08 -0400 Original-Received: from smtprelay-b12.telenor.se ([62.127.194.21]:33165) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RG3IL-00046D-Ix for bug-gnu-emacs@gnu.org; Tue, 18 Oct 2011 02:37:01 -0400 Original-Received: from iph3.telenor.se (iph3.telenor.se [195.54.127.134]) by smtprelay-b12.telenor.se (Postfix) with ESMTP id CDAADEA111 for ; Tue, 18 Oct 2011 08:36:59 +0200 (CEST) X-SENDER-IP: [85.225.45.201] X-LISTENER: [smtp.bredband.net] X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AphiAHsdnU5V4S3JPGdsb2JhbABDiTyfHhkBAQEBNzKBbgFAHBMBBDteDApLh2OWOqAkgyuDfGEEmSaMLg X-IronPort-AV: E=Sophos;i="4.69,363,1315173600"; d="scan'208";a="132478265" Original-Received: from c-c92de155.25-1-64736c10.cust.bredbandsbolaget.se (HELO coolsville.localdomain) ([85.225.45.201]) by iph3.telenor.se with ESMTP; 18 Oct 2011 08:36:59 +0200 Original-Received: from [172.20.199.13] (zeplin [172.20.199.13]) by coolsville.localdomain (Postfix) with ESMTPSA id 0DB617FA058 for ; Tue, 18 Oct 2011 08:36:59 +0200 (CEST) X-Mailer: Apple Mail (2.1251.1) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 18 Oct 2011 02:39:04 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:52764 Archived-At: This bug report will be sent to the Bug-GNU-Emacs mailing list and the GNU bug tracker at debbugs.gnu.org. Please check that the From: line contains a valid email address. After a delay of up to one day, you should receive an acknowledgement at that address. Please write in English if possible, as the Emacs maintainers usually do not have translators for other languages. Please describe exactly what actions triggered the bug, and the precise symptoms of the bug. If you can, give a recipe starting from `emacs -Q': I'm surprised nobody has seen this. In a bzr repository, do % bzr rm some-file and modify some other file. Then in Emacs, do vc-dir on the directory where the file was. Mark the file that is listed as removed. Also mark the edited file. Press v. Expected result: I can type in a log message and commit. Real result: A prompt in the minibuffer appears: some-file is edited but read-only; make it writable and continue? (y/n)=20= This is because in vc.el, vc-next-action there is this: (let ((ready-for-commit files)) ;; If files are edited but read-only, give user a chance to = correct (dolist (file files) (unless (file-writable-p file) ;; Make the file+buffer read-write. (unless (y-or-n-p (format "%s is edited but read-only; make = it writable and continue? " file)) (error "Aborted")) ;; Maybe we somehow lost permissions on the directory. (condition-case nil (set-file-modes file (logior (file-modes file) 128)) (error (error "Unable to make file writable"))) Files/directories that are removed are obviously not file-writable-p, so = the logic is wrong. Also, the choices in the question should be three: 1 Make writable and continue. 2 Don't make writable and continue 3 Abort As it is now, you either exit on the "Aborted" error or if you try to = continue on the "Unable to make file writable" error. Jan D. If Emacs crashed, and you have the Emacs process in the gdb debugger, please include the output from the following gdb commands: `bt full' and `xbacktrace'. For information about debugging Emacs, please read the file /Users/jhd/Applications/Emacs.app/Contents/Resources/etc/DEBUG. In GNU Emacs 24.0.90.1 (x86_64-apple-darwin11.2.0, NS = apple-appkit-1138.23) of 2011-10-18 on zeplin Windowing system distributor `Apple', version 10.3.1138 configured using `configure '--verbose' '--enable-asserts' '--with-ns' = '--without-x-toolkit' 'CFLAGS=3D-g'' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: C value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: sv_SE.UTF-8 value of $XMODIFIERS: nil locale-coding-system: utf-8-unix default enable-multibyte-characters: t Major mode: Lisp Interaction Minor modes in effect: desktop-save-mode: t delete-selection-mode: t icomplete-mode: t display-time-mode: t tooltip-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: x r e p o r t - e m Recent messages: Loading /Users/jhd/lib/elisp/BAK-file.el (source)...done Loading /Users/jhd/lib/elisp/ccsetup.el (source)...done Loading icomplete...done Loading desktop...done No desktop file. For information about GNU Emacs and the GNU system, type C-h C-a. Load-path shadows: None found. Features: (shadow sort gnus-util mail-extr message format-spec rfc822 mml mml-sec mm-decode mm-bodies mm-encode mail-parse rfc2231 rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mailabbrev mail-utils gmm-utils mailheader emacsbug desktop cus-start cus-load msb delsel advice help-fns advice-preload icomplete cc-mode cc-fonts easymenu cc-guess cc-menus cc-cmds cc-styles cc-align cc-engine cc-vars cc-defs regexp-opt time time-date tooltip ediff-hook vc-hooks lisp-float-type mwheel ns-win tool-bar dnd fontset image fringe lisp-mode register page menu-bar rfn-eshadow timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core frame cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese case-table epa-hook jka-cmpr-hook help simple abbrev minibuffer loaddefs button faces cus-face files text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote make-network-process ns multi-tty emacs)