From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Yuan Fu Newsgroups: gmane.emacs.bugs Subject: bug#60054: 29.0.60; Infinite loop when there are cyclic path in the parse tree Date: Thu, 15 Dec 2022 17:14:36 -0800 Message-ID: <46BB7A11-4231-4549-A126-618ACBD1B60E@gmail.com> References: <0998189C-4A9E-4B27-A8A0-D208D11E9A39@gmail.com> Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.1\)) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="12470"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 60054@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Dec 16 02:15:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p5zJm-00034h-SJ for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 16 Dec 2022 02:15:18 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p5zJZ-0006ng-J7; Thu, 15 Dec 2022 20:15:05 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p5zJX-0006nW-3k for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 20:15:03 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p5zJW-0007Sy-HV for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 20:15:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p5zJW-0006nO-DR for bug-gnu-emacs@gnu.org; Thu, 15 Dec 2022 20:15:02 -0500 X-Loop: help-debbugs@gnu.org In-Reply-To: <0998189C-4A9E-4B27-A8A0-D208D11E9A39@gmail.com> Resent-From: Yuan Fu Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 16 Dec 2022 01:15:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 60054 X-GNU-PR-Package: emacs Original-Received: via spool by 60054-submit@debbugs.gnu.org id=B60054.167115328826102 (code B ref 60054); Fri, 16 Dec 2022 01:15:02 +0000 Original-Received: (at 60054) by debbugs.gnu.org; 16 Dec 2022 01:14:48 +0000 Original-Received: from localhost ([127.0.0.1]:46009 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5zJH-0006mu-NE for submit@debbugs.gnu.org; Thu, 15 Dec 2022 20:14:47 -0500 Original-Received: from mail-pl1-f174.google.com ([209.85.214.174]:44559) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p5zJE-0006mm-M7 for 60054@debbugs.gnu.org; Thu, 15 Dec 2022 20:14:47 -0500 Original-Received: by mail-pl1-f174.google.com with SMTP id g10so778620plo.11 for <60054@debbugs.gnu.org>; Thu, 15 Dec 2022 17:14:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=zE7NZ91XAjO6ttubBakHF8mCPxYV/25tpoZaWuKVgUI=; b=F7R0ujdcmfCiqnWJOtk7VuvYTpebBZF6qZIOa/6f7qbdY0Vwer0WgR2LW0vspOy/RE l1/fZqoMWKa60qSZ6lTwXWeRl5dNjszsm9YbOhLqZmFuss5H08G+x/lIKFBTCs8QFxIC 5EyEQ5v8RwdQTsx6c88L2FNF26I0a7xg9zzLXJUeAmH4bGfm0HpYhztC0tdFOpwFcm7C rpGrFyUh304OV0fcAkdjr7TKGprhn+O7y/WL66/bNcCWKzPj0UI8h5SNKj+NfMhW7uQj gjghA9bArwMP/h7KwDmWC08LFyW7NyinN+ehATwx5jh95fztVmNZxMiA3VbNe6Ml+wjy +GeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=zE7NZ91XAjO6ttubBakHF8mCPxYV/25tpoZaWuKVgUI=; b=1XBbVCJWqLL0+X6ijRhoffBHshYCQI4KhCAXwY5rrx37rmPxZOjbnk0LfFqJefpBc3 Bw9LVc+IDwIYuI2oiuR/5dmU4xGij095+/aRuy+O7JuUbIHM0KS5R72y6yGFBUFW6IDX QSshk7DYMbZqQrnElujc2AJKXKKBhOVGXau4wuklaV7ppJgOUi1T3bIP+MhLM0hWU+bC cl1TXCtLlTb7HcMz6VHTkryqrFGklJx4/oZKsKBU2CRRVUEukGqyEECfcDmfYUnZ3hPI f3piDnLwss21NTofP0E2MZlROiYVt/ytwLR4AZ/XpeueBfnCODjDdNznUYUhT8DjLm6M ORxA== X-Gm-Message-State: ANoB5pm72KEfekhGiSQI0URUEqQFB64FQ1gwozwypeqG27if0Zrx6Rf+ ORWeJiNlaphSAomUVdp/bH2FimfFwn0= X-Google-Smtp-Source: AA0mqf4imj0kFrxvvuA4zWOafNASy3sdbJSXCYU+d7G59SWqjL8056lu/r1NRCbXBxb1rGMqAthy7w== X-Received: by 2002:a17:902:8bca:b0:188:b084:7bef with SMTP id r10-20020a1709028bca00b00188b0847befmr29359191plo.42.1671153278161; Thu, 15 Dec 2022 17:14:38 -0800 (PST) Original-Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id ix6-20020a170902f80600b00190cabbe35fsm268658plb.98.2022.12.15.17.14.37 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Dec 2022 17:14:37 -0800 (PST) X-Mailer: Apple Mail (2.3696.120.41.1.1) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251166 Archived-At: Eli Zaretskii writes: >> From: Yuan Fu >> Date: Wed, 14 Dec 2022 12:27:58 -0800 >> Cc: 60054@debbugs.gnu.org >>=20 >> >> https://github.com/tree-sitter/tree-sitter-c/issues/119 >> >>=20 >> >> So far, I=E2=80=99ve only observed this in that specific edge = case. >> >=20 >> > We should have protection against that, which should be easy, = right? >>=20 >> Just to make sure, we want to use something like slow-fast pointers, >> where we have two pointers, and one goes twice as fast, right? >> That=E2=80=99s the one I was taught in school :-) > > No, I mean protect us from inflooping by checking that the parent of a > node is not the node itself. In this particular case, it is the siblings=E2=80=99 parent that equals = to the node. Ie, node->sibling->parent =3D node. If your intention is to = protect us from this particular case, switching to use cursors will avoid this bug. Yuan