From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Dmitry Gutov Newsgroups: gmane.emacs.bugs Subject: bug#35353: 26.2; Buffer *xref*: (1) hard-coded mouse-1, (2) major mode name Date: Mon, 22 Apr 2019 12:24:11 +0300 Message-ID: <469bf659-07b6-8172-287c-2abc53582447@yandex.ru> References: <96cafba3-7ba2-4e87-8f9d-e53825fd1dde@default> <94feda5f-7afa-4ab5-96f8-60dfaba7e0a4@default> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="68091"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 To: Drew Adams , 35353@debbugs.gnu.org Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Mon Apr 22 11:25:21 2019 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1hIVCP-000HWZ-9u for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Apr 2019 11:25:17 +0200 Original-Received: from localhost ([127.0.0.1]:34601 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIVCN-0001cw-PT for geb-bug-gnu-emacs@m.gmane.org; Mon, 22 Apr 2019 05:25:15 -0400 Original-Received: from eggs.gnu.org ([209.51.188.92]:49035) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hIVCB-0001ck-DT for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2019 05:25:04 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hIVCA-0002IP-Fm for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2019 05:25:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:36143) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hIVCA-0002IF-9U for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2019 05:25:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hIVCA-00050D-1L for bug-gnu-emacs@gnu.org; Mon, 22 Apr 2019 05:25:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Dmitry Gutov Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 22 Apr 2019 09:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 35353 X-GNU-PR-Package: emacs Original-Received: via spool by 35353-submit@debbugs.gnu.org id=B35353.155592506219149 (code B ref 35353); Mon, 22 Apr 2019 09:25:01 +0000 Original-Received: (at 35353) by debbugs.gnu.org; 22 Apr 2019 09:24:22 +0000 Original-Received: from localhost ([127.0.0.1]:49684 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIVBW-0004yn-8c for submit@debbugs.gnu.org; Mon, 22 Apr 2019 05:24:22 -0400 Original-Received: from mail-lf1-f45.google.com ([209.85.167.45]:45415) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1hIVBV-0004ya-1x for 35353@debbugs.gnu.org; Mon, 22 Apr 2019 05:24:21 -0400 Original-Received: by mail-lf1-f45.google.com with SMTP id t11so8497907lfl.12 for <35353@debbugs.gnu.org>; Mon, 22 Apr 2019 02:24:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:subject:to:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=HeAWLGsrwr6Ukav1RJ3DbGRe9aW4uxr6soT03uah5lg=; b=siYrKAR9DqP7vG/Tb6oMI0o0gAwQnAt38fCJdn1eAhEb5mRne4OQfiWgrUY08nrI75 k6Qi85pHdp9D3eost/bjFm3xjImB63KFB4nF3zkyh5OXTizNV5bTBqVW27Kg6qgH8qpE n5gx8lJ05OZvJoE3KSNylDVkkhFNFO53kU17Kp+R1jRL/ppRdGfYYzH5meHHs9V0MKJ5 LroL3d9L7hRRuhoNPAorCUCWX9d/OhesEi23ooA29F4sFLePf+vMTJlKSBN8BWxEbRrY D8mbSDStoML8V4iDZYi6tdSPI0h1Uu7TOdstb5DAQWnhFBtg7S1jEQOI08CHGMRivCHi ftRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:subject:to:references:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=HeAWLGsrwr6Ukav1RJ3DbGRe9aW4uxr6soT03uah5lg=; b=omqLlnJY7X8VKjshF8s+ifwfXJDlksSEQlYTQo/zRoWrP+76PcXEsdxyX2LPBc3gVb oPYeSPi1BfhJEtAOyxv3mTp1HGMcUltjWLBsFHaa9w0YMlLmGm4OLBaI05VGNfVdR0T2 NIeGbKEPDSq74TrEfREgl3kFK2pFA9y/iECrSJmLXSayvzhyjey7bbqtpHAzUdid68Hq RTDme21fCk+UhUQ92AtHiwL8/WTgdsA0MUo++p6f1qUgCeV0pLpH+6TvwjeCeLjh7jhq PUMTGER08dh+iywRLc35OrOqaalmV5RIHd4kbOtr8chab659mAVRWSLFjejRL6IfGOfq NOVQ== X-Gm-Message-State: APjAAAX5F/eOFyrQaKdXfda6jWpmkxqtl4p3mkm9VezPsKjmXjNCfrHA p+SAFnpQ+5FmQrJkgk+/emGpVLVp X-Google-Smtp-Source: APXvYqw8jQ8JjeLZgFKeVc32WN6EzVIC+HY3q/j8LqbXMh5EVIC23n8w5ZO3xeYMi8tPLCA77O3cEQ== X-Received: by 2002:a19:e30b:: with SMTP id a11mr9674794lfh.4.1555925054788; Mon, 22 Apr 2019 02:24:14 -0700 (PDT) Original-Received: from [192.168.1.3] ([185.105.174.23]) by smtp.googlemail.com with ESMTPSA id v4sm2567007ljh.40.2019.04.22.02.24.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Apr 2019 02:24:13 -0700 (PDT) In-Reply-To: <94feda5f-7afa-4ab5-96f8-60dfaba7e0a4@default> Content-Language: en-US X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 209.51.188.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.org gmane.emacs.bugs:157994 Archived-At: On 21.04.2019 16:27, Drew Adams wrote: >> Please respect `mouse-1-click-follows-link'. > > Please contrast what, say, `compile.el' does, which is > simple and Emacs-conventional: > > (define-key map [mouse-2] 'compile-goto-error) > (define-key map [follow-link] 'mouse-face) > > See (elisp) `Key Binding Conventions': > > Many special major modes, like Dired, Info, Compilation, > and Occur, are designed to handle read-only text that > contains "hyper-links". > > Such a major mode should redefine 'mouse-2' and to > ^^^^^^^^^^^^^^^^^^^^^^^^^ > follow the links. It should also set up a 'follow-link' > ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ > condition, so that the link obeys 'mouse-1-click-follows-link'. > > *Note Clickable Text::. *Note Buttons::, for an easy > method of implementing such clickable links. > > Each core Emacs developer who defines a major mode with > clickable links should be familiar with and respect this > convention. Thank you for the report. It's not hard to fix, but it seems to do that we'll have to give mouse-2 a different binding from what it has now. Which is also a breaking change (in Xref). I'd like to let someone else decide whether this is worth it.