all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Dmitry Gutov <dgutov@yandex.ru>
To: Drew Adams <drew.adams@oracle.com>, 35353@debbugs.gnu.org
Subject: bug#35353: 26.2; Buffer *xref*: (1) hard-coded mouse-1, (2) major mode name
Date: Mon, 22 Apr 2019 12:24:11 +0300	[thread overview]
Message-ID: <469bf659-07b6-8172-287c-2abc53582447@yandex.ru> (raw)
In-Reply-To: <94feda5f-7afa-4ab5-96f8-60dfaba7e0a4@default>

On 21.04.2019 16:27, Drew Adams wrote:
>> Please respect `mouse-1-click-follows-link'.
> 
> Please contrast what, say, `compile.el' does, which is
> simple and Emacs-conventional:
> 
>   (define-key map [mouse-2]     'compile-goto-error)
>   (define-key map [follow-link] 'mouse-face)
> 
> See (elisp) `Key Binding Conventions':
> 
>   Many special major modes, like Dired, Info, Compilation,
>   and Occur, are designed to handle read-only text that
>   contains "hyper-links".
> 
>   Such a major mode should redefine 'mouse-2' and <RET> to
>                     ^^^^^^^^^^^^^^^^^^^^^^^^^
>   follow the links.  It should also set up a 'follow-link'
>                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
>   condition, so that the link obeys 'mouse-1-click-follows-link'.
> 
>   *Note Clickable Text::.  *Note Buttons::, for an easy
>   method of implementing such clickable links.
> 
> Each core Emacs developer who defines a major mode with
> clickable links should be familiar with and respect this
> convention.

Thank you for the report.

It's not hard to fix, but it seems to do that we'll have to give mouse-2 
a different binding from what it has now. Which is also a breaking 
change (in Xref).

I'd like to let someone else decide whether this is worth it.





  reply	other threads:[~2019-04-22  9:24 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-04-21  2:50 bug#35353: 26.2; Buffer *xref*: (1) hard-coded mouse-1, (2) major mode name Drew Adams
2019-04-21 13:27 ` Drew Adams
2019-04-22  9:24   ` Dmitry Gutov [this message]
2019-04-22  9:42     ` Eli Zaretskii
2019-04-22  9:48       ` Dmitry Gutov
2019-04-22 10:09         ` Eli Zaretskii
2019-04-22 10:18           ` Dmitry Gutov
2019-04-22 10:21             ` Eli Zaretskii
2019-04-22 10:52               ` Dmitry Gutov
2019-04-22 10:57                 ` Dmitry Gutov
2019-04-22 11:42                   ` Phil Sainty
2019-04-22 13:08                     ` Drew Adams
2019-05-02 22:35                       ` Dmitry Gutov
2019-05-02 23:22                         ` Drew Adams
2019-05-02 23:31                           ` Dmitry Gutov
2019-05-03  0:27                             ` Drew Adams
2019-05-04 21:21                           ` Richard Stallman
2019-05-04 22:25                             ` Drew Adams
2019-05-05 22:50                               ` Richard Stallman
2019-05-06  0:40                                 ` Drew Adams
2019-05-06  8:45                                   ` Dmitry Gutov
2019-05-06 13:29                                     ` Drew Adams
2019-05-02 22:48                       ` Dmitry Gutov
2019-05-02 23:22                         ` Drew Adams
2019-05-02 23:34                           ` Dmitry Gutov
2019-05-03  0:27                             ` Drew Adams
2019-04-22 11:07                 ` Drew Adams
2019-04-22 11:18                 ` Eli Zaretskii
2019-04-22 11:30                   ` Dmitry Gutov
2019-04-22 11:34                     ` Eli Zaretskii
2019-05-02 22:49                       ` Dmitry Gutov
2019-05-03  6:38                         ` Eli Zaretskii
2020-08-22 14:41                 ` Lars Ingebrigtsen
2020-08-22 17:46                   ` Drew Adams
     [not found]             ` <<83v9z6732b.fsf@gnu.org>
2019-04-22 11:07               ` Drew Adams
2019-04-22 11:20                 ` Eli Zaretskii
     [not found]             ` <<<83v9z6732b.fsf@gnu.org>
     [not found]               ` <<376d5335-eb80-4272-8847-e764242a02b7@default>
     [not found]                 ` <<83r29u70cy.fsf@gnu.org>
2019-04-22 12:23                   ` Drew Adams
2019-04-22 13:05                     ` Eli Zaretskii
     [not found]             ` <<<<83v9z6732b.fsf@gnu.org>
     [not found]               ` <<<376d5335-eb80-4272-8847-e764242a02b7@default>
     [not found]                 ` <<<83r29u70cy.fsf@gnu.org>
     [not found]                   ` <<c1e7f520-7dff-41e0-ba01-9828b87cb703@default>
     [not found]                     ` <<83imv66vi2.fsf@gnu.org>
2019-04-22 13:23                       ` Drew Adams
2019-04-22 13:33                         ` Eli Zaretskii
     [not found]         ` <<83y34273mu.fsf@gnu.org>
2019-04-22 10:58           ` Drew Adams
2022-04-29 12:01 ` Lars Ingebrigtsen
2022-04-29 17:13   ` Juri Linkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=469bf659-07b6-8172-287c-2abc53582447@yandex.ru \
    --to=dgutov@yandex.ru \
    --cc=35353@debbugs.gnu.org \
    --cc=drew.adams@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.