From: martin rudalics <rudalics@gmx.at>
To: rms@gnu.org
Cc: emacs-devel@gnu.org
Subject: Re: insert-file-contents and format-decode
Date: Tue, 03 Jul 2007 08:47:05 +0200 [thread overview]
Message-ID: <4689F0E9.4070706@gmx.at> (raw)
In-Reply-To: <E1I5ZwJ-0007ht-9P@fencepost.gnu.org>
> ! (let (value size old-undo)
> ! ;; Record only one undo entry for the insertion. Inhibit point-motion and
> ! ;; modification hooks as with `insert-file-contents'.
> ! (let ((inhibit-point-motion-hooks t)
> ! (inhibit-modification-hooks t))
> ! ;; Don't bind `buffer-undo-list' to t here to assert that
> ! ;; `insert-file-contents' may record whether the buffer was unmodified
> ! ;; before.
> ! (let ((format-alist nil))
> ! (setq value (insert-file-contents filename nil beg end))
> ! (setq size (nth 1 value)))
> ! (when (consp buffer-undo-list)
> ! (let ((head (car buffer-undo-list)))
> ! (when (and (consp head)
> ! (equal (car head) (point))
> ! (equal (cdr head) (+ (point) size)))
> ! ;; Remove first entry from `buffer-undo-list', we shall insert
> ! ;; another one below.
> ! (setq old-undo (cdr buffer-undo-list)))))
>
> That pateh is basically good, but it could be simpler. Instead of
> letting insert-file-contents produce an undo entry and taking it off
> and taking it apart, it would be better to inhibit undo around
> insert-file-contents and generate the undo entry from scratch in all
> cases. When no format decoding is done, VALUE has the size you need.
It's complicated because I may have to create the (t HIGH . LOW) entry
to indicate that the buffer previously had "unmodified" status. With my
solution I let `insert-file-contents' take care of that automatically.
With your solution I would have to create it manually and care about the
modification time myself. Is it worth the trouble?
next prev parent reply other threads:[~2007-07-03 6:47 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-06 14:06 insert-file-contents and format-decode martin rudalics
2007-06-08 7:12 ` Richard Stallman
2007-06-17 13:34 ` martin rudalics
2007-06-18 21:31 ` Richard Stallman
2007-06-19 7:50 ` martin rudalics
2007-06-23 18:26 ` Richard Stallman
2007-06-23 18:26 ` Richard Stallman
2007-06-24 10:30 ` martin rudalics
2007-06-25 13:19 ` Richard Stallman
2007-06-26 6:54 ` martin rudalics
2007-06-26 22:48 ` Richard Stallman
2007-06-27 6:33 ` martin rudalics
2007-06-27 19:50 ` Richard Stallman
2007-06-30 11:11 ` martin rudalics
2007-07-01 0:30 ` Richard Stallman
2007-07-02 8:14 ` martin rudalics
2007-07-03 4:24 ` Richard Stallman
2007-07-03 6:47 ` martin rudalics [this message]
2007-07-04 3:43 ` Richard Stallman
2007-06-26 22:48 ` Richard Stallman
2007-06-27 6:34 ` martin rudalics
2007-06-27 23:43 ` Richard Stallman
2007-06-30 11:32 ` martin rudalics
2007-07-01 0:30 ` Richard Stallman
2007-07-02 8:27 ` martin rudalics
2007-07-03 4:24 ` Richard Stallman
2007-07-03 6:43 ` martin rudalics
2007-08-06 14:22 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4689F0E9.4070706@gmx.at \
--to=rudalics@gmx.at \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.