From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mauro Aranda Newsgroups: gmane.emacs.bugs Subject: bug#64347: 30.0.50; Some customize faces shown as edited with -Q Date: Sat, 15 Jul 2023 17:01:44 -0300 Message-ID: <467e6be9-8238-53e8-d221-0cb407ec3d84@gmail.com> References: <87jzvmd17f.fsf@gmx.net> <83cz1etpdm.fsf@gnu.org> <2b6de9de-f33f-0547-eaa0-1f9d24f70115@gmail.com> <28fa0831-bb28-b7c1-1535-3a950f6b2545@gmail.com> <83y1jqdeqm.fsf@gnu.org> <748ccb81-d56c-76aa-d06b-47e4e3807ddb@gmail.com> <83mt05bpwh.fsf@gnu.org> <83lefp9tbd.fsf@gnu.org> <26d4603c-302c-8de9-fb22-8d0720516bb0@gmail.com> <83sf9w7x1i.fsf@gnu.org> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------FAr0jrOGD7KfD4yRUUFm4kjk" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23101"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Cc: stephen.berman@gmx.net, 64347@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Jul 15 22:02:22 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qKlTB-0005pg-Mi for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 15 Jul 2023 22:02:21 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qKlSw-0003Mq-5N; Sat, 15 Jul 2023 16:02:07 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qKlSs-0003Md-Sk for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 16:02:02 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qKlSs-00028Y-Ku for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 16:02:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qKlSs-0002Nn-3n for bug-gnu-emacs@gnu.org; Sat, 15 Jul 2023 16:02:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 15 Jul 2023 20:02:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 64347 X-GNU-PR-Package: emacs Original-Received: via spool by 64347-submit@debbugs.gnu.org id=B64347.16894513219151 (code B ref 64347); Sat, 15 Jul 2023 20:02:02 +0000 Original-Received: (at 64347) by debbugs.gnu.org; 15 Jul 2023 20:02:01 +0000 Original-Received: from localhost ([127.0.0.1]:46142 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKlSq-0002NW-Aq for submit@debbugs.gnu.org; Sat, 15 Jul 2023 16:02:00 -0400 Original-Received: from mail-ot1-x330.google.com ([2607:f8b0:4864:20::330]:47594) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qKlSm-0002NC-Am for 64347@debbugs.gnu.org; Sat, 15 Jul 2023 16:01:58 -0400 Original-Received: by mail-ot1-x330.google.com with SMTP id 46e09a7af769-6b7541d885cso2388462a34.3 for <64347@debbugs.gnu.org>; Sat, 15 Jul 2023 13:01:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689451310; x=1692043310; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:from:to:cc:subject:date :message-id:reply-to; bh=7MMB+Y1UysCgAUoOMHuWBvsD6gA/VQBhCUuLUhuCv2E=; b=TnBKzXp+0AxVYFS51JO2kTjqGmkyZKL2AoCS4470Od+evESFJHhKLPMcZbkuiqgcOK ssgHyHT++XoEr4L75MNtSH0o3a2uAy4I4JJ9kzwQoGkUZDwvh6FiNkwbPAJDUe0iHWwo MEWcb8Uzl0YjPrwG5RGJgXYE/fLUekL1sbZR1ALiM07huCvTvxrRbx+ZsC/Cy+pu1Ekq jyBBKLwtcOU2AmJaayftqKO2/hWbsTBqJghJ52xZnjnYfhkA5Un0kI98d8JXqFcqreDA OFNndEHO/oMmUZ59oHXQYLKm7gKS5JQxKJ+XdOFoEPR2Tpr77iOPSSuxk4vwMDrVnYGv co8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689451310; x=1692043310; h=in-reply-to:from:content-language:references:cc:to:subject :user-agent:mime-version:date:message-id:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=7MMB+Y1UysCgAUoOMHuWBvsD6gA/VQBhCUuLUhuCv2E=; b=BzRTzw+inplSIVn10+AtguAP/O4+CD9d9ugWidWPloSK66UI4e0lnxe8QNhC4GKJxF 0FbtoJV7S1BaANu/DryPtmmF3A7Kv0Zr1zlKfy7l/8j5W5LOeXwIzLzCff3HgMobhSV5 3Rbok3yYLVz3l0VR7Kl6X7nbTtTOun72+TIP9qkE0w9Lym1vuY8OwH4Evdv2v7gs1ec1 y0I1qWRiL7qII7FjBfPPW4x6c1vOKxBr9yCRRq5X7t7xhMkzv5gS9PXjD3rGnhV5nmps Ug3gOxpG8+XTVw7e4EgLeI79H5HJJCPCF/cTkV4YuOiySRTQf5ip2XnHYR279Y0iVpl8 cVeQ== X-Gm-Message-State: ABy/qLao+PAKq45btFduhJlouk1KB+UppnlENvvaKX/PnpOZy9By5njy po89j/N+7Hz52CNL4emqHyo= X-Google-Smtp-Source: APBJJlEkghKQoCpFIjE0ClLCEhQZTPhyxB7RFtotk50jD5dmLatSBIKdc1XNqWxxVH2AGXAaCbSW1g== X-Received: by 2002:a05:6870:a707:b0:17f:7388:4c69 with SMTP id g7-20020a056870a70700b0017f73884c69mr8815372oam.30.1689451310525; Sat, 15 Jul 2023 13:01:50 -0700 (PDT) Original-Received: from [192.168.0.234] ([186.127.128.249]) by smtp.gmail.com with ESMTPSA id z21-20020a056871039500b001b0cad9f72esm5367064oaf.18.2023.07.15.13.01.48 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 15 Jul 2023 13:01:49 -0700 (PDT) Content-Language: en-US In-Reply-To: <83sf9w7x1i.fsf@gnu.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:265245 Archived-At: This is a multi-part message in MIME format. --------------FAr0jrOGD7KfD4yRUUFm4kjk Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Eli Zaretskii writes: >> Date: Sun, 9 Jul 2023 20:12:38 -0300 >> Cc: 64347@debbugs.gnu.org, stephen.berman@gmx.net >> From: Mauro Aranda >> >> Eli Zaretskii writes: >> >>  > OK, but why does it have to do that on the original value? It could >>  > do that on a copy that serves for the display and editing, in which >>  > case the original value could be left intact if the user didn't change >>  > it or did change, but didn't click Apply.  (If the user does modify >>  > the original value, then any conversions are okay, since the variable >>  > is really "edited".) >> >> I think my description was inaccurate, because it seemed to imply that >> it is a destructive operation.  It is not, it leaves the original value >> intact. >> >> But when deciding to set a state, Custom always consults the spec built >> from the data the face Widget has. > > Can we change this last aspect, so that the state is set using the > original spec if the setting was not changed by the user? OK, here's a patch for doing that.  It seems to me that after creating the widget, the only reason to use the value that's represented in the widget is if we loaded the spec from the :shown-value property (meaning we are redrawing the widget and we want to keep a spec that was already in the widget) --------------FAr0jrOGD7KfD4yRUUFm4kjk Content-Type: text/x-patch; charset=UTF-8; name="0001-Pass-original-spec-just-after-creating-the-face-widg.patch" Content-Disposition: attachment; filename*0="0001-Pass-original-spec-just-after-creating-the-face-widg.pa"; filename*1="tch" Content-Transfer-Encoding: base64 RnJvbSA3ZmZiM2Y0NjZjYjNjMDgwNGY4Y2IwZWMyNTE3MWU2MDEzZjQxZGZmIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFp bC5jb20+CkRhdGU6IE1vbiwgMTAgSnVsIDIwMjMgMTA6NDc6MjMgLTAzMDAKU3ViamVjdDog W1BBVENIXSBQYXNzIG9yaWdpbmFsIHNwZWMganVzdCBhZnRlciBjcmVhdGluZyB0aGUgZmFj ZS13aWRnZXQKCiogbGlzcC9jdXMtZWRpdC5lbCAoY3VzdG9tLWZhY2UtZ2V0LWN1cnJlbnQt c3BlYy11bmZpbHRlcmVkKTogTmV3CmZ1bmN0aW9uLCBleHRyYWN0ZWQgZnJvbSBjdXN0b20t ZmFjZS1nZXQtY3VycmVudC1zcGVjLgooY3VzdG9tLWZhY2UtZ2V0LWN1cnJlbnQtc3BlYyk6 IFVzZSBpdC4KKGN1c3RvbS1mYWNlLXN0YXRlLXNldCk6IFRha2UgYW4gb3B0aW9uYWwgYXJn dW1lbnQsIHRvIGRlY2lkZSBpZiB3ZQpzaG91bGQgY2hlY2sgYWdhaW5zdCBhIGZpbHRlcmVk IG9yIHVuZmlsdGVyZWQgc3BlYy4KKGN1c3RvbS1mYWNlLXZhbHVlLWNyZWF0ZSk6IFVzZSB0 aGUgbmV3IG9wdGlvbmFsIGFyZ3VtZW50LiAgKEJ1ZyM2NDM0NykKLS0tCiBsaXNwL2N1cy1l ZGl0LmVsIHwgMjYgKysrKysrKysrKysrKysrKysrLS0tLS0tLS0KIDEgZmlsZSBjaGFuZ2Vk LCAxOCBpbnNlcnRpb25zKCspLCA4IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2xpc3Av Y3VzLWVkaXQuZWwgYi9saXNwL2N1cy1lZGl0LmVsCmluZGV4IGRiZWY1ZjQ3Y2Q2Li5jNWRk Y2E5YmMyOSAxMDA2NDQKLS0tIGEvbGlzcC9jdXMtZWRpdC5lbAorKysgYi9saXNwL2N1cy1l ZGl0LmVsCkBAIC0zNzE3LDcgKzM3MTcsOCBAQCBjdXN0b20tZmFjZS13aWRnZXQtdG8tc3Bl YwogCSBgKCh0ICwod2lkZ2V0LXZhbHVlIGNoaWxkKSkpCiAgICAgICAgKHdpZGdldC12YWx1 ZSBjaGlsZCkpKSkpCiAKLShkZWZ1biBjdXN0b20tZmFjZS1nZXQtY3VycmVudC1zcGVjIChm YWNlKQorKGRlZnVuIGN1c3RvbS1mYWNlLWdldC1jdXJyZW50LXNwZWMtdW5maWx0ZXJlZCAo ZmFjZSkKKyAgIlJldHVybiB0aGUgY3VycmVudCBzcGVjIGZvciBmYWNlIEZBQ0UsIHdpdGhv dXQgZmlsdGVyaW5nIGl0LiIKICAgKGxldCAoKHNwZWMgKG9yIChnZXQgZmFjZSAnY3VzdG9t aXplZC1mYWNlKQogCQkgIChnZXQgZmFjZSAnc2F2ZWQtZmFjZSkKIAkJICAoZ2V0IGZhY2Ug J2ZhY2UtZGVmZmFjZS1zcGVjKQpAQCAtMzcyOCw3ICszNzI5LDExIEBAIGN1c3RvbS1mYWNl LWdldC1jdXJyZW50LXNwZWMKICAgICA7OyBlZGl0IGl0IGFzIHRoZSB1c2VyIGhhcyBzcGVj aWZpZWQgaXQuCiAgICAgKGlmIChub3QgKGZhY2Utc3BlYy1tYXRjaC1wIGZhY2Ugc3BlYyAo c2VsZWN0ZWQtZnJhbWUpKSkKIAkoc2V0cSBzcGVjIGAoKHQgLChmYWNlLWF0dHItY29uc3Ry dWN0IGZhY2UgKHNlbGVjdGVkLWZyYW1lKSkpKSkpCi0gICAgKGN1c3RvbS1wcmUtZmlsdGVy LWZhY2Utc3BlYyBzcGVjKSkpCisgICAgc3BlYykpCisKKyhkZWZ1biBjdXN0b20tZmFjZS1n ZXQtY3VycmVudC1zcGVjIChmYWNlKQorICAiUmV0dXJuIHRoZSBjdXJyZW50IHNwZWMgZm9y IGZhY2UgRkFDRSwgZmlsdGVyaW5nIGl0LiIKKyAgKGN1c3RvbS1wcmUtZmlsdGVyLWZhY2Ut c3BlYyAoY3VzdG9tLWZhY2UtZ2V0LWN1cnJlbnQtc3BlYy11bmZpbHRlcmVkIGZhY2UpKSkK IAogKGRlZnVuIGN1c3RvbS10b2dnbGUtaGlkZS1mYWNlICh2aXNpYmlsaXR5LXdpZGdldCAm cmVzdCBfaWdub3JlKQogICAiVG9nZ2xlIHRoZSB2aXNpYmlsaXR5IG9mIGEgYGN1c3RvbS1m YWNlJyBwYXJlbnQgd2lkZ2V0LgpAQCAtMzg0OCw4ICszODUzLDggQEAgY3VzdG9tLWZhY2Ut dmFsdWUtY3JlYXRlCiAJKHVubGVzcyAod2lkZ2V0LWdldCB3aWRnZXQgOmN1c3RvbS1mb3Jt KQogCSAgKHdpZGdldC1wdXQgd2lkZ2V0IDpjdXN0b20tZm9ybSBjdXN0b20tZmFjZS1kZWZh dWx0LWZvcm0pKQogCi0JKGxldCogKChzcGVjIChvciAod2lkZ2V0LWdldCB3aWRnZXQgOnNo b3duLXZhbHVlKQotCQkJIChjdXN0b20tZmFjZS1nZXQtY3VycmVudC1zcGVjIHN5bWJvbCkp KQorCShsZXQqICgoc2hvd24tdmFsdWUgKHdpZGdldC1nZXQgd2lkZ2V0IDpzaG93bi12YWx1 ZSkpCisgICAgICAgICAgICAgICAoc3BlYyAob3Igc2hvd24tdmFsdWUgKGN1c3RvbS1mYWNl LWdldC1jdXJyZW50LXNwZWMgc3ltYm9sKSkpCiAJICAgICAgIChmb3JtICh3aWRnZXQtZ2V0 IHdpZGdldCA6Y3VzdG9tLWZvcm0pKQogCSAgICAgICAoaW5kZW50ICh3aWRnZXQtZ2V0IHdp ZGdldCA6aW5kZW50KSkKIAkgICAgICAgZmFjZS1hbGlzdCBmYWNlLWVudHJ5IHNwZWMtZGVm YXVsdCBzcGVjLW1hdGNoIGVkaXRvcikKQEAgLTM4OTAsNyArMzg5NSw3IEBAIGN1c3RvbS1m YWNlLXZhbHVlLWNyZWF0ZQogCQkgICB3aWRnZXQgJ3NleHAgOnZhbHVlIHNwZWMpKSkpCiAg ICAgICAgICAgKHB1c2ggZWRpdG9yIGNoaWxkcmVuKQogICAgICAgICAgICh3aWRnZXQtcHV0 IHdpZGdldCA6Y2hpbGRyZW4gY2hpbGRyZW4pCi0JICAoY3VzdG9tLWZhY2Utc3RhdGUtc2V0 IHdpZGdldCkpKSkpKQorCSAgKGN1c3RvbS1mYWNlLXN0YXRlLXNldCB3aWRnZXQgKG5vdCBz aG93bi12YWx1ZSkpKSkpKSkKIAogKGRlZnVuIGN1cy0tZmFjZS1saW5rICh3aWRnZXQgX2Zv cm1hdCkKICAgKHdpZGdldC1jcmVhdGUtY2hpbGQtYW5kLWNvbnZlcnQKQEAgLTQwMTAsMTMg KzQwMTUsMTggQEAgY3VzdG9tLWZhY2Utc3RhdGUKIAknY2hhbmdlZAogICAgICAgc3RhdGUp KSkKIAotKGRlZnVuIGN1c3RvbS1mYWNlLXN0YXRlLXNldCAod2lkZ2V0KQorKGRlZnVuIGN1 c3RvbS1mYWNlLXN0YXRlLXNldCAod2lkZ2V0ICZvcHRpb25hbCBuby1maWx0ZXIpCiAgICJT ZXQgdGhlIHN0YXRlIG9mIFdJREdFVCwgYSBjdXN0b20tZmFjZSB3aWRnZXQuCiBJZiB0aGUg dXNlciBlZGl0ZWQgdGhlIHdpZGdldCwgc2V0IHRoZSBzdGF0ZSB0byBtb2RpZmllZC4gIElm IG5vdCwgdGhlIG5ldwotc3RhdGUgaXMgb25lIG9mIHRoZSByZXR1cm4gdmFsdWVzIG9mIGBj dXN0b20tZmFjZS1zdGF0ZScuIgorc3RhdGUgaXMgb25lIG9mIHRoZSByZXR1cm4gdmFsdWVz IG9mIGBjdXN0b20tZmFjZS1zdGF0ZScuCitPcHRpb25hbCBhcmd1bWVudCBOTy1GSUxURVIg bWVhbnMgdG8gY2hlY2sgYWdhaW5zdCBhbiB1bmZpbHRlcmVkIHNwZWMuIgogICAobGV0ICgo ZmFjZSAod2lkZ2V0LXZhbHVlIHdpZGdldCkpKQogICAgICh3aWRnZXQtcHV0IHdpZGdldCA6 Y3VzdG9tLXN0YXRlCi0gICAgICAgICAgICAgICAgKGlmIChmYWNlLXNwZWMtbWF0Y2gtcCBm YWNlIChjdXN0b20tZmFjZS13aWRnZXQtdG8tc3BlYyB3aWRnZXQpKQorICAgICAgICAgICAg ICAgIChpZiAoZmFjZS1zcGVjLW1hdGNoLXAKKyAgICAgICAgICAgICAgICAgICAgIGZhY2UK KyAgICAgICAgICAgICAgICAgICAgIChpZiBuby1maWx0ZXIKKyAgICAgICAgICAgICAgICAg ICAgICAgICAoY3VzdG9tLWZhY2UtZ2V0LWN1cnJlbnQtc3BlYy11bmZpbHRlcmVkIGZhY2Up CisgICAgICAgICAgICAgICAgICAgICAgIChjdXN0b20tZmFjZS13aWRnZXQtdG8tc3BlYyB3 aWRnZXQpKSkKICAgICAgICAgICAgICAgICAgICAgKGN1c3RvbS1mYWNlLXN0YXRlIGZhY2Up CiAgICAgICAgICAgICAgICAgICAnbW9kaWZpZWQpKSkpCiAKLS0gCjIuMzQuMQoK --------------FAr0jrOGD7KfD4yRUUFm4kjk--