Strange behaviour after Show/Hide Speedbar in Emacs 22.1

Strange behaviour after Show/Hide Speedbar in Emacs 22.1

[Angelo Graziosi]

I have observed this behaviour in Emacs 22.1:

Click on Options | Show/Hide | Speedbar : the speedbar is shown.

Then click on Options | Show/Hide | Speedbar : the speedbar is hidden.

Now the strangeness: trying to exiting Emacs by clicking on the 'X'
(close) button of the window (each window has three buttons: minimize,
maximize, close), Emacs does not exit and in the minibuffer:

   Attempt to delete the sole visible or iconified frame

In 'Messages':

   speedbar-handle-delete-frame: Attempt to delete the sole visible or
                                 iconified frame


It look as if the speedbar were still 'live'

Now one can exit from Emacs only using File | Exit Emacs  or C-x C-c.


This behaviour happens on Cygwin and on GNU/Linux Kubuntu Dapper 6.06.


   Angelo.

Re: Strange behaviour after Show/Hide Speedbar in Emacs 22.1

[Juanma Barranquero]

On 6/25/07, Angelo Graziosi <Angelo.Graziosi@roma1.infn.it> wrote:

> It look as if the speedbar were still 'live'

It is live, if somewhat hidden :)

Try the following patch.

             Juanma


P.S.: Eric, is this patch OK?



Index: lisp/speedbar.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/speedbar.el,v
retrieving revision 1.87
diff -u -2 -r1.87 speedbar.el
--- lisp/speedbar.el	19 Feb 2007 13:37:23 -0000	1.87
+++ lisp/speedbar.el	25 Jun 2007 10:24:07 -0000
@@ -1012,6 +1012,8 @@
     )
   ;; Frame modifications
-  (set (make-local-variable 'dframe-delete-frame-function)
-       'speedbar-handle-delete-frame)
+  (if speedbar-frame
+      (set (make-local-variable 'dframe-delete-frame-function)
+	   'speedbar-handle-delete-frame)
+    (kill-local-variable 'dframe-delete-frame-function))
   ;; hscroll
   (set (make-local-variable 'automatic-hscrolling) nil) ; Emacs 21

Re: Strange behaviour after Show/Hide Speedbar in Emacs 22.1

[Leo]

----- Juanma Barranquero (2007-06-25) wrote:-----

> On 6/25/07, Angelo Graziosi <Angelo.Graziosi@roma1.infn.it> wrote:
>
>> It look as if the speedbar were still 'live'
>
> It is live, if somewhat hidden :)
>
> Try the following patch.
>
>              Juanma
>
>
> P.S.: Eric, is this patch OK?

Can the latest speedbar from cedet be installed in trunk?

-- 
Leo <sdl.web AT gmail.com>                         (GPG Key: 9283AA3F)

Re: Strange behaviour after Show/Hide Speedbar in Emacs 22.1

[Juanma Barranquero]

On 6/25/07, Leo <sdl.web@gmail.com> wrote:

> Can the latest speedbar from cedet be installed in trunk?

I don't know how updates from cedet have been handled before.
According to the change logs, Nick Roberts seems to be the most active
developer wrt to speedbar.

             Juanma

Re: Strange behaviour after Show/Hide Speedbar in Emacs 22.1

[Nick Roberts]

 > Can the latest speedbar from cedet be installed in trunk?

It will surely break changes that I have made for using with GDB.

What benefits does it bring?

-- 
Nick                                           http://www.inet.net.nz/~nickrob

Re: Strange behaviour after Show/Hide Speedbar in Emacs 22.1

[Leo]

----- Nick Roberts (2007-06-25) wrote:-----

>  > Can the latest speedbar from cedet be installed in trunk?
>
> It will surely break changes that I have made for using with GDB.

That means when users install cedet they break GDB unconsciously.

> What benefits does it bring?

Some bug fixes I guess.

-- 
Leo <sdl.web AT gmail.com>                         (GPG Key: 9283AA3F)

Re: Strange behaviour after Show/Hide Speedbar in Emacs 22.1

[Nick Roberts]

 > >  > Can the latest speedbar from cedet be installed in trunk?
 > >
 > > It will surely break changes that I have made for using with GDB.
 > 
 > That means when users install cedet they break GDB unconsciously.

That might be true, I don't know how Cedet works.  With the best will in the
world it's not possible to test the consequences for all the external packages.
I find it hard enough trying to make sure I haven't broken things _within_
Emacs!

 > > What benefits does it bring?
 > 
 > Some bug fixes I guess.

Doesn't sound very compelling.

Trying to be more positive, I think it would be a good idea to move the watch
expressions for GDB out of the speedbar and use tree-widget anyway (I'm hoping
some-one else might do that - dreaming, I know).

Also if ECB/Cedet gets integrated into Emacs then, of course, we'll have to
ensure it all works together.

-- 
Nick                                           http://www.inet.net.nz/~nickrob

Re[2]: Strange behaviour after Show/Hide Speedbar in Emacs 22.1

[Eric M. Ludlam]

As far as I know, the CEDET/CVS version of speedbar is different from the
Emacs/CVS version by revision number only, and perhaps by a few small
changes that are in Emacs only.

Eric

>>> Leo <sdl.web@gmail.com> seems to think that:
>----- Juanma Barranquero (2007-06-25) wrote:-----
>
>> On 6/25/07, Angelo Graziosi <Angelo.Graziosi@roma1.infn.it> wrote:
>>
>>> It look as if the speedbar were still 'live'
>>
>> It is live, if somewhat hidden :)
>>
>> Try the following patch.
>>
>>              Juanma
>>
>>
>> P.S.: Eric, is this patch OK?
>
>Can the latest speedbar from cedet be installed in trunk?
>

-- 
          Eric Ludlam:                 zappo@gnu.org, eric@siege-engine.com
   Home: http://www.ludlam.net            Siege: www.siege-engine.com
Emacs: http://cedet.sourceforge.net               GNU: www.gnu.org

Re[2]: Strange behaviour after Show/Hide Speedbar in Emacs 22.1

[Eric M. Ludlam]

Hi,

  The speedbar frame stays "live" but hidden so that the next time
speedbar comes up, it will be faster.  You can use 'q' to hide
speedbar, and 'Q' to really kill speedbar.

  I tried it out, and it seems the speed difference is currently very
small now, so the optimization is not as important as it once was.

  I suspect your patch might leave a bunch of invisible frames about,
but it's been a while since I've been in that code so I'm not sure.

Eric

>>> "Juanma Barranquero" <lekktu@gmail.com> seems to think that:
>On 6/25/07, Angelo Graziosi <Angelo.Graziosi@roma1.infn.it> wrote:
>
>> It look as if the speedbar were still 'live'
>
>It is live, if somewhat hidden :)
>
>Try the following patch.
>
>             Juanma
>
>
>P.S.: Eric, is this patch OK?
>
>
>
>Index: lisp/speedbar.el
>===================================================================
>RCS file: /cvsroot/emacs/emacs/lisp/speedbar.el,v
>retrieving revision 1.87
>diff -u -2 -r1.87 speedbar.el
>--- lisp/speedbar.el	19 Feb 2007 13:37:23 -0000	1.87
>+++ lisp/speedbar.el	25 Jun 2007 10:24:07 -0000
>@@ -1012,6 +1012,8 @@
>     )
>   ;; Frame modifications
>-  (set (make-local-variable 'dframe-delete-frame-function)
>-       'speedbar-handle-delete-frame)
>+  (if speedbar-frame
>+      (set (make-local-variable 'dframe-delete-frame-function)
>+	   'speedbar-handle-delete-frame)
>+    (kill-local-variable 'dframe-delete-frame-function))
>   ;; hscroll
>   (set (make-local-variable 'automatic-hscrolling) nil) ; Emacs 21
>

-- 
          Eric Ludlam:                 zappo@gnu.org, eric@siege-engine.com
   Home: http://www.ludlam.net            Siege: www.siege-engine.com
Emacs: http://cedet.sourceforge.net               GNU: www.gnu.org

Re: Strange behaviour after Show/Hide Speedbar in Emacs 22.1

[Vinicius Jose Latorre]

Nick Roberts wrote:
>  > Can the latest speedbar from cedet be installed in trunk?
>
> It will surely break changes that I have made for using with GDB.
>   

It depends on which speedbar is loaded first.

If Emacs speedbar is loaded first, GDB is ok, but CEDET may have problems.

If CEDET speedbar is loaded first, CEDET is ok, but GDB will have problems.

Re: Re[2]: Strange behaviour after Show/Hide Speedbar in Emacs 22.1

[Angelo Graziosi]

On Mon, 25 Jun 2007, Eric M. Ludlam wrote:

> Hi,
> 
>   The speedbar frame stays "live" but hidden so that the next time
> speedbar comes up, it will be faster.  You can use 'q' to hide
> speedbar, and 'Q' to really kill speedbar.

This works. Using Q, Emacs can be closed with the X button of the window.

Thanks,

   Angelo.

Re[4]: Strange behaviour after Show/Hide Speedbar in Emacs 22.1

[Eric M. Ludlam]

>>> Angelo Graziosi <Angelo.Graziosi@roma1.infn.it> seems to think that:
>
>
>On Mon, 25 Jun 2007, Eric M. Ludlam wrote:
>
>> Hi,
>> 
>>   The speedbar frame stays "live" but hidden so that the next time
>> speedbar comes up, it will be faster.  You can use 'q' to hide
>> speedbar, and 'Q' to really kill speedbar.
>
>This works. Using Q, Emacs can be closed with the X button of the window.
  [ ... ]

Is there some new Emacs feature that won't close unless all frames are
closed?  If so, is there a way to mark a frame (like Speedbar's) such
that it does not participate?  Speedbar won't contain anything of
value that needs saving, and thus should not be counted in a list of
such frames.

Thanks
Eric

-- 
          Eric Ludlam:                 zappo@gnu.org, eric@siege-engine.com
   Home: http://www.ludlam.net            Siege: www.siege-engine.com
Emacs: http://cedet.sourceforge.net               GNU: www.gnu.org

Re: Re[4]: Strange behaviour after Show/Hide Speedbar in Emacs 22.1

[Juanma Barranquero]

On 6/25/07, Eric M. Ludlam <eric@siege-engine.com> wrote:

> Is there some new Emacs feature that won't close unless all frames are
> closed?

No. In the OP's bugreport, Emacs doesn't close because there's an
error executing speedbar-handle-delete-frame, where it tries to

  (delete-frame speedbar-frame)

while speedbar-frame is nil.

             Juanma

Re: Re[4]: Strange behaviour after Show/Hide Speedbar in Emacs 22.1

[Angelo Graziosi]

On Mon, 25 Jun 2007, Eric M. Ludlam wrote:

> >>> Angelo Graziosi <Angelo.Graziosi@roma1.infn.it> seems to think that:
> >
> >
> >On Mon, 25 Jun 2007, Eric M. Ludlam wrote:
> >
> >> Hi,
> >> 
> >>   The speedbar frame stays "live" but hidden so that the next time
> >> speedbar comes up, it will be faster.  You can use 'q' to hide
> >> speedbar, and 'Q' to really kill speedbar.
> >
> >This works. Using Q, Emacs can be closed with the X button of the window.
>   [ ... ]
> 
> Is there some new Emacs feature that won't close unless all frames are
> closed?  


So far I have observed that only with 'speedbar'.


   Angelo.



If so, is there a way to mark a frame (like Speedbar's) such
> that it does not participate?  Speedbar won't contain anything of
> value that needs saving, and thus should not be counted in a list of
> such frames.
> 
> Thanks
> Eric
> 
> -- 
>           Eric Ludlam:                 zappo@gnu.org, eric@siege-engine.com
>    Home: http://www.ludlam.net            Siege: www.siege-engine.com
> Emacs: http://cedet.sourceforge.net               GNU: www.gnu.org
> 

Re: Re[2]: Strange behaviour after Show/Hide Speedbar in Emacs 22.1

[Juanma Barranquero]

On 6/25/07, Eric M. Ludlam <eric@siege-engine.com> wrote:

>   I suspect your patch might leave a bunch of invisible frames about,
> but it's been a while since I've been in that code so I'm not sure.

At the very least, this patch should be committed. There's no point in
trying to delete-frame nil.

OTOH, I confess I don't entirely understand the way speedbar handles
frames. For example:

 emacs -q
 M-x speedbar-frame-mode
 "q" on the speedbar frame
 M-: (frame-list)    => the speedbar frame still exists

but

 emacs -q
 C-x 5 2
 M-x speedbar-frame-mode
 "q" on the speedbar frame
 M-: (frame-list)   => the speedbar frame does not exist

??

             Juanma


Index: lisp/speedbar.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/speedbar.el,v
retrieving revision 1.87
diff -u -2 -r1.87 speedbar.el
--- lisp/speedbar.el	19 Feb 2007 13:37:23 -0000	1.87
+++ lisp/speedbar.el	25 Jun 2007 22:39:43 -0000
@@ -1054,7 +1054,8 @@
 If the deleted frame is the frame SPEEDBAR is attached to,
 we need to delete speedbar also."
-  (let ((frame-to-be-deleted (car (car (cdr e)))))
-    (if (eq frame-to-be-deleted dframe-attached-frame)
-	(delete-frame speedbar-frame)))
+  (when speedbar-frame
+    (let ((frame-to-be-deleted (car (car (cdr e)))))
+      (if (eq frame-to-be-deleted dframe-attached-frame)
+	  (delete-frame speedbar-frame))))
   )