From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.devel Subject: Re: Redundant type checking in window.c and w32menu.c Date: Wed, 20 Jun 2007 21:46:31 +0100 Message-ID: <46799227.3070905@gnu.org> References: <4677EBCA.7020405@yandex.ru> <467935CA.9020808@yandex.ru> <467945AF.6010305@gnu.org> <46796A22.000002.16656@pantene.yandex.ru> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1182372469 2409 80.91.229.12 (20 Jun 2007 20:47:49 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 20 Jun 2007 20:47:49 +0000 (UTC) Cc: raeburn@gnu.org, emacs-devel@gnu.org To: dmantipov@yandex.ru Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 20 22:47:48 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1I175f-0002Bb-Nv for ged-emacs-devel@m.gmane.org; Wed, 20 Jun 2007 22:47:47 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1I175f-0004sB-9n for ged-emacs-devel@m.gmane.org; Wed, 20 Jun 2007 16:47:47 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1I174n-0004Zg-Br for emacs-devel@gnu.org; Wed, 20 Jun 2007 16:46:53 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1I174l-0004Yr-Qa for emacs-devel@gnu.org; Wed, 20 Jun 2007 16:46:52 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1I174l-0004Yj-Ed for emacs-devel@gnu.org; Wed, 20 Jun 2007 16:46:51 -0400 Original-Received: from outmail1.freedom2surf.net ([194.106.33.237]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1I174k-00063k-ED; Wed, 20 Jun 2007 16:46:50 -0400 Original-Received: from [127.0.0.1] (i-83-67-23-108.freedom2surf.net [83.67.23.108]) by outmail1.freedom2surf.net (Postfix) with ESMTP id 046AE5113E; Wed, 20 Jun 2007 21:46:48 +0100 (BST) User-Agent: Thunderbird 2.0.0.4 (Windows/20070604) In-Reply-To: <46796A22.000002.16656@pantene.yandex.ru> X-detected-kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:73473 Archived-At: dmantipov wrote: > Jason Rumney wrote >> Dmitry Antipov wrote: >> >> >>> +#define Fcar(c) _FCAR (c) >>> +#define Fcar_safe(c) _FCAR_SAFE (c) >>> +#define Fcdr(c) _FCDR (c) >>> +#define Fcdr_safe(c) _FCDR_SAFE (c) >>> >> How does lisp code then call these C macros? >> > > It will call original functions which are preserved in data.c. Lisp code calls them via pointers, so we definitely need to preserve an addressable versions. > Is this optimisation really worth the confusion of having two versions of these functions in the code?