From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Forward button for help buffer Date: Mon, 11 Jun 2007 08:50:44 +0200 Message-ID: <466CF0C4.2090306@gmx.at> References: <18023.13629.716910.945060@kahikatea.snap.net.nz> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------060508060401050903090305" X-Trace: sea.gmane.org 1181544803 2590 80.91.229.12 (11 Jun 2007 06:53:23 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 11 Jun 2007 06:53:23 +0000 (UTC) Cc: emacs-devel@gnu.org To: Nick Roberts Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jun 11 08:53:18 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HxdmA-0006b9-Bi for ged-emacs-devel@m.gmane.org; Mon, 11 Jun 2007 08:53:18 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hxdm9-00023R-W8 for ged-emacs-devel@m.gmane.org; Mon, 11 Jun 2007 02:53:18 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Hxdm6-00020b-Ql for emacs-devel@gnu.org; Mon, 11 Jun 2007 02:53:14 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Hxdm5-0001z1-Ro for emacs-devel@gnu.org; Mon, 11 Jun 2007 02:53:14 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hxdm5-0001yr-Oo for emacs-devel@gnu.org; Mon, 11 Jun 2007 02:53:13 -0400 Original-Received: from mail.gmx.net ([213.165.64.20]) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1Hxdm4-0002Bu-Vr for emacs-devel@gnu.org; Mon, 11 Jun 2007 02:53:13 -0400 Original-Received: (qmail invoked by alias); 11 Jun 2007 06:53:11 -0000 Original-Received: from N843P000.adsl.highway.telekom.at (EHLO [62.47.49.64]) [62.47.49.64] by mail.gmx.net (mp047) with SMTP; 11 Jun 2007 08:53:11 +0200 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/BHltjYq7Bym4jGNtNuv62/1OHTUL/E3nfW9WNAz VoQqzNv0EyQgdN User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: de-DE, de, en-us, en In-Reply-To: <18023.13629.716910.945060@kahikatea.snap.net.nz> X-Y-GMX-Trusted: 0 X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:72608 Archived-At: This is a multi-part message in MIME format. --------------060508060401050903090305 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit The forward buttons are nice, thanks. One minor nitpick: When there's only a forward-button and no back-button there's no newline before the forward-button. Please consider something like the attached patch. --------------060508060401050903090305 Content-Type: text/plain; name="help-mode.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="help-mode.patch" *** help-mode.el Sun Jun 10 17:46:38 2007 --- help-mode.el Mon Jun 11 08:44:02 2007 *************** *** 500,515 **** (while (and (not (bobp)) (bolp)) (delete-char -1)) (insert "\n") ;; Make a back-reference in this buffer if appropriate. (when help-xref-stack - (insert "\n") (help-insert-xref-button help-back-label 'help-back ! (current-buffer)) ! (insert "\t")) ;; Make a forward-reference in this buffer if appropriate. (when help-xref-forward-stack (help-insert-xref-button help-forward-label 'help-forward ! (current-buffer)) (insert "\n"))) ;; View mode steals RET from us. (set (make-local-variable 'minor-mode-overriding-map-alist) --- 500,518 ---- (while (and (not (bobp)) (bolp)) (delete-char -1)) (insert "\n") + (when (or help-xref-stack help-xref-forward-stack) + (insert "\n")) ;; Make a back-reference in this buffer if appropriate. (when help-xref-stack (help-insert-xref-button help-back-label 'help-back ! (current-buffer))) ;; Make a forward-reference in this buffer if appropriate. (when help-xref-forward-stack + (when help-xref-stack + (insert "\t")) (help-insert-xref-button help-forward-label 'help-forward ! (current-buffer))) ! (when (or help-xref-stack help-xref-forward-stack) (insert "\n"))) ;; View mode steals RET from us. (set (make-local-variable 'minor-mode-overriding-map-alist) --------------060508060401050903090305 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel --------------060508060401050903090305--