Re: [PATCH] Forward button for help buffer

From: martin rudalics <rudalics@gmx.at>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: emacs-devel@gnu.org
Subject: Re: [PATCH] Forward button for help buffer
Date: Mon, 11 Jun 2007 08:50:44 +0200	[thread overview]
Message-ID: <466CF0C4.2090306@gmx.at> (raw)
In-Reply-To: <18023.13629.716910.945060@kahikatea.snap.net.nz>

[-- Attachment #1: Type: text/plain, Size: 210 bytes --]

The forward buttons are nice, thanks.  One minor nitpick: When there's
only a forward-button and no back-button there's no newline before the
forward-button.  Please consider something like the attached patch.

[-- Attachment #2: help-mode.patch --]
[-- Type: text/plain, Size: 1568 bytes --]

*** help-mode.el	Sun Jun 10 17:46:38 2007
--- help-mode.el	Mon Jun 11 08:44:02 2007
***************
*** 500,515 ****
  	(while (and (not (bobp)) (bolp))
  	  (delete-char -1))
          (insert "\n")
          ;; Make a back-reference in this buffer if appropriate.
          (when help-xref-stack
- 	  (insert "\n")
  	  (help-insert-xref-button help-back-label 'help-back
! 				   (current-buffer))
!           (insert "\t"))
          ;; Make a forward-reference in this buffer if appropriate.
          (when help-xref-forward-stack
  	  (help-insert-xref-button help-forward-label 'help-forward
! 				   (current-buffer))
            (insert "\n")))
        ;; View mode steals RET from us.
        (set (make-local-variable 'minor-mode-overriding-map-alist)
--- 500,518 ----
  	(while (and (not (bobp)) (bolp))
  	  (delete-char -1))
          (insert "\n")
+ 	(when (or help-xref-stack help-xref-forward-stack)
+           (insert "\n"))
          ;; Make a back-reference in this buffer if appropriate.
          (when help-xref-stack
  	  (help-insert-xref-button help-back-label 'help-back
! 				   (current-buffer)))
          ;; Make a forward-reference in this buffer if appropriate.
          (when help-xref-forward-stack
+ 	  (when help-xref-stack
+ 	    (insert "\t"))
  	  (help-insert-xref-button help-forward-label 'help-forward
! 				   (current-buffer)))
! 	(when (or help-xref-stack help-xref-forward-stack)
            (insert "\n")))
        ;; View mode steals RET from us.
        (set (make-local-variable 'minor-mode-overriding-map-alist)

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel