From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.devel Subject: Re: multi-tty branch created Date: Wed, 16 May 2007 22:17:23 +0100 Message-ID: <464B74E3.3060002@gnu.org> References: <87sla0rgs4.fsf@catnip.gol.com> <85abw8pyk7.fsf@lola.goethe.zz> <85646wpuqn.fsf@lola.goethe.zz> <86sl9wpytm.fsf@lola.quinscape.zz> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1179350268 6953 80.91.229.12 (16 May 2007 21:17:48 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 16 May 2007 21:17:48 +0000 (UTC) Cc: =?UTF-8?B?S8Ohcm9seSBMxZFyZW50ZXk=?= , emacs-devel@gnu.org To: David Kastrup Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed May 16 23:17:46 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HoQsQ-0005LN-Sv for ged-emacs-devel@m.gmane.org; Wed, 16 May 2007 23:17:43 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HoR0S-0006Iq-2Z for ged-emacs-devel@m.gmane.org; Wed, 16 May 2007 17:26:00 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HoR0O-0006Ia-7B for emacs-devel@gnu.org; Wed, 16 May 2007 17:25:56 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HoR0L-0006IO-Sq for emacs-devel@gnu.org; Wed, 16 May 2007 17:25:54 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HoR0L-0006IL-N5 for emacs-devel@gnu.org; Wed, 16 May 2007 17:25:53 -0400 Original-Received: from outmail1.freedom2surf.net ([194.106.33.237]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1HoQsI-0000x3-Od; Wed, 16 May 2007 17:17:35 -0400 Original-Received: from [127.0.0.1] (i-83-67-23-108.freedom2surf.net [83.67.23.108]) by outmail1.freedom2surf.net (Postfix) with ESMTP id EB58950332; Wed, 16 May 2007 22:17:28 +0100 (BST) User-Agent: Thunderbird 2.0.0.0 (Windows/20070326) In-Reply-To: <86sl9wpytm.fsf@lola.quinscape.zz> X-detected-kernel: Linux 2.4-2.6 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:71194 Archived-At: David Kastrup wrote: > Actually, at the moment emacsclient does not compile which _is_ a regression. And such regressions will > _certainly_ occur until we get this to compile on all platforms. > That was my fault. A variable was moved from main() to global scope in the multi-tty branch, which broke the Windows build for reasons I did not understand. But I could not find any real use of that variable outside main() so I tried moving it back. It turned out that the use of that global variable was hidden inside a macro in code that is conditionally compiled only when there are file system sockets (ie, not Windows) so I missed it. I have now renamed it to avoid confusion with the many other local variables of the same name that shadow it, and fixed the original bug by moving its definition below the header file it depends on.