all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Jason Rumney <jasonr@gnu.org>
To: David Kastrup <dak@gnu.org>
Cc: "Károly Lőrentey" <karoly@lorentey.hu>, emacs-devel@gnu.org
Subject: Re: multi-tty branch created
Date: Wed, 16 May 2007 22:17:23 +0100	[thread overview]
Message-ID: <464B74E3.3060002@gnu.org> (raw)
In-Reply-To: <86sl9wpytm.fsf@lola.quinscape.zz>

David Kastrup wrote:
> Actually, at the moment emacsclient does not compile which _is_ a regression.  And such regressions will
> _certainly_ occur until we get this to compile on all platforms.
>   

That was my fault. A variable was moved from main() to global scope in 
the multi-tty branch, which broke the Windows build for reasons I did 
not understand. But I could not find any real use of that variable 
outside main() so I tried moving it back. It turned out that the use of 
that global variable was hidden inside a macro in code that is 
conditionally compiled only when there are file system sockets (ie, not 
Windows) so I missed it.

I have now renamed it to avoid confusion with the many other local 
variables of the same name that shadow it, and fixed the original bug by 
moving its definition below the header file it depends on.

  parent reply	other threads:[~2007-05-16 21:17 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-13 13:31 multi-tty branch created Miles Bader
2007-05-13 14:50 ` David Kastrup
2007-05-13 16:12   ` Miles Bader
2007-05-13 16:14     ` David Kastrup
2007-05-13 16:13   ` David Kastrup
2007-05-13 19:28     ` Robert J. Chassell
2007-05-16 13:24     ` Károly Lo"rentey
2007-05-16 13:46       ` Juanma Barranquero
2007-05-16 15:04         ` Károly Lőrentey
2007-05-16 15:34           ` David Kastrup
2007-05-16 16:11             ` Károly Lőrentey
2007-05-16 21:17             ` Jason Rumney [this message]
2007-05-16 16:20         ` Dan Nicolaescu
2007-05-16 17:39       ` David Kastrup
2007-05-16 20:48         ` Károly Lőrentey
2007-05-17 14:02       ` Stefan Monnier
2007-05-17 16:04         ` Károly Lo"rentey
2007-05-17 23:24           ` Stefan Monnier
2007-05-18 18:02             ` Károly Lo"rentey
2007-05-19 14:07               ` Stefan Monnier
2007-05-13 20:07 ` Jason Rumney
2007-05-14 10:21   ` Karoly Lorentey
2007-05-14 11:55     ` Jason Rumney
2007-05-15 13:03       ` Karoly Lorentey
2007-05-15 22:05     ` Ken Raeburn
2007-05-14  6:00 ` Manoj Srivastava

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=464B74E3.3060002@gnu.org \
    --to=jasonr@gnu.org \
    --cc=dak@gnu.org \
    --cc=emacs-devel@gnu.org \
    --cc=karoly@lorentey.hu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.