bug#1236: ispell-complete-word / key binding not shown in menu

bug#1236: ispell-complete-word / key binding not shown in menu

[David Reitter]

[-- Attachment #1: Type: text/plain, Size: 1039 bytes --]

`ispell-complete-word' appears in the Spell Checking menu and is, in  
text-mode at least, bound to M-TAB, as C-h f/k will show.  However, it  
does not have its key binding listed in the menu.

Listing the correct key bindings in the menus is important - it's  
pretty difficult for newbies to learn these things otherwise.

This occurs with the old Carbon port (22) and with a recent build of  
Cocoa (23).


Begin forwarded message:

> From: dranorter <dranorter@gmail.com>
> Date: 12 August 2008 10:19:33 EDT
> To: aquamacs-bugs@aquamacs.org
> Subject: Re: [Aquamacs-bugs] Random aquamacs impressions
>
>
>>> - Some of the menus don't have keyboard shortcuts listed.
>> Is that because the associated functions have no key bindings, or are
>> the shortcut indicators genuinely missing? (Either is possible.)
>
> I was thinking of edit > complete word, which doesn't have a
> key binding. It would have been helpful to me at the time to
> still have M-x ispell-complete-word listed but of course there
> wouldn't be room, so whatever.


[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 2193 bytes --]

bug#1236: ispell-complete-word / key binding not shown in menu

[Glenn Morris]

reassign 1236 emacs,ns
stop

David Reitter wrote:

> `ispell-complete-word' appears in the Spell Checking menu and is, in  
> text-mode at least, bound to M-TAB, as C-h f/k will show.  However, it  
> does not have its key binding listed in the menu.

Works fine in GNU/Linux:

emacs -Q
M-x text-mode
Tools -> Spell Checking
  -> "Complete Word" has M-TAB binding displayed

M-x lisp-mode
  -> "Complete Word" has no keybinding, none displayed


> Listing the correct key bindings in the menus is important - it's  
> pretty difficult for newbies to learn these things otherwise.

Hopefully they learn about C-h k.

Processed: Re: bug#1236: ispell-complete-word / key binding not shown in menu

[Emacs bug Tracking System]

Processing commands for control@emacsbugs.donarmstrong.com:

> reassign 1236 emacs,ns
bug#1236: ispell-complete-word / key binding not shown in menu
Warning: Unknown package 'ns'
bug reassigned from package `emacs' to `emacs,ns'.

> stop
Stopping processing here.

Please contact me if you need assistance.

Don Armstrong
(administrator, Emacs bugs database)

bug#1236: ispell-complete-word / key binding not shown in menu

[YAMAMOTO Mitsuharu]

>>>>> On Fri, 24 Oct 2008 00:18:05 -0400, Glenn Morris <rgm@gnu.org> said:

>> `ispell-complete-word' appears in the Spell Checking menu and is, in  
>> text-mode at least, bound to M-TAB, as C-h f/k will show.  However, it  
>> does not have its key binding listed in the menu.

> Works fine in GNU/Linux:

> emacs -Q
> M-x text-mode
> Tools -> Spell Checking
> -> "Complete Word" has M-TAB binding displayed

> M-x lisp-mode
> -> "Complete Word" has no keybinding, none displayed

Probably you tried with Emacs 23, and Emacs 22 on GNU/Linux would
behave as OP described.  I think the following change made the
difference.

2008-05-16  Stefan Monnier  <monnier@iro.umontreal.ca>

	* keyboard.c (parse_menu_item): Do not cache key shortcut any more.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

bug#1236: ispell-complete-word / key binding not shown in menu

[Glenn Morris]

YAMAMOTO Mitsuharu wrote:

> Probably you tried with Emacs 23, and Emacs 22 on GNU/Linux would
> behave as OP described.

I did indeed, since Emacs 22 is dead, and the problem was also said to
occur with "a recent build of Cocoa (23)". Does it? (I can't build that.)

bug#1236: ispell-complete-word / key binding not shown in menu

[David Reitter]

[-- Attachment #1: Type: text/plain, Size: 764 bytes --]

On 25 Oct 2008, at 14:45, Glenn Morris wrote:

> YAMAMOTO Mitsuharu wrote:
>
>> Probably you tried with Emacs 23, and Emacs 22 on GNU/Linux would
>> behave as OP described.
>
> I did indeed, since Emacs 22 is dead, and the problem was also said to
> occur with "a recent build of Cocoa (23)". Does it? (I can't build  
> that.)

In general: given that there are tens if not hundreds of thousands of  
users out there on Emacs 22, with stopping to fix bugs we're not doing  
ourselves a favor.

Applying Stefan's patch (which just turns off this cache) causes a  
crash while building (before dumping), which I don't have the chance  
to investigate further.

Indeed, the key hint problem occurred with 23 as well, so perhaps we  
should fix it on that end first.


[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 2193 bytes --]

bug#1236: ispell-complete-word / key binding not shown in menu

[YAMAMOTO Mitsuharu]

>>>>> On Sat, 25 Oct 2008 14:45:52 -0400, Glenn Morris <rgm@gnu.org> said:

>> Probably you tried with Emacs 23, and Emacs 22 on GNU/Linux would
>> behave as OP described.

> I did indeed, since Emacs 22 is dead, and the problem was also said
> to occur with "a recent build of Cocoa (23)". Does it? (I can't
> build that.)

Menus in the Cocoa/GNUstep port doesn't show key bindings as in other
platforms (at least by default) in the first place.

				     YAMAMOTO Mitsuharu
				mituharu@math.s.chiba-u.ac.jp

bug#1236: ispell-complete-word / key binding not shown in menu

[David Reitter]

[-- Attachment #1: Type: text/plain, Size: 889 bytes --]

On 26 Oct 2008, at 00:18, YAMAMOTO Mitsuharu wrote:

>>>>>> On Sat, 25 Oct 2008 14:45:52 -0400, Glenn Morris <rgm@gnu.org>  
>>>>>> said:
>
>>> Probably you tried with Emacs 23, and Emacs 22 on GNU/Linux would
>>> behave as OP described.
>
>> I did indeed, since Emacs 22 is dead, and the problem was also said
>> to occur with "a recent build of Cocoa (23)". Does it? (I can't
>> build that.)
>
> Menus in the Cocoa/GNUstep port doesn't show key bindings as in other
> platforms (at least by default) in the first place.


Using the 23 code that turns off caching of key binding hints does fix  
the problem in 22 Carbon Emacs.

23 Cocoa has a different problem with key bindings.  No key binding is  
displayed here:

(defun foo () (interactive))
(global-set-key "\M-p" 'foo)
(define-key menu-bar-file-menu [new-file]
   '(menu-item "Foo!"
	      foo))
(ns-reset-menu) ;; doesn't help



[-- Attachment #2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 2193 bytes --]

bug#1236: marked as done (ispell-complete-word / key binding not shown in menu)

[Emacs bug Tracking System]

[-- Attachment #1: Type: text/plain, Size: 910 bytes --]


Your message dated Thu, 22 Jan 2009 14:26:27 +0200
with message-id <A1DC42C3-CD46-4333-87FA-7B7F59794F14@gmail.com>
and subject line Re: ispell-complete-word / key binding not shown in menu
has caused the Emacs bug report #1236,
regarding ispell-complete-word / key binding not shown in menu
to be marked as done.

This means that you claim that the problem has been dealt with.
If this is not the case it is now your responsibility to reopen the
bug report if necessary, and/or fix the problem forthwith.

(NB: If you are a system administrator and have no idea what this
message is talking about, this may indicate a serious mail system
misconfiguration somewhere. Please contact owner@emacsbugs.donarmstrong.com
immediately.)


-- 
1236: http://emacsbugs.donarmstrong.com/cgi-bin/bugreport.cgi?bug=1236
Emacs Bug Tracking System
Contact owner@emacsbugs.donarmstrong.com with problems

[-- Attachment #2: Type: message/rfc822, Size: 7521 bytes --]

[-- Attachment #2.1.1: Type: text/plain, Size: 1039 bytes --]

`ispell-complete-word' appears in the Spell Checking menu and is, in  
text-mode at least, bound to M-TAB, as C-h f/k will show.  However, it  
does not have its key binding listed in the menu.

Listing the correct key bindings in the menus is important - it's  
pretty difficult for newbies to learn these things otherwise.

This occurs with the old Carbon port (22) and with a recent build of  
Cocoa (23).


Begin forwarded message:

> From: dranorter <dranorter@gmail.com>
> Date: 12 August 2008 10:19:33 EDT
> To: aquamacs-bugs@aquamacs.org
> Subject: Re: [Aquamacs-bugs] Random aquamacs impressions
>
>
>>> - Some of the menus don't have keyboard shortcuts listed.
>> Is that because the associated functions have no key bindings, or are
>> the shortcut indicators genuinely missing? (Either is possible.)
>
> I was thinking of edit > complete word, which doesn't have a
> key binding. It would have been helpful to me at the time to
> still have M-x ispell-complete-word listed but of course there
> wouldn't be room, so whatever.


[-- Attachment #2.1.2: smime.p7s --]
[-- Type: application/pkcs7-signature, Size: 2193 bytes --]

[-- Attachment #3: Type: message/rfc822, Size: 2854 bytes --]

From: Adrian Robert <adrian.b.robert@gmail.com>
To: 1236-done@emacsbugs.donarmstrong.com
Subject: Re: ispell-complete-word / key binding not shown in menu
Date: Thu, 22 Jan 2009 14:26:27 +0200
Message-ID: <A1DC42C3-CD46-4333-87FA-7B7F59794F14@gmail.com>

Fixed 2009/01/22 with changes to nsmenu.m: EmacsMenu.  Non-super  
keybindings are displayed as strings appended in parentheses, as in  
"Visit New File... (C-x C-f)".  This is ugly, however it seems that  
NSMenuItem will not accept multi-character strings for  
keyEquivalent.  If anyone can improve upon / work around this  
situation please go ahead.