From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Paul Eggert Newsgroups: gmane.emacs.devel Subject: Re: [PATCH] Enable customisation for electric-quote-mode chars Date: Sun, 28 Aug 2016 18:55:06 -0700 Organization: UCLA Computer Science Department Message-ID: <45fb742d-0121-3588-e87d-3a80c9d1d056@cs.ucla.edu> References: <87twe57lmn.fsf@xi.bootis> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------54E1D8317424B2F7DAD38865" X-Trace: blaine.gmane.org 1472435733 23896 195.159.176.226 (29 Aug 2016 01:55:33 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Mon, 29 Aug 2016 01:55:33 +0000 (UTC) User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 Cc: eliz@gnu.org, emacs-devel@gnu.org To: =?UTF-8?Q?G=c3=b6ktu=c4=9f_Kayaalp?= Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Aug 29 03:55:28 2016 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1beBnM-0005fP-3P for ged-emacs-devel@m.gmane.org; Mon, 29 Aug 2016 03:55:28 +0200 Original-Received: from localhost ([::1]:41471 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1beBnJ-0006rz-Gk for ged-emacs-devel@m.gmane.org; Sun, 28 Aug 2016 21:55:25 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:48952) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1beBnB-0006rt-EW for emacs-devel@gnu.org; Sun, 28 Aug 2016 21:55:18 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1beBnA-0003Qt-De for emacs-devel@gnu.org; Sun, 28 Aug 2016 21:55:17 -0400 Original-Received: from zimbra.cs.ucla.edu ([131.179.128.68]:58131) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1beBn3-0003P1-M9; Sun, 28 Aug 2016 21:55:09 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 13254160EF1; Sun, 28 Aug 2016 18:55:08 -0700 (PDT) Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id b2dFOYEDdmNa; Sun, 28 Aug 2016 18:55:07 -0700 (PDT) Original-Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 2DCB216066C; Sun, 28 Aug 2016 18:55:07 -0700 (PDT) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Original-Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id WYk-zcdPUG8x; Sun, 28 Aug 2016 18:55:07 -0700 (PDT) Original-Received: from [192.168.1.9] (unknown [100.32.155.148]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 0CB511601CD; Sun, 28 Aug 2016 18:55:07 -0700 (PDT) In-Reply-To: <87twe57lmn.fsf@xi.bootis> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 131.179.128.68 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:206852 Archived-At: This is a multi-part message in MIME format. --------------54E1D8317424B2F7DAD38865 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable G=C3=B6ktu=C4=9F Kayaalp wrote: > I guess the build system should require a certain > minimum version for the texinfo compiler It's a bit tricky as we don't want to require texinfo for ordinary instal= ls.=20 Probably worth documenting for Git builds, though. I added the attached. > the default texinfo 4.8 on my FreeBSD 10.3, 4.8 is pretty old; I don't think we want to bother with porting to it. > (all okay when I installed 6.1 from ports) Yes, that's the way to go. As for the patch itself: * Part of the code still assumes English-style single quoting, and won't = work if=20 electric-quote-chars is set appropriately for (say) French. Look for inst= ances=20 of the two characters =E2=80=98 and =E2=80=99 in the string constants. Mo= re generally, I'd look=20 for any non-ASCII character in that file. * The documentation should say "curved" rather than "curvy" for consisten= cy with=20 what's there now. * The documentation is a bit sloppy about which quotes are used for what,= e.g.,=20 "the first two are used for left single quotes" is not correct and the do= c=20 string is a bit hard to follow. For the documentation I suggest specifyin= g the=20 default value in the manual, as that should make it easier to explain the= format=20 of the variable. * Perhaps use pcase instead of 4 calls to nth? It'd make the code easier = to read. * Finally, it's a nontrivial patch so I assume you're OK with assigning=20 copyright to the FSF? If so, I can start the ball rolling on the paperwor= k for you. Thanks again. --------------54E1D8317424B2F7DAD38865 Content-Type: text/x-diff; name="0001-INSTALL.REPO-Suggest-Texinfo-4.13-or-later.patch" Content-Transfer-Encoding: quoted-printable Content-Disposition: attachment; filename="0001-INSTALL.REPO-Suggest-Texinfo-4.13-or-later.patch" =46rom 90f4f206f2d687cb98e13810fe39f82a6bcd4937 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sun, 28 Aug 2016 18:23:25 -0700 Subject: [PATCH] * INSTALL.REPO: Suggest Texinfo 4.13 or later. --- INSTALL.REPO | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/INSTALL.REPO b/INSTALL.REPO index 7497f1f..6fc9857 100644 --- a/INSTALL.REPO +++ b/INSTALL.REPO @@ -15,7 +15,7 @@ automake - at least the version specified near the sta= rt of git - at least Git 1.7.1. If your repository was created by an older Git version, you may need to reclone it. makeinfo - not strictly necessary, but highly recommended, so that - you can build the manuals. + you can build the manuals. GNU Texinfo 4.13 or later should work. =20 To use the autotools, run the following shell command to generate the 'configure' script and some related files, and to set up your git --=20 2.7.4 --------------54E1D8317424B2F7DAD38865--