Re: [PATCH] Enable customisation for electric-quote-mode chars

[Paul Eggert <eggert@cs.ucla.edu>]

[-- Attachment #1: Type: text/plain, Size: 1513 bytes --]

Göktuğ Kayaalp wrote:

> I guess the build system should require a certain
> minimum version for the texinfo compiler

It's a bit tricky as we don't want to require texinfo for ordinary installs. 
Probably worth documenting for Git builds, though. I added the attached.

> the default texinfo 4.8 on my FreeBSD 10.3,

4.8 is pretty old; I don't think we want to bother with porting to it.

> (all okay when I installed 6.1 from ports)

Yes, that's the way to go.

As for the patch itself:

* Part of the code still assumes English-style single quoting, and won't work if 
electric-quote-chars is set appropriately for (say) French. Look for instances 
of the two characters ‘ and ’ in the string constants. More generally, I'd look 
for any non-ASCII character in that file.

* The documentation should say "curved" rather than "curvy" for consistency with 
what's there now.

* The documentation is a bit sloppy about which quotes are used for what, e.g., 
"the first two are used for left single quotes" is not correct and the doc 
string is a bit hard to follow. For the documentation I suggest specifying the 
default value in the manual, as that should make it easier to explain the format 
of the variable.

* Perhaps use pcase instead of 4 calls to nth? It'd make the code easier to read.

* Finally, it's a nontrivial patch so I assume you're OK with assigning 
copyright to the FSF? If so, I can start the ball rolling on the paperwork for you.

Thanks again.

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-INSTALL.REPO-Suggest-Texinfo-4.13-or-later.patch --]
[-- Type: text/x-diff; name="0001-INSTALL.REPO-Suggest-Texinfo-4.13-or-later.patch", Size: 934 bytes --]

From 90f4f206f2d687cb98e13810fe39f82a6bcd4937 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Sun, 28 Aug 2016 18:23:25 -0700
Subject: [PATCH] * INSTALL.REPO: Suggest Texinfo 4.13 or later.

---
 INSTALL.REPO | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/INSTALL.REPO b/INSTALL.REPO
index 7497f1f..6fc9857 100644
--- a/INSTALL.REPO
+++ b/INSTALL.REPO
@@ -15,7 +15,7 @@ automake  - at least the version specified near the start of
 git - at least Git 1.7.1.  If your repository was created by an older
   Git version, you may need to reclone it.
 makeinfo  - not strictly necessary, but highly recommended, so that
-  you can build the manuals.
+  you can build the manuals.  GNU Texinfo 4.13 or later should work.
 
 To use the autotools, run the following shell command to generate the
 'configure' script and some related files, and to set up your git
-- 
2.7.4