From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: "Sheng Yang" Newsgroups: gmane.emacs.bugs Subject: bug#44206: 28.0.50; SVG image fail to show Date: Sun, 25 Oct 2020 12:17:16 -0500 Message-ID: <45cc75c5-080f-4b93-84c4-95cc459e7821@www.fastmail.com> References: <87o8krkmwg.fsf@gmail.com> <20201025160105.GE59267@breton.holly.idiocy.org> Mime-Version: 1.0 Content-Type: multipart/alternative; boundary=a7fa121f550e42ea8715f88fb52503b1 Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="26883"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Cyrus-JMAP/3.3.0-529-g69105b1-fm-20201021.003-g69105b13 Cc: 44206@debbugs.gnu.org To: "Alan Third" Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 25 18:18:12 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kWjek-0006re-Ts for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 25 Oct 2020 18:18:11 +0100 Original-Received: from localhost ([::1]:60064 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kWjej-0005Ol-Sz for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 25 Oct 2020 13:18:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38998) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kWjec-0005OP-43 for bug-gnu-emacs@gnu.org; Sun, 25 Oct 2020 13:18:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54242) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kWjeb-0007tI-Py for bug-gnu-emacs@gnu.org; Sun, 25 Oct 2020 13:18:01 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kWjeb-0007et-LU for bug-gnu-emacs@gnu.org; Sun, 25 Oct 2020 13:18:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: "Sheng Yang" Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 25 Oct 2020 17:18:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44206 X-GNU-PR-Package: emacs Original-Received: via spool by 44206-submit@debbugs.gnu.org id=B44206.160364626729419 (code B ref 44206); Sun, 25 Oct 2020 17:18:01 +0000 Original-Received: (at 44206) by debbugs.gnu.org; 25 Oct 2020 17:17:47 +0000 Original-Received: from localhost ([127.0.0.1]:37555 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWjeM-0007eR-Ll for submit@debbugs.gnu.org; Sun, 25 Oct 2020 13:17:46 -0400 Original-Received: from out3-smtp.messagingengine.com ([66.111.4.27]:52097) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWjeK-0007eD-1y for 44206@debbugs.gnu.org; Sun, 25 Oct 2020 13:17:44 -0400 Original-Received: from compute6.internal (compute6.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id A38595C00A1; Sun, 25 Oct 2020 13:17:38 -0400 (EDT) Original-Received: from imap2 ([10.202.2.52]) by compute6.internal (MEProxy); Sun, 25 Oct 2020 13:17:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fastmail.com; h= mime-version:message-id:in-reply-to:references:date:from:to:cc :subject:content-type; s=fm1; bh=XK4mhhbSrP/eR65ZiGHZ10leY/T06ry kDldBmOTi/d0=; b=R6XpdfiOLIDZDSs84JfPtRw00ZQ0T+gYu0RrCHlz1OJKhUT P9Vc5m0Nnz5BISlgjNVd7Zf9ptII1uoGBcjUF0DP06kwz3m9tTQl5htU6N9SH+4U 8POpeCVyzjAE/f3UxgUqHZsiysj4SLsWjQmWJnH/4l/32D+sjPUqqlLkLH2y0O1j glGbSzeAJGWuvt+27ZOqmnyQZ+stHhx4QmjuomQP/CBFsObbSiS1Arjdd1qUYyHy 7Wqo1eQ2Q3Jbd1NFBJtESO3b7HJqh4baar5odgm9u6oHcXEHJaEMkPQpn6ejnCri wip61E11neinQBabhxhPcjiPsqk/d1fZeEhdNDw== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=XK4mhh bSrP/eR65ZiGHZ10leY/T06rykDldBmOTi/d0=; b=QyAG8nwiyxwcveZ8mehGzU J4SmubFaCUsho1JQHEmbksHsR8ayFvcM9zSl4P8dctdLlsFzIcDlQ94YZPsiNdBE 3ZNoBhCzud+cf3eDqmxO6h8JYbEE0xC3djWXLjl/EuBHc8jrgJSHHyOSnKGto7ZJ +wEPZhoyCOEpq2v2Fw77706FVXgIIsNigzm6JyQh2KM80spNuUe48I5XAbncPMKY 3GDWMSW369TmG4tsoDm+dW2ik3HavhGisluig3MrGDhs2AlTIe06TpiJlUIzp6gq bi6p10ECAu+cxZLRMEyAMUwL0EmrEE58rc6kNk1nURKXxG/hJoNt1gvxOSinpuGw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrkeeggddutddtucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepofgfggfkjghffffhvffutgesrgdtreerreerjeenucfhrhhomhepfdfuhhgv nhhgucgjrghnghdfuceoshhthigrnhhgsehfrghsthhmrghilhdrtghomheqnecuggftrf grthhtvghrnhepheeluedtudffffegffeileettedvudeihefhvefgvdeivddttdeifeei geegveejnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh epshhthigrnhhgsehfrghsthhmrghilhdrtghomh X-ME-Proxy: Original-Received: by mailuser.nyi.internal (Postfix, from userid 501) id 07C33E050A; Sun, 25 Oct 2020 13:17:36 -0400 (EDT) X-Mailer: MessagingEngine.com Webmail Interface In-Reply-To: <20201025160105.GE59267@breton.holly.idiocy.org> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:191522 Archived-At: --a7fa121f550e42ea8715f88fb52503b1 Content-Type: text/plain;charset=utf-8 Content-Transfer-Encoding: quoted-printable Thanks for your effort! Patch works for me, librsvg 2.50 on Archlinux.=20= On Sun, Oct 25, 2020, at 11:01, Alan Third wrote: > Anyway, I've thrown in another attempt at calculating the image size, > and it works for this and also for the previous images. This one is > more complex because it's trying to convert CSS sizes to pixel sizes > and I don't think we can be entirely sure of some of them (like ex > height? Maybe we can query that, but then we have to know font and > font size). >=20 > I have no doubt that there are many more SVG files out there that > won't display properly even with this patch. I checked places where I use SVG files, especially telega, everything I = checked looks good to me now. Hope there are not too many corner cases.=20= > librsvg is really not helping here. The documentation makes it pretty > clear that they don't want us to be querying the SVG dimensions and > would prefer us to just give them the dimensions we want and/or to use= > Cairo. So could the future of SVG in Emacs lie in Cairo? Forgive me if I am ask= ing a dumb question. > > Affected librsvg version: 2:2.50.1-1 in Archlinux, and 2.44.10-2.1 i= n Debian. >=20 > I'm concerned that librsvg 2.44 is affected as it should be using the > same code path as before the commit in question. My fault, librsvg 2.44 on Debian is NOT affect by this. (I guess I was h= aving internet issue with my vps running debian. Last time I waited for = a few seconds and the image was not showing up. I waited a bit longer th= is time.) Sheng Yang(=E6=9D=A8=E5=9C=A3), PhD candidate Computer Science Department University of Maryland, College Park E-mail: styang@fastmail.com E-mail (old but still used): yangsheng6810@gmail.com --a7fa121f550e42ea8715f88fb52503b1 Content-Type: text/html;charset=utf-8 Content-Transfer-Encoding: quoted-printable
Thanks for your= effort! Patch works for me, librsvg 2.50 on Archlinux.
<= br>
On Sun, Oct 25, 2020, at 11:01, Alan Third wrote:
Anyway, I've thrown= in another attempt at calculating the image size,
and it = works for this and also for the previous images. This one is
more complex because it's trying to convert CSS sizes to pixel sizes<= br>
and I don't think we can be entirely sure of some of them = (like ex
height? Maybe we can query that, but then we have= to know font and
font size).

I have no doubt that there are many more SVG files out there that
won't display properly even with this patch.

I checked places where I use SVG files, especial= ly telega, everything I checked looks good to me now. Hope there are not= too many corner cases.

librsvg is really not helping here. The documentation makes it p= retty
clear that they don't want us to be querying the SVG= dimensions and
would prefer us to just give them the dime= nsions we want and/or to use
Cairo.
=

So could the future of SVG in Emacs lie in Cairo? Fo= rgive me if I am asking a dumb question.

> Affected librsvg versi= on: 2:2.50.1-1 in Archlinux, and 2.44.10-2.1 in Debian.
I'm concerned that librsvg 2.44 is affected as it should be= using the
same code path as before the commit in question= .

My fault, librsvg 2.44 on De= bian is NOT affect by this. (I guess I was having internet issue with my= vps running debian. Last time I waited for a few seconds and the image = was not showing up. I waited a bit longer this time.)

=

Sheng Yang(=E6=9D=A8=E5= =9C=A3), PhD candidate
Computer Science Department
University of Maryland, College Park
E= -mail (old but still used): y= angsheng6810@gmail.com


= --a7fa121f550e42ea8715f88fb52503b1--