all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: martin rudalics <rudalics@gmx.at>
To: rms@gnu.org
Cc: emacs-devel@gnu.org
Subject: Re: Info-insert-dir
Date: Tue, 20 Mar 2007 10:56:55 +0100	[thread overview]
Message-ID: <45FFAFE7.2010702@gmx.at> (raw)
In-Reply-To: <E1HTPqw-00025X-7I@fencepost.gnu.org>

 >     Probably.  It's a customizable variable and `wid-edit' doesn't even
 >     check if the user puts valid directory names in there.
 >
 > It shouldn't check that.  We do not try to stop users from putting
 > nonexistent directory names into Lisp variables.

I meant `wid-edit' doesn't even check whether it's a "directory name" in
the sense of a filename ending with a slash (`wid-edit' doesn't
discriminate directories and files although it provides separate widgets
for them).

 > It would be incorrect to change call-process to change the default
 > directory on its own.  Often the execution of a command depends on the
 > current directory, so that if the current directory is nonexistent, an
 > error is the right thing.

Agreed.

 > We could make a subroutine which does this and calls call-process.

What about `call-process-region', `start-process', `shell-command'?

Maybe we could introduce a macro like

(defmacro with-valid-default-directory (&rest body)
   "Run BODY with `default-directory' bound to an existing directory."
   (declare (indent 0) (debug t))
   `(let ((default-directory
	   (if (and (stringp default-directory)
		    (file-directory-p default-directory))
	       default-directory
	     (expand-file-name "~/"))))
      ,@body))

  reply	other threads:[~2007-03-20  9:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-16 19:44 Info-insert-dir martin rudalics
     [not found] ` <E1HSuLw-0005So-CU@fencepost.gnu.org>
     [not found]   ` <45FD35C4.7060207@gmx.at>
2007-03-19  5:15     ` Info-insert-dir Richard Stallman
2007-03-19  9:50       ` Info-insert-dir martin rudalics
2007-03-19 21:57         ` Info-insert-dir Richard Stallman
2007-03-20  9:56           ` martin rudalics [this message]
2007-03-21  0:42             ` Info-insert-dir Richard Stallman
2007-03-21  0:42             ` Info-insert-dir Richard Stallman
2007-03-21  7:38               ` Info-insert-dir martin rudalics
2007-03-22  5:01                 ` Info-insert-dir Richard Stallman
2007-03-22  7:19                   ` Info-insert-dir martin rudalics
2007-03-22 22:50                     ` Info-insert-dir Richard Stallman
2007-03-23  9:01                       ` Info-insert-dir martin rudalics
2007-03-23 18:00                         ` Info-insert-dir Richard Stallman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=45FFAFE7.2010702@gmx.at \
    --to=rudalics@gmx.at \
    --cc=emacs-devel@gnu.org \
    --cc=rms@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.