From: martin rudalics <rudalics@gmx.at>
To: rms@gnu.org
Cc: emacs-devel@gnu.org
Subject: Re: Info-insert-dir
Date: Mon, 19 Mar 2007 10:50:21 +0100 [thread overview]
Message-ID: <45FE5CDD.3010909@gmx.at> (raw)
In-Reply-To: <E1HTADB-0003Uw-9R@fencepost.gnu.org>
> This nonexistent directory came from `Info-additional-directory-list',
> right? So I think that if this is a bug, the bug would be at the
> earlier stage, where the value of `Info-additional-directory-list' was
> set up. Do you disagree?
Probably. It's a customizable variable and `wid-edit' doesn't even
check if the user puts valid directory names in there. Also, whether a
directory exists at the time of calling `call-process' may depend on a
number of factors - whether the directory is remote, a drive is
mounted... I think it would be better if `Info-insert-dir' refrained
from using an obscure source such as `Info-additional-directory-list' to
set the default directory of its buffer.
> More disconcerting,
> however, is that any part of Emacs that relies on a valid, existing
> default directory won't work reliably.
>
> You can set `default-directory' to any string, so Emacs facilities
> should not assume it is an existing directory unless it part of
> their definition to need that.
>
> Therefore, those other features such as spell checking should be
> changed not to depend on this. As far as I know, ispell and aspell
> have no need to use the default directory. Indeed one call-process
> call in ispell.el already handles the case of nonexistent default
> directory.
You mean the
(unless (file-exists-p default-directory)
(setq default-directory (expand-file-name "~/")))
AFAICT this is the only occurrence of such a test in the entire Emacs
sources. It might fail if default-directory equals the name of an
existing non-directory file - an unlikely case, though.
> Does this patch make it work?
I'm not sure. Before I already wrapped every occurrence of these in a
(let ((default-directory
(if (file-directory-p default-directory) default-directory "~/")))
including the `start-process' instance in ispell.el and it worked (BTW
`flyspell' has another instance of `call-process-region'). But isn't it
a bit tedious to search for all occurrences of `call-process' etc?
Couldn't such a check make it to `call-process', `start-process' ...
next prev parent reply other threads:[~2007-03-19 9:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-16 19:44 Info-insert-dir martin rudalics
[not found] ` <E1HSuLw-0005So-CU@fencepost.gnu.org>
[not found] ` <45FD35C4.7060207@gmx.at>
2007-03-19 5:15 ` Info-insert-dir Richard Stallman
2007-03-19 9:50 ` martin rudalics [this message]
2007-03-19 21:57 ` Info-insert-dir Richard Stallman
2007-03-20 9:56 ` Info-insert-dir martin rudalics
2007-03-21 0:42 ` Info-insert-dir Richard Stallman
2007-03-21 0:42 ` Info-insert-dir Richard Stallman
2007-03-21 7:38 ` Info-insert-dir martin rudalics
2007-03-22 5:01 ` Info-insert-dir Richard Stallman
2007-03-22 7:19 ` Info-insert-dir martin rudalics
2007-03-22 22:50 ` Info-insert-dir Richard Stallman
2007-03-23 9:01 ` Info-insert-dir martin rudalics
2007-03-23 18:00 ` Info-insert-dir Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45FE5CDD.3010909@gmx.at \
--to=rudalics@gmx.at \
--cc=emacs-devel@gnu.org \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.