From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: martin rudalics Newsgroups: gmane.emacs.devel Subject: save-buffer when directory doesn't exist Date: Sat, 10 Mar 2007 10:43:56 +0100 Message-ID: <45F27DDC.9080006@gmx.at> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------050709040509060702030604" X-Trace: sea.gmane.org 1173520144 18387 80.91.229.12 (10 Mar 2007 09:49:04 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 10 Mar 2007 09:49:04 +0000 (UTC) To: emacs-devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sat Mar 10 10:49:01 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HPyCA-0002Mj-Bb for ged-emacs-devel@m.gmane.org; Sat, 10 Mar 2007 10:49:01 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HPyCR-0000Y1-Gq for ged-emacs-devel@m.gmane.org; Sat, 10 Mar 2007 04:49:15 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HPyBn-0000IL-5L for emacs-devel@gnu.org; Sat, 10 Mar 2007 04:48:35 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HPyBf-00007q-0j for emacs-devel@gnu.org; Sat, 10 Mar 2007 04:48:34 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HPyBe-00007e-Rv for emacs-devel@gnu.org; Sat, 10 Mar 2007 04:48:26 -0500 Original-Received: from mail.gmx.net ([213.165.64.20]) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1HPyBA-00075X-Dy for emacs-devel@gnu.org; Sat, 10 Mar 2007 04:47:59 -0500 Original-Received: (qmail invoked by alias); 10 Mar 2007 09:47:45 -0000 Original-Received: from N911P024.adsl.highway.telekom.at (EHLO [62.47.57.216]) [62.47.57.216] by mail.gmx.net (mp033) with SMTP; 10 Mar 2007 10:47:45 +0100 X-Authenticated: #14592706 X-Provags-ID: V01U2FsdGVkX1/K0EJSVILKlMiatTfyvy6MFFnpPzjAC5UJFu5Oc+ JmFfxEK01o1WHF User-Agent: Mozilla Thunderbird 1.0 (Windows/20041206) X-Accept-Language: de-DE, de, en-us, en X-Y-GMX-Trusted: 0 X-detected-kernel: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:67676 Archived-At: This is a multi-part message in MIME format. --------------050709040509060702030604 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Assume I modify *scratch* and try to `save-buffer' it as ".../bar/foo". (I know `write-file' should be used for this purpose but `save-buffer' offers the service as well.) Assume further, I mistype the name as ".../baz/foo" where the subdirectory "baz" does not exist. Emacs will complain as: basic-save-buffer-2: .../baz/foo: no such directory which is misleading since ".../baz/foo" is supposed to be a file. Assume now I notice my mistake and want to `save-buffer' *scratch* in the existing directory ".../bar/". Emacs will insist on storing my buffer as ".../baz/foo" and continue telling me that such a directory doesn't exist. After a while `auto-save-mode' may kick in and add to my confusion by complaining Auto-saving foo: Opening output file: no such file or directory, .../baz/#foo# This confusion could be relieved by the attached patch. --------------050709040509060702030604 Content-Type: text/plain; name="files.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="files.patch" *** files.el Fri Mar 9 07:48:34 2007 --- files.el Sat Mar 10 10:38:28 2007 *************** *** 3599,3606 **** (setq buffer-new-name (buffer-name buf)) (kill-buffer buf)) (rename-buffer buffer-new-name))) ! ;; If buffer has no file name, ask user for one. ! (or buffer-file-name (let ((filename (expand-file-name (read-file-name "File to save in: ") nil))) --- 3599,3607 ---- (setq buffer-new-name (buffer-name buf)) (kill-buffer buf)) (rename-buffer buffer-new-name))) ! ;; If buffer has no file name or the visited file is not writable, ask ! ;; user for one. ! (or (and buffer-file-name (file-writable-p buffer-file-name)) (let ((filename (expand-file-name (read-file-name "File to save in: ") nil))) *************** *** 3681,3687 **** (if (not (file-directory-p dir)) (if (file-exists-p dir) (error "%s is not a directory" dir) ! (error "%s: no such directory" buffer-file-name)) (if (not (file-exists-p buffer-file-name)) (error "Directory %s write-protected" dir) (if (yes-or-no-p --- 3682,3688 ---- (if (not (file-directory-p dir)) (if (file-exists-p dir) (error "%s is not a directory" dir) ! (error "%s: no such directory" dir)) (if (not (file-exists-p buffer-file-name)) (error "Directory %s write-protected" dir) (if (yes-or-no-p --------------050709040509060702030604 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Emacs-devel mailing list Emacs-devel@gnu.org http://lists.gnu.org/mailman/listinfo/emacs-devel --------------050709040509060702030604--