From: Matthew Newton <matt@knosis.org>
To: Noam Postavsky <npostavs@gmail.com>
Cc: dpaduchikh@gmail.com, 24576@debbugs.gnu.org
Subject: bug#24576: 25.1; desktop.el does not fully preserve registers with macros
Date: Wed, 22 May 2019 13:58:06 -0700 [thread overview]
Message-ID: <45ED012D-B370-473A-AF83-2165F5CD3DE3@knosis.org> (raw)
In-Reply-To: <87v9yhi3ux.fsf@gmail.com>
It seems that the more pressing issue is desktop handling byte code.
> On May 11, 2019, at 5:15 AM, Noam Postavsky <npostavs@gmail.com> wrote:
>
> Matthew Newton <matt@knosis.org> writes:
>
>> Apologies for reviving a stale bug but it appears to not be resolved yet.
>
> No apologies needed, on the contrary, thank you for looking at it.
>
>> So there seem to be two bugs:
>>
>> 1. `desktop-save-mode` doesn’t serialize/deserialize keyboard macros
>> properly (is it difficult to serialize a function object?)
Would it make sense to simply do something like this?
(defun desktop--v2s (value)
...
(cond
((byte-code-function-p value)
(let* ((pass1 (mapcar #'desktop--v2s value))
(special (assq nil pass1)))
(if special
(cons nil `(make-byte-code
,@(mapcar (lambda (el)
(if (eq (car el) 'must)
`',(cdr el) (cdr el)))
pass1)))
(cons 'may `[,@(mapcar #'cdr pass1)]))))
…))
I copied that from the `cond` clause for vector. It works in my limited testing.
Are there security concerns or other considerations?
>
>> 2. Either :print-func and :insert-func should never be set to
>> “Unprintable entity” or `register-val-describe` should handle the case
>> where they are set to that value instead of a function.
>
> The "unprintable entity" comes from desktop--v2s, looks like it doesn't
> handle compiled function values, so that's why :print-func and
> :insert-func get messed up like that.
>
>> I’ve also seen “Unprintable entity” show up when a buffer position
>> register points to a nonexistent buffer. Not sure how to reproduce
>> that one.
>
> I guess if you save a position in a buffer, then kill the buffer.
>
Here is what I found: if the killed buffer visits a file, it gets converted into a file-query. If there is no `buffer-file-name` then it stays a file marker pointing to nowhere. Desktop handles both of those cases correctly. So while I have seen it happen I’m not sure of the case where a buffer position register becomes an “Unprintable entity”. Did you find reproduction steps?
Cheers,
Matt
next prev parent reply other threads:[~2019-05-22 20:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-01 4:48 bug#24576: 25.1; desktop.el does not fully preserve registers with macros Dmitri Paduchikh
2019-05-10 20:53 ` Matthew Newton
2019-05-11 12:15 ` Noam Postavsky
2019-05-22 20:58 ` Matthew Newton [this message]
2019-05-23 3:43 ` Noam Postavsky
2019-05-29 17:41 ` Dmitri Paduchikh
2019-06-12 17:43 ` npostavs
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45ED012D-B370-473A-AF83-2165F5CD3DE3@knosis.org \
--to=matt@knosis.org \
--cc=24576@debbugs.gnu.org \
--cc=dpaduchikh@gmail.com \
--cc=npostavs@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.