From: Robert Goldman <rpgoldman@sift.net>
To: emacs-orgmode@gnu.org
Subject: Error with org-agenda with 9.5.3
Date: Thu, 02 Jun 2022 13:43:10 -0500 [thread overview]
Message-ID: <45E5BD65-878F-4BF8-A5CF-C42CE7B63A75@sift.net> (raw)
[-- Attachment #1: Type: text/plain, Size: 1717 bytes --]
I just updated org-mode using package.el and got release 9.5.3
Now I get an error in `org-at-timestamp-p` (OATP), which is invoked when
calling `org-agenda`.
I checked the repository and the problem is in commit 1f617727f1, which
added to this function the following code block:
```
- (let* ((regexp (if extended
- (if (eq extended 'agenda)
- org-element--timestamp-regexp
- org-ts-regexp3)
- org-ts-regexp2))
+ (let* ((regexp
+ (if extended
+ (if (eq extended 'agenda)
+ (rx (or (regexp org-ts-regexp3)
+ (regexp org-element--timestamp-regexp)))
+ org-ts-regexp3)
+ org-ts-regexp2))
```
The issue arises where OATP uses `rx` to process a regex stored in
`org-ts-regexp3`:
```
(rx (or (regexp org-ts-regexp3) ; here
(regexp org-element--timestamp-regexp)))
```
This fails because `rx-check` checks the sub-expression `(regexp
org-ts-regexp3)` to make sure that `org-ts-regexp3` is a string, but
`org-ts-regexp3` is not evaluated, and the *symbol* `org-ts-regexp3` is
not a string (it's a symbol), even though it's *value* is a string.
I'm not sure whether this is a bug in org-mode proper (I would have
thought this would be caught before release) or perhaps org-mode expects
some version of `rx.el` that I do not have. Unfortunately, I don't see
a version number in `rx.el`, only a copyright date.
I am running Emacs 25 (Aquamacs). So, maybe this code requires Emacs 26?
If so, it would be nice if org-mode 9.5.3 was tagged as incompatible
with Emacs 25? (It would also be nice if package mode supported
roll-back, but that's OT here!)
[-- Attachment #2: Type: text/html, Size: 3690 bytes --]
next reply other threads:[~2022-06-02 18:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-02 18:43 Robert Goldman [this message]
2022-06-03 6:18 ` Error with org-agenda with 9.5.3 Ihor Radchenko
2022-06-03 14:08 ` Ihor Radchenko
2022-06-03 15:32 ` Robert Goldman
2022-06-04 6:42 ` Bastien Guerry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45E5BD65-878F-4BF8-A5CF-C42CE7B63A75@sift.net \
--to=rpgoldman@sift.net \
--cc=emacs-orgmode@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.