From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: "Lennart Borgman (gmail)" Newsgroups: gmane.emacs.devel Subject: Re: [lennart.borgman@gmail.com: Re: map-y-or-n does not use minibuffer-prompt face] Date: Wed, 28 Feb 2007 10:27:36 +0100 Message-ID: <45E54B08.9030203@gmail.com> References: <87irdnmedf.fsf@catnip.gol.com> <45E4BF74.1090507@gmail.com> <871wkbm7v7.fsf@catnip.gol.com> <45E4D3D0.2040306@gmail.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1172654899 31103 80.91.229.12 (28 Feb 2007 09:28:19 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 28 Feb 2007 09:28:19 +0000 (UTC) Cc: emacs-devel@gnu.org, Miles Bader To: "Kim F. Storm" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 28 10:28:11 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1HML6Q-0004Kg-PU for ged-emacs-devel@m.gmane.org; Wed, 28 Feb 2007 10:28:03 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HML6R-0005ix-2a for ged-emacs-devel@m.gmane.org; Wed, 28 Feb 2007 04:28:03 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1HML6A-0005gM-Pm for emacs-devel@gnu.org; Wed, 28 Feb 2007 04:27:46 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1HML68-0005ek-Pz for emacs-devel@gnu.org; Wed, 28 Feb 2007 04:27:46 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1HML68-0005eh-KY for emacs-devel@gnu.org; Wed, 28 Feb 2007 04:27:44 -0500 Original-Received: from ch-smtp01.sth.basefarm.net ([80.76.149.212]) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1HML66-0000xo-0P; Wed, 28 Feb 2007 04:27:42 -0500 Original-Received: from c83-254-145-24.bredband.comhem.se ([83.254.145.24]:63447 helo=[127.0.0.1]) by ch-smtp01.sth.basefarm.net with esmtp (Exim 4.63) (envelope-from ) id 1HML64-0001gi-3P; Wed, 28 Feb 2007 10:27:40 +0100 User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8.0.9) Gecko/20061207 Thunderbird/1.5.0.9 Mnenhy/0.7.4.666 In-Reply-To: X-Antivirus: avast! (VPS 000718-0, 2007-02-27), Outbound message X-Antivirus-Status: Clean X-Scan-Result: No virus found in message 1HML64-0001gi-3P. X-Scan-Signature: ch-smtp01.sth.basefarm.net 1HML64-0001gi-3P 38c07f9daab64778b27608d2f227940e X-detected-kernel: Linux 2.6? (barebone, rare!) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:67009 Archived-At: Kim F. Storm wrote: > "Lennart Borgman (gmail)" writes: > >> Sorry, I thought I just said that those places should use >> minibuffer-prompt-properties'. > > Maybe you just said that in the mails you sent to me without > copying the list...? Maybe. Sorry. > We should clearly fix the prompts which lack the minibuffer-prompt face > completely (I will fix query-replace). > > But at this time I don't see a big need to fix this generally by > replacing all places that set (face minibuffer-prompt) explicitly > rather than using minibuffer-prompt-properties. > > I know Lennart disagree, but WDOT? Yes, I disagree and I think I will repeat the arguments for clarity. The reason is that I want it to be simple to toggle the face used by the minibuffer prompts. As I said in many other places we make it easy to toggle the face used by having a variable with the same name as the face. This variable is used when Emacs decides which face to use. By default it points to the face with the same name. Then the user can easily toggle between two different faces. This is what I want the user to be able to do in this case too. There is however no variable named minibuffer-prompt. Instead minibuffer-prompt-properties should be used here. Currently in some places it is used to select the face, in other places not. Kim, I think I sent you patches for all cases where I think minibuffer-prompt-properties should be used. Didn't I do that? (I am currently using those patches and they work well for me.)