From: martin rudalics <rudalics@gmx.at>
To: Nick Roberts <nickrob@snap.net.nz>
Cc: d <bojohan+mail@dd.chalmers.se>, rms@gnu.org, emacs-devel@gnu.org
Subject: Re: [bojohan+mail@dd.chalmers.se: Partial completion]
Date: Sat, 24 Feb 2007 14:46:55 +0100 [thread overview]
Message-ID: <45E041CF.1040100@gmx.at> (raw)
In-Reply-To: <17888.10288.446902.230637@kahikatea.snap.net.nz>
[-- Attachment #1: Type: text/plain, Size: 556 bytes --]
> Now (try-completion "" '(("") (""))) returns t.
> Previously it returned "".
I attached a patch for the offending occurrence of `try-completion'.
Please test it. There are two more occurrences that should be checked
though. And there's an additional problem: When, in *scratch*, I type
(defma )
do M-x PC-lisp-complete-symbol and choose say `defmath', the _entire_
contents of the buffer preceding defma are erased. I think this is due
to the fact that complete.el doesn't set `completion-base-size'
appropriately. Should this be corrected too?
[-- Attachment #2: complete.diff --]
[-- Type: text/plain, Size: 1645 bytes --]
*** complete.el Tue Jan 23 07:40:00 2007
--- complete.el Sat Feb 24 14:26:14 2007
***************
*** 661,679 ****
(looking-at PC-delim-regex))
(setq skip (concat skip
(regexp-quote prefix)
! PC-ndelims-regex)
! prefix (try-completion
! (PC-chunk-after
! ;; not basestr, because that does
! ;; not reflect insertions
! (buffer-substring
! (+ beg (length dirname)) end)
! skip)
! (mapcar
! (lambda (x)
! (when (string-match skip x)
! (substring x (match-end 0))))
! poss)))
(or (> i 0) (> (length prefix) 0))
(or (not (eq mode 'word))
(and first (> (length prefix) 0)
--- 661,683 ----
(looking-at PC-delim-regex))
(setq skip (concat skip
(regexp-quote prefix)
! PC-ndelims-regex))
! (let ((chunk
! (PC-chunk-after
! ;; not basestr, because that does
! ;; not reflect insertions
! (buffer-substring-no-properties
! (+ beg (length dirname)) end)
! skip)))
! (setq prefix (try-completion
! chunk
! (mapcar
! (lambda (x)
! (when (string-match skip x)
! (substring x (match-end 0))))
! poss)))
! (or (stringp prefix)
! (setq prefix (if prefix chunk ""))))
(or (> i 0) (> (length prefix) 0))
(or (not (eq mode 'word))
(and first (> (length prefix) 0)
[-- Attachment #3: Type: text/plain, Size: 142 bytes --]
_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel
next prev parent reply other threads:[~2007-02-24 13:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-24 8:28 [bojohan+mail@dd.chalmers.se: Partial completion] Richard Stallman
2007-02-24 11:57 ` Nick Roberts
2007-02-24 13:46 ` martin rudalics [this message]
2007-02-24 19:52 ` martin rudalics
2007-02-25 4:24 ` Nick Roberts
2007-02-25 9:31 ` martin rudalics
2007-02-25 19:30 ` Richard Stallman
2007-02-26 20:28 ` Nick Roberts
2007-03-02 1:24 ` Johan Bockgård
2007-03-08 20:44 ` Chong Yidong
2007-03-08 22:34 ` martin rudalics
2007-03-08 23:01 ` Chong Yidong
2007-03-09 16:20 ` Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45E041CF.1040100@gmx.at \
--to=rudalics@gmx.at \
--cc=bojohan+mail@dd.chalmers.se \
--cc=emacs-devel@gnu.org \
--cc=nickrob@snap.net.nz \
--cc=rms@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.