Mention mouse-face changes mouse pointer shape

Mention mouse-face changes mouse pointer shape

[Lennart Borgman (gmail)]

The 'mouse-face text property changes the mouse pointer shape to a hand, 
at least on w32. Should not this be mentioned, for example in

   (info "(elisp) Pointer Shape")
   (info "(elisp) Special Properties")

Re: Mention mouse-face changes mouse pointer shape

[Jason Rumney]

Lennart Borgman (gmail) wrote:
> The 'mouse-face text property changes the mouse pointer shape to a 
> hand, at least on w32. Should not this be mentioned, for example in
>
>   (info "(elisp) Pointer Shape")
>   (info "(elisp) Special Properties")

It seems the change was made immediately in response to the following 
comment in a discussion about implementing mouse-face in header and mode 
lines:
http://lists.gnu.org/archive/html/emacs-devel/2005-05/msg01268.html

    >/ I've implemented mouse-face on mode-line./
    >

    This looks nice!

    But shouldn't the cursor change to a hand cursor rather than an arrow
    cursor when hoovering over a mouse-face?



I think the change was a mistake, instead we should have arranged the 
relevant areas to have both mouse-face and pointer text properties. But 
I don't know how much effort it will be now to go back and change this.

RE: Mention mouse-face changes mouse pointer shape

[Drew Adams]

>     But shouldn't the cursor change to a hand cursor rather than an arrow
>     cursor when hoovering over a mouse-face?
>
> I think the change was a mistake, instead we should have arranged the
> relevant areas to have both mouse-face and pointer text properties. But
> I don't know how much effort it will be now to go back and change this.

I haven't followed this thread closely, but this does indeed sound like a
(design) mistake. The two, mouse-face and pointer shape, should be
independent, by default. If some particular code wants to couple them for
some purpose, that's fine, but such a coupling should not be hard-coded or
the default behavior.

The use and the interpretation of these properties should be open, IMO. Code
that uses them should be able to decide what their relation, if any, should
be in any given context.

It is wrong to assume that mouse-face always indicates a link. If it
indicates anything particular a priori, it is only that the mouse can
operate on the text in question somehow, and even that interpretation is not
required. It is also wrong to assume that the finger pointer always
indicates a link. The meaning of each of these two properties is open, by
default, and it makes no sense to hard-couple them.

If some people think that wedding them is helpful in general, then we could
have an option that does that. But 1) the default value of the option should
not couple them, and 2) even if generally coupled by the non-default option
value, this coupling should be easily overridable in any given context.

Re: Mention mouse-face changes mouse pointer shape

[Lennart Borgman (gmail)]

Drew Adams wrote:
>>     But shouldn't the cursor change to a hand cursor rather than an arrow
>>     cursor when hoovering over a mouse-face?
>>
>> I think the change was a mistake, instead we should have arranged the
>> relevant areas to have both mouse-face and pointer text properties. But
>> I don't know how much effort it will be now to go back and change this.
> 
> I haven't followed this thread closely, but this does indeed sound like a
> (design) mistake. The two, mouse-face and pointer shape, should be
> independent, by default. If some particular code wants to couple them for
> some purpose, that's fine, but such a coupling should not be hard-coded or
> the default behavior.


Something like 'mouse-face, 'mouse-link-face, 'mouse-pointer with 
appropirate priorities?

RE: Mention mouse-face changes mouse pointer shape

[Drew Adams]

> >>     But shouldn't the cursor change to a hand cursor rather
> >>     than an arrow cursor when hoovering over a mouse-face?
> >>
> >> I think the change was a mistake, instead we should have arranged the
> >> relevant areas to have both mouse-face and pointer text properties. But
> >> I don't know how much effort it will be now to go back and change this.
> >
> > I haven't followed this thread closely, but this does indeed
> > sound like a (design) mistake. The two, mouse-face and pointer
> > shape, should be independent, by default. If some particular code
> > wants to couple them for some purpose, that's fine, but such a
> > coupling should not be hard-coded or the default behavior.
>
> Something like 'mouse-face, 'mouse-link-face, 'mouse-pointer with
> appropirate priorities?

I don't know what you're proposing concretely, but any such proposals should
be discussed after the release.

I might have misunderstood, but I interpreted Jason's message to say that
these two properties are now coupled generally, instead of them both just
having been applied to the "relevant mode line areas". Perhaps the coupling
is not so general, and is limited to the mode line as a whole, but the same
argument still applies: they should be coupled only as needed, as particular
code sees fit.

My point was that, if these two properties are now coupled in a general way,
then that is a mistake. That would represent a change from the traditional
behavior, apparently slipped in as a bug fix, and it should be pulled out,
IMO. That's all I meant to say.

Re: Mention mouse-face changes mouse pointer shape

[Kim F. Storm]

Jason Rumney <jasonr@gnu.org> writes:

>> The 'mouse-face text property changes the mouse pointer shape to a
>> hand, at least on w32. Should not this be mentioned, for example in
>>
> I think the change was a mistake, instead we should have arranged the
> relevant areas to have both mouse-face and pointer text
> properties. But I don't know how much effort it will be now to go back
> and change this.

Maybe it was a mistake, but in most cases, I think a hand cursor is
the right pointer shape for mouse-face.  If necessary, a pointer
property can still be used to select another cursor shape.

If not, that's a bug we should fix.

-- 
Kim F. Storm <storm@cua.dk> http://www.cua.dk

Re: Mention mouse-face changes mouse pointer shape

[Jason Rumney]

Kim F. Storm wrote:
> If necessary, a pointer property can still be used to select another 
> cursor shape.

You are right. It can.

Re: Mention mouse-face changes mouse pointer shape

[Lennart Borgman (gmail)]

Jason Rumney wrote:
> Kim F. Storm wrote:
>> If necessary, a pointer property can still be used to select another 
>> cursor shape.
> 
> You are right. It can.


Fine. Then it looks like it should suffice to document the current 
behaviour, maybe at those places I pointed to?

RE: Mention mouse-face changes mouse pointer shape

[Drew Adams]

> >> The 'mouse-face text property changes the mouse pointer shape to a
> >> hand, at least on w32. Should not this be mentioned, for example in
> >>
> > I think the change was a mistake, instead we should have arranged the
> > relevant areas to have both mouse-face and pointer text
> > properties. But I don't know how much effort it will be now to go back
> > and change this.
>
> Maybe it was a mistake, but in most cases, I think a hand cursor is
> the right pointer shape for mouse-face.  If necessary, a pointer
> property can still be used to select another cursor shape.

IOW, you think the mouse-face and finger pointer should be coupled, by
default. And code that wants a different behavior would then override this
default behavior.

That's a design change that wasn't really discussed, AFAIK. I prefer the two
to be uncoupled by default. Why don't we discuss this after the release, and
revert this change now?

Re: Mention mouse-face changes mouse pointer shape

[Jason Rumney]

Drew Adams wrote:
> That's a design change that wasn't really discussed, AFAIK. I prefer the two
> to be uncoupled by default. Why don't we discuss this after the release, and
> revert this change now?
>   
It has been this way for 2 years now. We don't know how much code has 
come to rely on the current behaviour.