From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Newsgroups: gmane.emacs.bugs Subject: bug#42147: 28.0.50; pure vs side-effect-free, missing optimizations? Date: Wed, 8 Jul 2020 23:25:58 +0200 Message-ID: <459BE59A-76CE-46A3-BE5E-B65AED0B85F5@acm.org> References: <3A9CC2A3-8307-47B2-8D80-795C0AF020E1@acm.org> <775819003.2516724.1593687594435@mail.yahoo.com> <5F2B4684-34D1-4474-8909-9F435369FE54@acm.org> <705260433.2731607.1593698199171@mail.yahoo.com> <6CF8EE58-9A49-40E7-AA86-48AB39BF94BA@acm.org> <28B19D86-343C-4126-B95F-1F38735F73F2@acm.org> <1288c6a5-545b-f68c-ff6b-7683db3e54c1@cs.ucla.edu> <1690361185.4397117.1593879228865@mail.yahoo.com> <374F2E9C-E8C2-4362-8BEF-E6AA5EEE5C79@acm.org> <68F4CFD4-17BF-4ADA-B2EF-55281ACD2373@acm.org> <926674413.6042347.1594070583586@mail.yahoo.com> <475381031.6812910.1594139070322@mail.yahoo.com> Mime-Version: 1.0 (Mac OS X Mail 12.4 \(3445.104.14\)) Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23689"; mail-complaints-to="usenet@ciao.gmane.io" Cc: 42147-done@debbugs.gnu.org, Paul Eggert , Stefan Monnier , Andrea Corallo To: Andrea Corallo Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Wed Jul 08 23:27:18 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jtHb4-00062I-Kk for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Jul 2020 23:27:18 +0200 Original-Received: from localhost ([::1]:51786 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jtHb3-00074f-66 for geb-bug-gnu-emacs@m.gmane-mx.org; Wed, 08 Jul 2020 17:27:17 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:33646) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jtHao-000734-Va for bug-gnu-emacs@gnu.org; Wed, 08 Jul 2020 17:27:03 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:55917) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jtHao-0001t1-Kx for bug-gnu-emacs@gnu.org; Wed, 08 Jul 2020 17:27:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jtHao-0002wG-H4 for bug-gnu-emacs@gnu.org; Wed, 08 Jul 2020 17:27:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Mattias =?UTF-8?Q?Engdeg=C3=A5rd?= Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 08 Jul 2020 21:27:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 42147 X-GNU-PR-Package: emacs Original-Received: via spool by 42147-done@debbugs.gnu.org id=D42147.159424358111246 (code D ref 42147); Wed, 08 Jul 2020 21:27:02 +0000 Original-Received: (at 42147-done) by debbugs.gnu.org; 8 Jul 2020 21:26:21 +0000 Original-Received: from localhost ([127.0.0.1]:39230 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jtHa9-0002vK-4i for submit@debbugs.gnu.org; Wed, 08 Jul 2020 17:26:21 -0400 Original-Received: from mail229c50.megamailservers.eu ([91.136.10.239]:58006 helo=mail36c50.megamailservers.eu) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jtHa5-0002vA-O4 for 42147-done@debbugs.gnu.org; Wed, 08 Jul 2020 17:26:19 -0400 X-Authenticated-User: mattiase@bredband.net DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=megamailservers.eu; s=maildub; t=1594243566; bh=OcficJHeVm00KHmFD5HLeqO/sGSRs0RPa7G9mDLAp1U=; h=Subject:From:In-Reply-To:Date:Cc:References:To:From; b=gmKoE/xJbK/HFwvGCPulYk/UT5LsrZOiBtt13JqPJjBo6sQPu+wJsxEQg8I6XRYZ5 6REfzamYohi7Spr2B3XBIbIYv8odZLfL9IY3lJdd1FJXyQOjVz7LR3kumrTOqOAcKZ YJ0JHTTgupVqRGCE/cFvQ0+gdOmaAIHHdXDhI1qc= Feedback-ID: mattiase@acm.or Original-Received: from [192.168.0.4] (c188-150-171-71.bredband.comhem.se [188.150.171.71]) (authenticated bits=0) by mail36c50.megamailservers.eu (8.14.9/8.13.1) with ESMTP id 068LPwdX013732; Wed, 8 Jul 2020 21:26:03 +0000 In-Reply-To: X-Mailer: Apple Mail (2.3445.104.14) X-CTCH-RefID: str=0001.0A782F26.5F0639ED.006A, ss=1, re=0.000, recu=0.000, reip=0.000, cl=1, cld=1, fgs=0 X-CTCH-VOD: Unknown X-CTCH-Spam: Unknown X-CTCH-Score: 0.000 X-CTCH-Flags: 0 X-CTCH-ScoreCust: 0.000 X-CSC: 0 X-CHA: v=2.3 cv=PeiBeRpd c=1 sm=1 tr=0 a=SF+I6pRkHZhrawxbOkkvaA==:117 a=SF+I6pRkHZhrawxbOkkvaA==:17 a=kj9zAlcOel0A:10 a=M51BFTxLslgA:10 a=0MsoZ9UDlHlg4oHg0PQA:9 a=CjuIK1q_8ugA:10 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:182853 Archived-At: Hello Andrea, > In my version I assumed (after a look to the manual) to have strings = to > be immutable only at speed 3. Is it safe to assume this always = instead? Ultimately it depends on the transformations you do, but yes: this patch = substitutes let-bound names for their values, and since the behaviour of = mutating string literals is undefined, it's safe. Consider: (let ((s "abc")) (f s) s) It doesn't matter what 'f' does; since it isn't permitted to mutate its = argument string, the transformation to (progn (f "abc") "abc") is safe (assuming lexical binding, since f could otherwise set s to = something else). > Also I wanted ask why symbols are not included but only keywords, is > this to respect the side effect of interning them or something else? Symbols are included, but since this is (normalised) Lisp source, plain = symbols are variables; constants of symbol type are represented as = (quote SYM), matched by the and-expression. Keywords are just symbols = whose name begin with a colon, like :chocolate, and need no quoting.