From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Theodor Thornhill via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#59763: 29.0.60; Filling for c-ts-mode Date: Sat, 24 Dec 2022 09:42:30 +0100 Message-ID: <456ED673-26A2-408C-BC8E-70450C90ABD6@thornhill.no> References: Reply-To: Theodor Thornhill Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="20226"; mail-complaints-to="usenet@ciao.gmane.io" Cc: Eli Zaretskii , 59763@debbugs.gnu.org To: Yuan Fu Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Dec 24 09:45:18 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p909d-00052u-2j for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 24 Dec 2022 09:45:17 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1p909Q-0002OC-9l; Sat, 24 Dec 2022 03:45:04 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p909O-0002NX-Gl for bug-gnu-emacs@gnu.org; Sat, 24 Dec 2022 03:45:02 -0500 Original-Received: from debbugs.gnu.org ([209.51.188.43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p909O-0006px-5Z for bug-gnu-emacs@gnu.org; Sat, 24 Dec 2022 03:45:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1p909O-0003VN-1W for bug-gnu-emacs@gnu.org; Sat, 24 Dec 2022 03:45:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Theodor Thornhill Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 24 Dec 2022 08:45:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 59763 X-GNU-PR-Package: emacs Original-Received: via spool by 59763-submit@debbugs.gnu.org id=B59763.167187145013441 (code B ref 59763); Sat, 24 Dec 2022 08:45:02 +0000 Original-Received: (at 59763) by debbugs.gnu.org; 24 Dec 2022 08:44:10 +0000 Original-Received: from localhost ([127.0.0.1]:41775 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p908Y-0003Uj-Aj for submit@debbugs.gnu.org; Sat, 24 Dec 2022 03:44:10 -0500 Original-Received: from out2.migadu.com ([188.165.223.204]:23276) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1p908G-0003UA-CC for 59763@debbugs.gnu.org; Sat, 24 Dec 2022 03:44:09 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=thornhill.no; s=key1; t=1671871431; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ypRvxrfVZKAV0Volvo3Iyud5ricWCjouYwkNF3WSF8c=; b=hydBNrMo0/ySeJsOdEoqAwjNxafAY21SiygrfgpfGmlEiR67SO/oNxlwG47NdBXqkDRYRp NGH0WOXaBC6NEbk72Vk+eiltrBeE5KefpgPQftn//RZIphy/Kn+172H47RdWh79NWoPG/r 3pVjy/xxC6PoYP0JswRZsDPb9hBZ5/y9nALxHUR0DWWrQ8O1DHWeWFst9S4K22FQP/wPq2 O1aa3j3Cczo48BPu1xZgW24b9451VH1wEPnsHvLhv437/z8lFyNSx89kCoNCgmpf/fDoqT JB0tG8wgXn0y7tQcpoQBT8F+4niHhUg1HNmNcVNtQj6i4LQFTlpmuQDlPSL9bA== X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. In-Reply-To: X-Migadu-Flow: FLOW_OUT X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:251781 Archived-At: On 24 December 2022 09:36:21 CET, Yuan Fu wrote: > >Theodor Thornhill writes: > >> Yuan Fu writes: >> >>>> On Dec 2, 2022, at 6:58 AM, Eli Zaretskii wrote: >>>>=20 >>>>> From: Yuan Fu >>>>> Date: Thu, 1 Dec 2022 21:33:06 -0800 >>>>>=20 >>>>>=20 >>>>> IMO For c-ts-mode to be usable we need to have at least a basic fill= ing >>>>> function=2E Below is the function I have in my init=2Eel, could some= one have >>>>> a look and see if it=E2=80=99s good? Alternatively we could copy out= the comment >>>>> and fill it in a temp buffer with c-mode, but I didn=E2=80=99t have = the time to try >>>>> it out and see how well it works=2E >>>>=20 >>>> Thanks=2E >>>>=20 >>>> From quick testing, I see a problem: >>>>=20 >>>> =2E Visit dispnew=2Ec and go to the comment that starts on line 324= =2E Delete >>>> the newline between the two lines of the comment, and invoke the >>>> function=2E Observe how the first non-blank character of the comm= ent's >>>> second line is aligned with the "/*" on the previous line, not wit= h the >>>> text after "/*" as I'd expect=2E >>> >>> I see=2E I=E2=80=99ll need to look at how cc-mode fill comments=2E >>> >>>>=20 >>>> Btw, this command should be bound to M-q in ts-c-mode=2E >>> >>> Will do, once our fill function works well=2E BTW, Theo, if you have a= ny >>> idea, don=E2=80=99t hesitate to go ahead :-) No obligations, of course= =2E >>> >>> Yuan >> >> Sure! Added to my list :) I had a function at some point that used >> c-mode to do this=2E I'll see if I can polish it a little=2E > >I did some work in filling, it should work like cc-mode in like 90% of >the cases now, yay! > >Yuan Nice! For all cc-ts-modes? Theo