From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Jason Rumney Newsgroups: gmane.emacs.devel Subject: Re: Incorrect declarations of thread functions on w32 Date: Mon, 27 Nov 2006 09:38:45 +0000 Message-ID: <456AB225.2000804@gnu.org> References: <456A510B.1080202@student.lu.se> <456AA968.8090609@gnu.org> <456AA9C6.1060304@student.lu.se> <456AAA5A.2010702@gnu.org> <456AACD4.1000808@student.lu.se> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1164620364 12562 80.91.229.2 (27 Nov 2006 09:39:24 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 27 Nov 2006 09:39:24 +0000 (UTC) Cc: Emacs Devel Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Nov 27 10:39:23 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GocxI-0002hM-Ui for ged-emacs-devel@m.gmane.org; Mon, 27 Nov 2006 10:39:17 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GocxI-0007A5-GQ for ged-emacs-devel@m.gmane.org; Mon, 27 Nov 2006 04:39:16 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Gocx5-000793-1m for emacs-devel@gnu.org; Mon, 27 Nov 2006 04:39:03 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Gocx3-00077y-9u for emacs-devel@gnu.org; Mon, 27 Nov 2006 04:39:02 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gocx3-00077s-4G for emacs-devel@gnu.org; Mon, 27 Nov 2006 04:39:01 -0500 Original-Received: from [194.106.33.237] (helo=outmail.freedom2surf.net) by monty-python.gnu.org with esmtp (Exim 4.52) id 1Gocx1-0007NZ-58 for emacs-devel@gnu.org; Mon, 27 Nov 2006 04:38:59 -0500 Original-Received: from [127.0.0.1] (i-83-67-23-108.freedom2surf.net [83.67.23.108]) by outmail.freedom2surf.net (Postfix) with ESMTP id 1560C503B6; Mon, 27 Nov 2006 09:38:58 +0000 (GMT) User-Agent: Thunderbird 1.5.0.8 (Windows/20061025) Original-To: Lennart Borgman In-Reply-To: <456AACD4.1000808@student.lu.se> X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:62850 Archived-At: Lennart Borgman wrote: > I thought I had given enough information when saying this. In the > message before I told how the declaration should look according to MS. > w32_msg_worker should have a declaration that looks like > > DWORD WINAPI ThreadProc( > LPVOID lpParameter > ); > > where ThreadProc should be replaced with w32_msg_worker. The same for > reader_thread. reader thread already has that signature. > > Perhaps the declarations boils down to correct declarations under some > circumstances > , but I believe they should be changed since errors that bad > declarations produce might be very hard to find. (Memory corruption etc.) In the case of reader_thread, it is the correct declaration in all circumstances under Win32 (not under Win16, but Emacs does not target that platform)