From: Paul Eggert <eggert@cs.ucla.edu>
To: Ulrich Mueller <ulm@gentoo.org>, Andreas Schwab <schwab@suse.de>
Cc: Eli Zaretskii <eliz@gnu.org>, emacs-devel@gnu.org
Subject: Re: Merging bignum to master
Date: Tue, 14 Aug 2018 16:09:34 -0700 [thread overview]
Message-ID: <45550954-8d90-7e5e-a25b-3fc2c0eea730@cs.ucla.edu> (raw)
In-Reply-To: <ef1935ce-4fbb-e9d4-8e89-365d328e5c59@cs.ucla.edu>
[-- Attachment #1: Type: text/plain, Size: 399 bytes --]
On 08/13/2018 02:14 AM, Paul Eggert wrote:
> Ulrich Mueller wrote:
>> Maybe it would be cleaner to call the option --with-gmp (and invert its
>> logic), after all? It could still be enabled by default.
>
> Works for me.
>
On further thought it's probably a bit clearer to call it --with-libgmp
rather than --with-gmp since GMP code is always used one way or another,
so I installed the attached.
[-- Attachment #2: 0001-Rename-without-mini-gmp-to-with-libgmp.txt --]
[-- Type: text/plain, Size: 2938 bytes --]
From fafbe1c3a2e3174afa1d4bf6aeb8502fac7b5933 Mon Sep 17 00:00:00 2001
From: Paul Eggert <eggert@cs.ucla.edu>
Date: Tue, 14 Aug 2018 16:06:05 -0700
Subject: [PATCH] Rename --without-mini-gmp to --with-libgmp
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
* configure.ac (HAVE_GMP): Rename ‘configure’ option from
--without-mini-gmp to --with-libgmp. All uses changed.
* doc/lispref/numbers.texi (Predicates on Numbers): Large
integers are always available. Clarify how eq works on them.
---
configure.ac | 15 +++++++--------
doc/lispref/numbers.texi | 6 ++----
etc/NEWS | 2 +-
3 files changed, 10 insertions(+), 13 deletions(-)
diff --git a/configure.ac b/configure.ac
index 7b9448e13b..e5d094cf9e 100644
--- a/configure.ac
+++ b/configure.ac
@@ -4303,17 +4303,16 @@ AC_DEFUN
AC_SUBST(DESLIB)
AC_SUBST(KRB4LIB)
-AC_ARG_WITH([mini-gmp],
- [AS_HELP_STRING([--without-mini-gmp],
- [don't compile and use mini-gmp, a substitute for the
- GNU Multiple Precision (GMP) library; this is the
- default on systems with recent-enough GMP.])])
+AC_ARG_WITH([libgmp],
+ [AS_HELP_STRING([--without-libgmp],
+ [don't use the GNU Multiple Precision (GMP) library;
+ this is the default on systems lacking libgmp.])])
GMP_LIB=
GMP_OBJ=mini-gmp-emacs.o
HAVE_GMP=no
-case $with_mini_gmp in
- yes) ;;
- no) HAVE_GMP=yes GMP_LIB=-lgmp;;
+case $with_libgmp in
+ no) ;;
+ yes) HAVE_GMP=yes GMP_LIB=-lgmp;;
*) AC_CHECK_HEADERS([gmp.h],
[OLIBS=$LIBS
AC_SEARCH_LIBS([__gmpz_roinit_n], [gmp])
diff --git a/doc/lispref/numbers.texi b/doc/lispref/numbers.texi
index 89205f9df3..bd633b77c3 100644
--- a/doc/lispref/numbers.texi
+++ b/doc/lispref/numbers.texi
@@ -319,10 +319,8 @@ Predicates on Numbers
@defun bignump object
This predicate tests whether its argument is a large integer, and
-returns @code{t} if so, @code{nil} otherwise. Large integers cannot
-be compared with @code{eq}, only with @code{=} or @code{eql}. Also,
-large integers are only available if Emacs was compiled with the GMP
-library.
+returns @code{t} if so, @code{nil} otherwise. Unlike small integers,
+large integers can be @code{=} or @code{eql} even if they are not @code{eq}.
@end defun
@defun fixnump object
diff --git a/etc/NEWS b/etc/NEWS
index f1d09a2b63..3ae956c788 100644
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -27,7 +27,7 @@ When you add a new item, use the appropriate mark if you are sure it applies,
** Emacs now uses GMP, the GNU Multiple Precision library.
By default, if 'configure' does not find a suitable libgmp, it
arranges for the included mini-gmp library to be built and used.
-The new 'configure' option --with-mini-gmp uses mini-gmp even if a
+The new 'configure' option --without-libgmp uses mini-gmp even if a
suitable libgmp is available.
** The new configure option '--with-json' adds support for JSON using
--
2.17.1
next prev parent reply other threads:[~2018-08-14 23:09 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-11 19:47 Merging bignum to master Tom Tromey
2018-08-11 21:28 ` Basil L. Contovounesios
2018-08-12 16:34 ` Tom Tromey
2018-08-13 12:21 ` Basil L. Contovounesios
2018-08-14 0:21 ` Andy Moreton
2018-08-15 23:41 ` Andy Moreton
2018-08-16 15:38 ` Basil L. Contovounesios
2018-08-19 8:26 ` Paul Eggert
2018-08-17 14:58 ` Eli Zaretskii
2018-08-12 6:29 ` Ulrich Mueller
2018-08-12 8:09 ` Paul Eggert
2018-08-12 17:21 ` Ulrich Mueller
2018-08-12 18:20 ` Eli Zaretskii
2018-08-12 19:30 ` Ulrich Mueller
2018-08-13 0:15 ` Paul Eggert
2018-08-12 18:05 ` Eli Zaretskii
2018-08-12 23:53 ` Paul Eggert
2018-08-13 0:20 ` Tom Tromey
2018-08-13 7:51 ` Andreas Schwab
2018-08-13 8:06 ` Ulrich Mueller
2018-08-13 9:14 ` Paul Eggert
2018-08-14 23:09 ` Paul Eggert [this message]
2018-08-16 2:46 ` Richard Stallman
2018-08-13 23:31 ` Richard Stallman
2018-08-14 1:41 ` Paul Eggert
2018-08-16 2:41 ` Richard Stallman
2018-08-16 19:31 ` Paul Eggert
2018-08-16 22:02 ` Stefan Monnier
2018-08-12 7:37 ` John Wiegley
2018-08-12 18:21 ` Eli Zaretskii
2018-08-12 11:48 ` Pip Cet
2018-08-12 16:02 ` Tom Tromey
2018-08-13 22:58 ` Paul Eggert
2018-08-14 1:12 ` Noam Postavsky
2018-08-14 13:04 ` Pip Cet
2018-08-14 18:01 ` Paul Eggert
2018-08-15 15:20 ` Pip Cet
2018-08-15 16:17 ` Paul Eggert
2018-08-15 23:57 ` Andy Moreton
2018-08-16 22:00 ` Stefan Monnier
2018-08-20 16:28 ` Some vars now limited to fixnum size. (Was: Merging bignum to master) Karl Fogel
2018-08-20 16:54 ` Paul Eggert
2018-08-20 17:27 ` Eli Zaretskii
2018-08-20 17:27 ` Paul Eggert
2018-08-20 18:00 ` Eli Zaretskii
2018-08-20 19:55 ` Pip Cet
2018-08-20 23:15 ` Paul Eggert
2018-08-21 15:01 ` Some vars now limited to fixnum size Tom Tromey
2018-08-21 16:36 ` Andy Moreton
2018-08-21 18:46 ` Paul Eggert
2018-08-22 15:39 ` Tom Tromey
2018-08-21 3:38 ` Some vars now limited to fixnum size. (Was: Merging bignum to master) Richard Stallman
2018-08-21 4:09 ` Paul Eggert
2018-08-22 4:03 ` Richard Stallman
2018-08-22 4:53 ` Paul Eggert
2018-08-20 17:25 ` Eli Zaretskii
2018-08-14 0:51 ` Merging bignum to master Andy Moreton
2018-08-15 15:46 ` Andy Moreton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45550954-8d90-7e5e-a25b-3fc2c0eea730@cs.ucla.edu \
--to=eggert@cs.ucla.edu \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=schwab@suse.de \
--cc=ulm@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.