From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?ISO-8859-1?Q?Jan_Dj=E4rv?= Newsgroups: gmane.emacs.devel Subject: Re: install error on Mac OS X Date: Tue, 07 Nov 2006 08:26:45 +0100 Message-ID: <45503535.80800@swipnet.se> References: <86ac3cqbna.fsf@rakim.cfhp.org> <20061101.090235.63826615.kazu@iij.ad.jp> <86fyd2knb3.fsf@blue.stonehenge.com> <86wt6cnya2.fsf@blue.stonehenge.com> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1162884478 13386 80.91.229.2 (7 Nov 2006 07:27:58 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 7 Nov 2006 07:27:58 +0000 (UTC) Cc: emacs-devel@gnu.org, rms@gnu.org, merlyn@stonehenge.com Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Nov 07 08:27:55 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GhLN5-0001g8-UE for ged-emacs-devel@m.gmane.org; Tue, 07 Nov 2006 08:27:49 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GhLN4-00050Y-RD for ged-emacs-devel@m.gmane.org; Tue, 07 Nov 2006 02:27:46 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GhLML-0004zR-1D for emacs-devel@gnu.org; Tue, 07 Nov 2006 02:27:01 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GhLMG-0004xL-E5 for emacs-devel@gnu.org; Tue, 07 Nov 2006 02:27:00 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GhLMF-0004ww-Nw for emacs-devel@gnu.org; Tue, 07 Nov 2006 02:26:55 -0500 Original-Received: from [81.228.9.182] (helo=av7-2-sn3.vrr.skanova.net) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GhLME-0007yF-E9; Tue, 07 Nov 2006 02:26:54 -0500 Original-Received: by av7-2-sn3.vrr.skanova.net (Postfix, from userid 502) id 5ACFF37F93; Tue, 7 Nov 2006 08:26:39 +0100 (CET) Original-Received: from smtp3-2-sn3.vrr.skanova.net (smtp3-2-sn3.vrr.skanova.net [81.228.9.102]) by av7-2-sn3.vrr.skanova.net (Postfix) with ESMTP id 45DF837F60; Tue, 7 Nov 2006 08:26:39 +0100 (CET) Original-Received: from coolsville.localdomain (81-235-205-78-no59.tbcn.telia.com [81.235.205.78]) by smtp3-2-sn3.vrr.skanova.net (Postfix) with ESMTP id B0F5A37E7F; Tue, 7 Nov 2006 08:26:48 +0100 (CET) User-Agent: Thunderbird 1.5.0.7 (X11/20060913) Original-To: YAMAMOTO Mitsuharu In-Reply-To: X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:61893 Archived-At: YAMAMOTO Mitsuharu skrev: >>>>>> On Mon, 06 Nov 2006 16:00:25 -0500, Richard Stallman said: > >>> To use X should require a specific option. >> What should we do for the case that --with-x-toolkit (or other >> X-specific options) is specified without explicit --with-x or >> --without-carbon? > >> It would make sense for --with-x-toolkit to imply --with-x. > > Could anyone who is familiar with autoconf check the following patch? > > YAMAMOTO Mitsuharu > mituharu@math.s.chiba-u.ac.jp > > Index: configure.in > =================================================================== > RCS file: /cvsroot/emacs/emacs/configure.in,v > retrieving revision 1.416 > diff -c -r1.416 configure.in > *** configure.in 4 Nov 2006 03:28:27 -0000 1.416 > --- configure.in 7 Nov 2006 01:58:43 -0000 > *************** > *** 1779,1785 **** > if test "${window_system}" = x11 && test "${HAVE_CARBON}" = yes; then > if test "${with_carbon+set}" != set \ > && test "${carbon_appdir_x+set}" != set; then > ! HAVE_CARBON=no > fi > fi > if test "${HAVE_CARBON}" = yes; then > --- 1779,1791 ---- > if test "${window_system}" = x11 && test "${HAVE_CARBON}" = yes; then > if test "${with_carbon+set}" != set \ > && test "${carbon_appdir_x+set}" != set; then > ! for var in with_x with_x_toolkit with_gtk with_xim \ > ! with_xpm with_jpeg with_tiff with_gif with_png; do > ! if test "`eval 'echo \"${'\"$var\"'+set}\"'`" = set; then > ! HAVE_CARBON=no > ! break > ! fi > ! done > fi > fi > if test "${HAVE_CARBON}" = yes; then For clarity, and to get rid of the backticks, I would write the for loop like this: for var in with_x with_x_toolkit with_gtk with_xim \ with_xpm with_jpeg with_tiff with_gif with_png; do eval "x=\${$var+set}"; if test "$x" = set; then ... Other than that, it looks fine. Jan D.