From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: =?ISO-8859-1?Q?Jan_Dj=E4rv?= Newsgroups: gmane.emacs.devel Subject: Re: raise-frame doesn't work in Fedora Core 4 Date: Tue, 31 Oct 2006 13:24:41 +0100 Message-ID: <45474089.3090606@swipnet.se> References: NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1162297584 14280 80.91.229.2 (31 Oct 2006 12:26:24 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Tue, 31 Oct 2006 12:26:24 +0000 (UTC) Cc: Masatake YAMATO , emacs-devel@gnu.org, Kenichi Handa Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue Oct 31 13:26:19 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1Gesh0-0007Oo-VV for ged-emacs-devel@m.gmane.org; Tue, 31 Oct 2006 13:26:11 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gesh0-0005gX-AZ for ged-emacs-devel@m.gmane.org; Tue, 31 Oct 2006 07:26:10 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Gesgm-0005fE-Cg for emacs-devel@gnu.org; Tue, 31 Oct 2006 07:25:56 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Gesgh-0005cl-Pl for emacs-devel@gnu.org; Tue, 31 Oct 2006 07:25:56 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Gesgh-0005cd-IT for emacs-devel@gnu.org; Tue, 31 Oct 2006 07:25:51 -0500 Original-Received: from [81.228.9.185] (helo=av9-1-sn3.vrr.skanova.net) by monty-python.gnu.org with esmtp (Exim 4.52) id 1Gesgh-00077q-03 for emacs-devel@gnu.org; Tue, 31 Oct 2006 07:25:51 -0500 Original-Received: by av9-1-sn3.vrr.skanova.net (Postfix, from userid 502) id 2954337EAB; Tue, 31 Oct 2006 13:25:50 +0100 (CET) Original-Received: from smtp3-1-sn3.vrr.skanova.net (smtp3-1-sn3.vrr.skanova.net [81.228.9.101]) by av9-1-sn3.vrr.skanova.net (Postfix) with ESMTP id 18BA737E45; Tue, 31 Oct 2006 13:25:49 +0100 (CET) Original-Received: from coolsville.localdomain (81-235-205-78-no59.tbcn.telia.com [81.235.205.78]) by smtp3-1-sn3.vrr.skanova.net (Postfix) with ESMTP id E59F437E47; Tue, 31 Oct 2006 13:25:42 +0100 (CET) User-Agent: Thunderbird 1.5.0.7 (Macintosh/20060909) Original-To: Katsumi Yamaoka In-Reply-To: X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:61473 Archived-At: Katsumi Yamaoka skrev: > Thanks Handa-san for following this up. > >>>>>> In Kenichi Handa wrote: > >> I've just got a report saying that the problem reported here: > >> http://www.archivum.info/emacs-devel@gnu.org/2005-06/msg01570.html > >> is not yet fixed. > >> The contents is this: > >>> I did them in the Fedora Core 4 platform. Since `raise-frame' >>> does nothing in this platform,... > > It does nothing also in Fedora Core 5. > > Masatake YAMATO once tried to fix this and offered a patch to me > on 9 Sep 2005. I tried it with Emacs CVS then and confirmed it > enabled `raise-frame' to perform. I would very much appreciate > someone looking into it. Here it is: > > *** xterm.c Sun Aug 28 04:13:33 +0900 1.873 > --- xterm.c Fri Sep 09 02:33:55 +0900 > *************** > *** 8492,8497 **** > --- 8492,8524 ---- > if (f->async_visible) > { > BLOCK_INPUT; > + > + { > + /* See _NET_ACTIVE_WINDOW in > + http://freedesktop.org/wiki/Standards_2fwm_2dspec */ > + XEvent event; > + > + event.xclient.type = ClientMessage; > + event.xclient.serial = 0; > + event.xclient.send_event = True; > + > + event.xclient.message_type = XInternAtom(FRAME_X_DISPLAY (f), > + "_NET_ACTIVE_WINDOW", > + False); > + event.xclient.window = FRAME_OUTER_WINDOW (f); > + event.xclient.format = 32; > + event.xclient.data.l[0] = 1; /* source indication */ > + event.xclient.data.l[1] = 0; /* timestamp */ > + event.xclient.data.l[2] = 0; /* requestor's currently active window */ I think we must fill this in with the X window of the frame that is raised. I don't think it does the right thing if many frames are open. There is alot in this spec Emacs doesn't do, we have to review it after the release. But I guess this patch is OK, if active window is added. Jan D.