* bug#74915: [PATCH] Fix custom types of gnus-article-treat-head-custom variables
@ 2024-12-16 17:33 Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-16 18:15 ` Robert Pluim
0 siblings, 1 reply; 9+ messages in thread
From: Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2024-12-16 17:33 UTC (permalink / raw)
To: 74915
[-- Attachment #1: Type: text/plain, Size: 2967 bytes --]
Tags: patch
Fix custom of types of Gnus-Art variables using gnus-article-treat-head-custom.
In GNU Emacs 31.0.50 (build 1, x86_64-suse-linux-gnu, GTK+ Version
3.24.43, cairo version 1.18.2)
Repository revision: eaf5bf736e1dd5eb977a16a3f1b3dfd3da3c4612
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12101014
System Description: openSUSE Tumbleweed
Configured using:
'configure --disable-build-details --without-pop --with-mailutils
--without-hesiod --with-gameuser=:games --with-kerberos
--with-kerberos5 --with-file-notification=inotify --with-modules
--enable-autodepend --enable-link-time-optimization --prefix=/usr
--mandir=/usr/share/man --infodir=/usr/share/info --datadir=/usr/share
--localstatedir=/var --sharedstatedir=/var/lib
--libexecdir=/usr/libexec --with-file-notification=yes
--libdir=/usr/lib64 --with-native-compilation=aot
--enable-locallisppath=/usr/share/emacs/31.0.50/site-lisp:/usr/share/emacs/site-lisp
--with-x --with-xim --with-sound --with-xpm --with-jpeg --with-tiff
--with-gif --with-png --with-rsvg --with-dbus --with-xft --without-gpm
--with-tree-sitter --with-x-toolkit=gtk --without-pgtk
--with-toolkit-scroll-bars --x-includes=/usr/include
--x-libraries=/usr/lib64 --with-libotf --with-m17n-flt --with-cairo
--build=x86_64-suse-linux --with-dumping=pdumper
build_alias=x86_64-suse-linux 'CC=sccache cc' 'CFLAGS=-O2 -Wall
-U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong
-funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection
-Werror=return-type -flto=auto -march=znver3 -mmmx -mpopcnt -msse
-msse2 -msse3 -mssse3 -msse4.1 -msse4.2 -mavx -mavx2 -msse4a -mno-fma4
-mno-xop -mfma -mbmi -mbmi2 -maes -mpclmul -mno-gfni -mvpclmulqdq
-mno-3dnow -madx -mabm -mno-cldemote -mclflushopt -mclwb -mclzero
-mcx16 -mno-enqcmd -mf16c -mfsgsbase -mfxsr -mno-hle -msahf -mno-lwp
-mlzcnt -mmovbe -mno-movdir64b -mno-movdiri -mmwaitx -mno-pconfig -mpku
-mprfchw -mno-ptwrite -mrdpid -mrdrnd -mrdseed -mno-rtm -mno-serialize
-mno-sgx -msha -mshstk -mno-tbm -mno-tsxldtrk -mvaes -mno-waitpkg
-mwbnoinvd -mxsave -mxsavec -mxsaveopt -mxsaves -mno-amx-tile
-mno-amx-int8 -mno-amx-bf16 -mno-uintr -mno-hreset -mno-kl -mno-widekl
-mno-avxvnni -mno-avxifma -mno-avxvnniint8 -mno-avxneconvert
-mno-cmpccxadd -mno-amx-fp16 -mno-prefetchi -mno-raoint
-mno-amx-complex --param l1-cache-size=32 --param l1-cache-line-size=64
--param l2-cache-size=512 -mtune=znver3 -fno-optimize-sibling-calls -O2
-Wall -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=3 -fstack-protector-strong
-funwind-tables -fasynchronous-unwind-tables -fstack-clash-protection
-Werror=return-type -flto=auto -g -D_GNU_SOURCE
-DGDK_DISABLE_DEPRECATION_WARNINGS -DGLIB_DISABLE_DEPRECATION_WARNINGS
-pipe -Wno-pointer-sign -Wno-unused-variable -Wno-unused-label
-DPDMP_BASE='\''"emacs-gtk"'\''' LDFLAGS=-Wl,-O2 'CXX=sccache c++'
PKG_CONFIG_PATH=:/usr/lib64/pkgconfig:/usr/share/pkgconfig'
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-Fix-custom-types-of-gnus-article-treat-head-custom-v.patch --]
[-- Type: text/patch, Size: 1379 bytes --]
From 2b365a8804afab600437aa9e8dba3c45ac4363fe Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bj=C3=B6rn=20Bidar?= <bjorn.bidar@thaodan.de>
Date: Mon, 16 Dec 2024 19:20:00 +0200
Subject: [PATCH] Fix custom types of gnus-article-treat-head-custom variables
lisp/gnus/gnus-art.el (gnus-treat-buttonize-head, gnus-treat-date)
(gnus-treat-hide-headers, gnus-treat-hide-boring-headers)
(gnus-treat-highlight-headers, gnus-treat-display-x-face)
(gnus-treat-display-face, gnus-treat-display-face)
(gnus-treat-mail-picon, gnus-treat-newsgroups-picon)
(gnus-treat-from-gravatar, gnus-treat-mail-gravatar)
(gnus-treat-body-boundary): Fix custom types to
include all possible choices mentioned in the docstrings and manual.
---
lisp/gnus/gnus-art.el | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/lisp/gnus/gnus-art.el b/lisp/gnus/gnus-art.el
index 8243e4e632b..13dfb737243 100644
--- a/lisp/gnus/gnus-art.el
+++ b/lisp/gnus/gnus-art.el
@@ -1113,7 +1113,10 @@ gnus-article-treat-custom
(defvar gnus-article-treat-head-custom
'(choice (const :tag "Off" nil)
- (const :tag "Header" head)))
+ (const :tag "Header" head)
+ (const :tag "First" first)
+ (const :tag "Last" last)
+ (boolean :tag "All body parts" t)))
(defvar gnus-article-treat-types '("text/plain" "text/x-verbatim"
"text/x-patch" "text/html")
--
2.45.2
^ permalink raw reply related [flat|nested] 9+ messages in thread* bug#74915: [PATCH] Fix custom types of gnus-article-treat-head-custom variables
2024-12-16 17:33 bug#74915: [PATCH] Fix custom types of gnus-article-treat-head-custom variables Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2024-12-16 18:15 ` Robert Pluim
2024-12-16 22:30 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <6760a9ed.df0a0220.1a04c9.e35cSMTPIN_ADDED_BROKEN@mx.google.com>
0 siblings, 2 replies; 9+ messages in thread
From: Robert Pluim @ 2024-12-16 18:15 UTC (permalink / raw)
To: 74915; +Cc: Björn Bidar
>>>>> On Mon, 16 Dec 2024 19:33:31 +0200, Björn Bidar via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org> said:
Björn> From 2b365a8804afab600437aa9e8dba3c45ac4363fe Mon Sep 17 00:00:00 2001
Björn> From: =?UTF-8?q?Bj=C3=B6rn=20Bidar?= <bjorn.bidar@thaodan.de>
Björn> Date: Mon, 16 Dec 2024 19:20:00 +0200
Björn> Subject: [PATCH] Fix custom types of gnus-article-treat-head-custom variables
Björn> lisp/gnus/gnus-art.el (gnus-treat-buttonize-head, gnus-treat-date)
Björn> (gnus-treat-hide-headers, gnus-treat-hide-boring-headers)
Björn> (gnus-treat-highlight-headers, gnus-treat-display-x-face)
Björn> (gnus-treat-display-face, gnus-treat-display-face)
Björn> (gnus-treat-mail-picon, gnus-treat-newsgroups-picon)
Björn> (gnus-treat-from-gravatar, gnus-treat-mail-gravatar)
Björn> (gnus-treat-body-boundary): Fix custom types to
Björn> include all possible choices mentioned in the docstrings
Björn> and manual.
The commit message only needs to mention the type you actually
changed, in this case `gnus-article-treat-head-custom'
Björn> ---
Björn> lisp/gnus/gnus-art.el | 5 ++++-
Björn> 1 file changed, 4 insertions(+), 1 deletion(-)
Björn> diff --git a/lisp/gnus/gnus-art.el b/lisp/gnus/gnus-art.el
Björn> index 8243e4e632b..13dfb737243 100644
Björn> --- a/lisp/gnus/gnus-art.el
Björn> +++ b/lisp/gnus/gnus-art.el
Björn> @@ -1113,7 +1113,10 @@ gnus-article-treat-custom
Björn> (defvar gnus-article-treat-head-custom
Björn> '(choice (const :tag "Off" nil)
Björn> - (const :tag "Header" head)))
Björn> + (const :tag "Header" head)
Björn> + (const :tag "First" first)
Björn> + (const :tag "Last" last)
Björn> + (boolean :tag "All body parts" t)))
`t' is a const, not a boolean, the same as `nil', in the context of
defcustom. Plus a lot of the docstrings look cut&paste, so Iʼm not
entirely sure that itʼs the existing type that is wrong rather than
the docstring.
Robert
--
^ permalink raw reply [flat|nested] 9+ messages in thread* bug#74915: [PATCH] Fix custom types of gnus-article-treat-head-custom variables
2024-12-16 18:15 ` Robert Pluim
@ 2024-12-16 22:30 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <6760a9ed.df0a0220.1a04c9.e35cSMTPIN_ADDED_BROKEN@mx.google.com>
1 sibling, 0 replies; 9+ messages in thread
From: Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2024-12-16 22:30 UTC (permalink / raw)
To: Robert Pluim; +Cc: 74915
Robert Pluim <rpluim@gmail.com> writes:
>>>>>> On Mon, 16 Dec 2024 19:33:31 +0200, Björn Bidar via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org> said:
> Björn> From 2b365a8804afab600437aa9e8dba3c45ac4363fe Mon Sep 17 00:00:00 2001
> Björn> From: =?UTF-8?q?Bj=C3=B6rn=20Bidar?= <bjorn.bidar@thaodan.de>
> Björn> Date: Mon, 16 Dec 2024 19:20:00 +0200
> Björn> Subject: [PATCH] Fix custom types of gnus-article-treat-head-custom variables
>
> Björn> lisp/gnus/gnus-art.el (gnus-treat-buttonize-head, gnus-treat-date)
> Björn> (gnus-treat-hide-headers, gnus-treat-hide-boring-headers)
> Björn> (gnus-treat-highlight-headers, gnus-treat-display-x-face)
> Björn> (gnus-treat-display-face, gnus-treat-display-face)
> Björn> (gnus-treat-mail-picon, gnus-treat-newsgroups-picon)
> Björn> (gnus-treat-from-gravatar, gnus-treat-mail-gravatar)
> Björn> (gnus-treat-body-boundary): Fix custom types to
> Björn> include all possible choices mentioned in the docstrings
> Björn> and manual.
>
> The commit message only needs to mention the type you actually
> changed, in this case `gnus-article-treat-head-custom'
The type meaning the custom type or the variable?
> Björn> ---
> Björn> lisp/gnus/gnus-art.el | 5 ++++-
> Björn> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> Björn> diff --git a/lisp/gnus/gnus-art.el b/lisp/gnus/gnus-art.el
> Björn> index 8243e4e632b..13dfb737243 100644
> Björn> --- a/lisp/gnus/gnus-art.el
> Björn> +++ b/lisp/gnus/gnus-art.el
> Björn> @@ -1113,7 +1113,10 @@ gnus-article-treat-custom
>
> Björn> (defvar gnus-article-treat-head-custom
> Björn> '(choice (const :tag "Off" nil)
> Björn> - (const :tag "Header" head)))
> Björn> + (const :tag "Header" head)
> Björn> + (const :tag "First" first)
> Björn> + (const :tag "Last" last)
> Björn> + (boolean :tag "All body parts" t)))
>
> `t' is a const, not a boolean, the same as `nil', in the context of
> defcustom.
There's bolean in the context of custom but I the context of choice is
should be const with nil or t.
> Plus a lot of the docstrings look cut&paste, so Iʼm not
> entirely sure that itʼs the existing type that is wrong rather than
> the docstring.
The manual, in (info "(gnus) Customizing Articles") , seem to match with
those and talk in general like they apply to all of these.
^ permalink raw reply [flat|nested] 9+ messages in thread[parent not found: <6760a9ed.df0a0220.1a04c9.e35cSMTPIN_ADDED_BROKEN@mx.google.com>]
* bug#74915: [PATCH] Fix custom types of gnus-article-treat-head-custom variables
[not found] ` <6760a9ed.df0a0220.1a04c9.e35cSMTPIN_ADDED_BROKEN@mx.google.com>
@ 2024-12-17 7:28 ` Robert Pluim
2024-12-17 10:22 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 9+ messages in thread
From: Robert Pluim @ 2024-12-17 7:28 UTC (permalink / raw)
To: Björn Bidar; +Cc: 74915
>>>>> On Tue, 17 Dec 2024 00:30:04 +0200, Björn Bidar <bjorn.bidar@thaodan.de> said:
Björn> Robert Pluim <rpluim@gmail.com> writes:
>>>>>>> On Mon, 16 Dec 2024 19:33:31 +0200, Björn Bidar via "Bug reports for GNU Emacs, the Swiss army knife of text editors" <bug-gnu-emacs@gnu.org> said:
Björn> From 2b365a8804afab600437aa9e8dba3c45ac4363fe Mon Sep 17 00:00:00 2001
Björn> From: =?UTF-8?q?Bj=C3=B6rn=20Bidar?= <bjorn.bidar@thaodan.de>
Björn> Date: Mon, 16 Dec 2024 19:20:00 +0200
Björn> Subject: [PATCH] Fix custom types of gnus-article-treat-head-custom variables
>>
Björn> lisp/gnus/gnus-art.el (gnus-treat-buttonize-head, gnus-treat-date)
Björn> (gnus-treat-hide-headers, gnus-treat-hide-boring-headers)
Björn> (gnus-treat-highlight-headers, gnus-treat-display-x-face)
Björn> (gnus-treat-display-face, gnus-treat-display-face)
Björn> (gnus-treat-mail-picon, gnus-treat-newsgroups-picon)
Björn> (gnus-treat-from-gravatar, gnus-treat-mail-gravatar)
Björn> (gnus-treat-body-boundary): Fix custom types to
Björn> include all possible choices mentioned in the docstrings
Björn> and manual.
>>
>> The commit message only needs to mention the type you actually
>> changed, in this case `gnus-article-treat-head-custom'
Björn> The type meaning the custom type or the variable?
The variable. All the other things you mention use the variable, but
there is no code change for them.
Björn> ---
Björn> lisp/gnus/gnus-art.el | 5 ++++-
Björn> 1 file changed, 4 insertions(+), 1 deletion(-)
>>
Björn> diff --git a/lisp/gnus/gnus-art.el b/lisp/gnus/gnus-art.el
Björn> index 8243e4e632b..13dfb737243 100644
Björn> --- a/lisp/gnus/gnus-art.el
Björn> +++ b/lisp/gnus/gnus-art.el
Björn> @@ -1113,7 +1113,10 @@ gnus-article-treat-custom
>>
Björn> (defvar gnus-article-treat-head-custom
Björn> '(choice (const :tag "Off" nil)
Björn> - (const :tag "Header" head)))
Björn> + (const :tag "Header" head)
Björn> + (const :tag "First" first)
Björn> + (const :tag "Last" last)
Björn> + (boolean :tag "All body parts" t)))
>>
>> `t' is a const, not a boolean, the same as `nil', in the context of
>> defcustom.
Björn> There's bolean in the context of custom but I the context of choice is
Björn> should be const with nil or t.
`nil' is already in the list.
>> Plus a lot of the docstrings look cut&paste, so Iʼm not
>> entirely sure that itʼs the existing type that is wrong rather than
>> the docstring.
Björn> The manual, in (info "(gnus) Customizing Articles") , seem to match with
Björn> those and talk in general like they apply to all of these.
I really donʼt think something like this
6. An integer: Do this treatment on all body parts that have a length
less than this number.
is applicable to headers.
Robert
--
^ permalink raw reply [flat|nested] 9+ messages in thread* bug#74915: [PATCH] Fix custom types of gnus-article-treat-head-custom variables
2024-12-17 7:28 ` Robert Pluim
@ 2024-12-17 10:22 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-17 11:16 ` Robert Pluim
0 siblings, 1 reply; 9+ messages in thread
From: Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2024-12-17 10:22 UTC (permalink / raw)
To: Robert Pluim; +Cc: 74915
Robert Pluim <rpluim@gmail.com> writes:
>>>>>> On Tue, 17 Dec 2024 00:30:04 +0200, Björn Bidar <bjorn.bidar@thaodan.de> said:
>
> Björn> Robert Pluim <rpluim@gmail.com> writes:
> >>>>>>> On Mon, 16 Dec 2024 19:33:31 +0200, Björn Bidar via "Bug
> >> reports for GNU Emacs, the Swiss army knife of text editors"
> >> <bug-gnu-emacs@gnu.org> said:
> Björn> From 2b365a8804afab600437aa9e8dba3c45ac4363fe Mon Sep 17 00:00:00 2001
> Björn> From: =?UTF-8?q?Bj=C3=B6rn=20Bidar?= <bjorn.bidar@thaodan.de>
> Björn> Date: Mon, 16 Dec 2024 19:20:00 +0200
> Björn> Subject: [PATCH] Fix custom types of gnus-article-treat-head-custom variables
> >>
> Björn> lisp/gnus/gnus-art.el (gnus-treat-buttonize-head, gnus-treat-date)
> Björn> (gnus-treat-hide-headers, gnus-treat-hide-boring-headers)
> Björn> (gnus-treat-highlight-headers, gnus-treat-display-x-face)
> Björn> (gnus-treat-display-face, gnus-treat-display-face)
> Björn> (gnus-treat-mail-picon, gnus-treat-newsgroups-picon)
> Björn> (gnus-treat-from-gravatar, gnus-treat-mail-gravatar)
> Björn> (gnus-treat-body-boundary): Fix custom types to
> Björn> include all possible choices mentioned in the docstrings
> Björn> and manual.
> >>
> >> The commit message only needs to mention the type you actually
> >> changed, in this case `gnus-article-treat-head-custom'
>
> Björn> The type meaning the custom type or the variable?
>
> The variable. All the other things you mention use the variable, but
> there is no code change for them.
ok.
>
> Björn> ---
> Björn> lisp/gnus/gnus-art.el | 5 ++++-
> Björn> 1 file changed, 4 insertions(+), 1 deletion(-)
> >>
> Björn> diff --git a/lisp/gnus/gnus-art.el b/lisp/gnus/gnus-art.el
> Björn> index 8243e4e632b..13dfb737243 100644
> Björn> --- a/lisp/gnus/gnus-art.el
> Björn> +++ b/lisp/gnus/gnus-art.el
> Björn> @@ -1113,7 +1113,10 @@ gnus-article-treat-custom
> >>
> Björn> (defvar gnus-article-treat-head-custom
> Björn> '(choice (const :tag "Off" nil)
> Björn> - (const :tag "Header" head)))
> Björn> + (const :tag "Header" head)
> Björn> + (const :tag "First" first)
> Björn> + (const :tag "Last" last)
> Björn> + (boolean :tag "All body parts" t)))
> >>
> >> `t' is a const, not a boolean, the same as `nil', in the context of
> >> defcustom.
>
> Björn> There's bolean in the context of custom but I the context of choice is
> Björn> should be const with nil or t.
>
> `nil' is already in the list.
>
> >> Plus a lot of the docstrings look cut&paste, so Iʼm not
> >> entirely sure that itʼs the existing type that is wrong rather than
> >> the docstring.
>
> Björn> The manual, in (info "(gnus) Customizing Articles") , seem to match with
> Björn> those and talk in general like they apply to all of these.
>
> I really donʼt think something like this
>
> 6. An integer: Do this treatment on all body parts that have a length
> less than this number.
>
> is applicable to headers.
Ok sure. What do you suggest instead?
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#74915: [PATCH] Fix custom types of gnus-article-treat-head-custom variables
2024-12-17 10:22 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2024-12-17 11:16 ` Robert Pluim
2024-12-17 13:02 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 9+ messages in thread
From: Robert Pluim @ 2024-12-17 11:16 UTC (permalink / raw)
To: Björn Bidar; +Cc: 74915
>>>>> On Tue, 17 Dec 2024 12:22:51 +0200, Björn Bidar <bjorn.bidar@thaodan.de> said:
Björn> The manual, in (info "(gnus) Customizing Articles") , seem to match with
Björn> those and talk in general like they apply to all of these.
>>
>> I really donʼt think something like this
>>
>> 6. An integer: Do this treatment on all body parts that have a length
>> less than this number.
>>
>> is applicable to headers.
Björn> Ok sure. What do you suggest instead?
Iʼd read the code carefully and see if any of the treatments that
apply to headers actually honour any other values than 'head or nil.
Robert
--
^ permalink raw reply [flat|nested] 9+ messages in thread* bug#74915: [PATCH] Fix custom types of gnus-article-treat-head-custom variables
2024-12-17 11:16 ` Robert Pluim
@ 2024-12-17 13:02 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-17 13:08 ` Robert Pluim
0 siblings, 1 reply; 9+ messages in thread
From: Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2024-12-17 13:02 UTC (permalink / raw)
To: Robert Pluim; +Cc: 74915
Robert Pluim <rpluim@gmail.com> writes:
>>>>>> On Tue, 17 Dec 2024 12:22:51 +0200, Björn Bidar
> <bjorn.bidar@thaodan.de> said:
> Björn> The manual, in (info "(gnus) Customizing Articles") , seem
> Björn> to match with
> Björn> those and talk in general like they apply to all of these.
> >>
> >> I really donʼt think something like this
> >>
> >> 6. An integer: Do this treatment on all body parts that have a length
> >> less than this number.
> >>
> >> is applicable to headers.
>
> Björn> Ok sure. What do you suggest instead?
>
> Iʼd read the code carefully and see if any of the treatments that
> apply to headers actually honour any other values than 'head or nil.
I was asking more in the way that you already know which one do or
don't.
Of course I can go through them but somebody that knows the code better fix
them much faster than me.
^ permalink raw reply [flat|nested] 9+ messages in thread
* bug#74915: [PATCH] Fix custom types of gnus-article-treat-head-custom variables
2024-12-17 13:02 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
@ 2024-12-17 13:08 ` Robert Pluim
2024-12-17 13:30 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 1 reply; 9+ messages in thread
From: Robert Pluim @ 2024-12-17 13:08 UTC (permalink / raw)
To: Björn Bidar; +Cc: 74915
>>>>> On Tue, 17 Dec 2024 15:02:37 +0200, Björn Bidar <bjorn.bidar@thaodan.de> said:
Björn> Robert Pluim <rpluim@gmail.com> writes:
>>>>>>> On Tue, 17 Dec 2024 12:22:51 +0200, Björn Bidar
>> <bjorn.bidar@thaodan.de> said:
Björn> The manual, in (info "(gnus) Customizing Articles") , seem
Björn> to match with
Björn> those and talk in general like they apply to all of these.
>> >>
>> >> I really donʼt think something like this
>> >>
>> >> 6. An integer: Do this treatment on all body parts that have a length
>> >> less than this number.
>> >>
>> >> is applicable to headers.
>>
Björn> Ok sure. What do you suggest instead?
>>
>> Iʼd read the code carefully and see if any of the treatments that
>> apply to headers actually honour any other values than 'head or nil.
Björn> I was asking more in the way that you already know which one do or
Björn> don't.
Björn> Of course I can go through them but somebody that knows the code better fix
Björn> them much faster than me.
If I knew the code well, Iʼd have been more definite. Has anyone
actually complained that the type is wrong?
Robert
--
^ permalink raw reply [flat|nested] 9+ messages in thread* bug#74915: [PATCH] Fix custom types of gnus-article-treat-head-custom variables
2024-12-17 13:08 ` Robert Pluim
@ 2024-12-17 13:30 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
0 siblings, 0 replies; 9+ messages in thread
From: Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors @ 2024-12-17 13:30 UTC (permalink / raw)
To: Robert Pluim; +Cc: 74915
Robert Pluim <rpluim@gmail.com> writes:
>>>>>> On Tue, 17 Dec 2024 15:02:37 +0200, Björn Bidar <bjorn.bidar@thaodan.de> said:
>
> Björn> Robert Pluim <rpluim@gmail.com> writes:
> >>>>>>> On Tue, 17 Dec 2024 12:22:51 +0200, Björn Bidar
> >> <bjorn.bidar@thaodan.de> said:
> Björn> The manual, in (info "(gnus) Customizing Articles") , seem
> Björn> to match with
> Björn> those and talk in general like they apply to all of these.
> >> >>
> >> >> I really donʼt think something like this
> >> >>
> >> >> 6. An integer: Do this treatment on all body parts that have a length
> >> >> less than this number.
> >> >>
> >> >> is applicable to headers.
> >>
> Björn> Ok sure. What do you suggest instead?
> >>
> >> Iʼd read the code carefully and see if any of the treatments that
> >> apply to headers actually honour any other values than 'head or nil.
>
> Björn> I was asking more in the way that you already know which one do or
> Björn> don't.
> Björn> Of course I can go through them but somebody that knows the code better fix
> Björn> them much faster than me.
>
> If I knew the code well, Iʼd have been more definite. Has anyone
> actually complained that the type is wrong?
I haven't seen anyone so far since nobody/not so many seem to use custom
with Gnus.
I have started to use setopt instead of setq to catch some options set
wrong and have seen these errors through that.
Of course you can always use setq but that defeats the point of custom.
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2024-12-17 13:30 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-12-16 17:33 bug#74915: [PATCH] Fix custom types of gnus-article-treat-head-custom variables Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-16 18:15 ` Robert Pluim
2024-12-16 22:30 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
[not found] ` <6760a9ed.df0a0220.1a04c9.e35cSMTPIN_ADDED_BROKEN@mx.google.com>
2024-12-17 7:28 ` Robert Pluim
2024-12-17 10:22 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-17 11:16 ` Robert Pluim
2024-12-17 13:02 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
2024-12-17 13:08 ` Robert Pluim
2024-12-17 13:30 ` Björn Bidar via Bug reports for GNU Emacs, the Swiss army knife of text editors
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.