From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Lennart Borgman Newsgroups: gmane.emacs.devel Subject: Re: shell-command - missing shell-quote-argument for program? Date: Thu, 05 Oct 2006 16:53:10 +0200 Message-ID: <45251C56.8010603@student.lu.se> References: <452517DC.5010007@student.lu.se> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit X-Trace: sea.gmane.org 1160060362 24830 80.91.229.2 (5 Oct 2006 14:59:22 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 5 Oct 2006 14:59:22 +0000 (UTC) Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 05 16:59:20 2006 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1GVUbD-0002SJ-Rm for ged-emacs-devel@m.gmane.org; Thu, 05 Oct 2006 16:53:24 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GVUbD-00019c-GY for ged-emacs-devel@m.gmane.org; Thu, 05 Oct 2006 10:53:23 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1GVUb3-00018j-Oo for emacs-devel@gnu.org; Thu, 05 Oct 2006 10:53:13 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1GVUb3-00018R-9k for emacs-devel@gnu.org; Thu, 05 Oct 2006 10:53:13 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1GVUb3-00018M-3t for emacs-devel@gnu.org; Thu, 05 Oct 2006 10:53:13 -0400 Original-Received: from [81.228.11.159] (helo=pne-smtpout2-sn1.fre.skanova.net) by monty-python.gnu.org with esmtp (Exim 4.52) id 1GVUhi-0008A5-J4 for emacs-devel@gnu.org; Thu, 05 Oct 2006 11:00:06 -0400 Original-Received: from [192.168.123.121] (83.249.218.244) by pne-smtpout2-sn1.fre.skanova.net (7.2.075) id 451BA3C7001D038C for emacs-devel@gnu.org; Thu, 5 Oct 2006 16:53:10 +0200 User-Agent: Thunderbird 1.5.0.7 (Windows/20060909) Original-To: Emacs Devel In-Reply-To: <452517DC.5010007@student.lu.se> X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:60432 Archived-At: Lennart Borgman wrote: > In some places the program to run from `shell-command' is not quoted > by `shell-quote-argument'. Examples are the calls in emerge.el. > > Should not the program name be quoted by `shell-quote-argment' when it > is possible? And I should have mentioned `shell-command-to-string' to of course. More examples of probably missing shell quotings are in - filesets.el - defcustom explicit-bash-args - python-after-info-look: python-command - flymake-get-project-include-dirs-imp: basedir should perhaps be quoted? - ada-find-in-src-path - ido-wide-find-dirs-or-files: several examples of missing quoting - locate.el: locate-update-command shoue perhaps be quoted? (But probably not, since it may include more than the program name. Bad structure?) - fortune.el - org.el - reftex-create-tags-file in reftex-global.el