Some suggestion WRT gtk related variables

Some suggestion WRT gtk related variables

[Reiner Steib]

Hi,

`M-x apropos-variable RET gtk- RET' shows...

,----[ M-x apropos-variable RET gtk- RET ]
| x-gtk-show-chooser-help-text
|   Variable: *If non-nil, the GTK file chooser will by show additional help text.
| x-gtk-show-hidden-files
|   Variable: *If non-nil, the GTK file chooser will by default show hidden files.
| x-gtk-whole-detached-tool-bar
|   Variable: *If non-nil, a detached tool bar is shown in full.
| x-use-old-gtk-file-dialog
|   Variable: *Non-nil means prompt with the old GTK file selection dialog.
`----

Why do we use the term "chooser" in `x-gtk-show-chooser-help-text' and
the term "file dialog" in `x-use-old-gtk-file-dialog'.  I'd suggest to
use "file dialog" in both variables, i.e. rename
`x-gtk-show-chooser-help-text' to `x-gtk-file-dialog-help-text'.

I'd also suggest to rename `x-use-old-gtk-file-dialog' to
`x-gtk-use-old-file-dialog'.  Maybe it's doc string should say what is
"old" and "new" in GTK version numbers?

Maybe it would make sense to allow `x-gtk-show-chooser-help-text' to
be nil, t or a (customizable) string instead of the hard coded text:

,----[ gtkutil.c ]
|   if (x_gtk_show_chooser_help_text)
|     {
|       message[0] = '\0';
|       if (action != GTK_FILE_CHOOSER_ACTION_SAVE)
|         strcat (message, "\nType C-l to display a file name text entry box.\n");
|       strcat (message, "\nIf you don't like this file selector, use the "
|               "corresponding\nkey binding or customize "
|               "use-file-dialog to turn it off.");
|     
|       wmessage = gtk_label_new (message);
|       gtk_widget_show (wmessage);
|     }
`----

Bye, Reiner.
-- 
       ,,,
      (o o)
---ooO-(_)-Ooo---  |  PGP key available  |  http://rsteib.home.pages.de/

Re: Some suggestion WRT gtk related variables

[Jan Djärv]

Reiner Steib skrev:
> Hi,
> 
> `M-x apropos-variable RET gtk- RET' shows...
> 
> ,----[ M-x apropos-variable RET gtk- RET ]
> | x-gtk-show-chooser-help-text
> |   Variable: *If non-nil, the GTK file chooser will by show additional help text.
> | x-gtk-show-hidden-files
> |   Variable: *If non-nil, the GTK file chooser will by default show hidden files.
> | x-gtk-whole-detached-tool-bar
> |   Variable: *If non-nil, a detached tool bar is shown in full.
> | x-use-old-gtk-file-dialog
> |   Variable: *Non-nil means prompt with the old GTK file selection dialog.
> `----
> 
> Why do we use the term "chooser" in `x-gtk-show-chooser-help-text' and
> the term "file dialog" in `x-use-old-gtk-file-dialog'.  I'd suggest to
> use "file dialog" in both variables, i.e. rename
> `x-gtk-show-chooser-help-text' to `x-gtk-file-dialog-help-text'.

Just because the old file dialog does not have the additional text.  The name 
of the new dialog is file-chooser.  But I can change.

> 
> I'd also suggest to rename `x-use-old-gtk-file-dialog' to
> `x-gtk-use-old-file-dialog'.  Maybe it's doc string should say what is
> "old" and "new" in GTK version numbers?

That is currently not possible.  Both file dialogs exists side by side in at 
least Gtk+ version 2.4 to 2.10.  I can rename the variable though.

> 
> Maybe it would make sense to allow `x-gtk-show-chooser-help-text' to
> be nil, t or a (customizable) string instead of the hard coded text:

Wouldn't that be overkill?  The purpose of the text is just to help those that 
dislike the new dialog, which seems to be quite a few.

	Jan D.