From: Jason Rumney <jasonr@gnu.org>
Cc: KOBAYASHI Yasuhiro <kobayays@otsukakj.co.jp>, emacs-devel@gnu.org
Subject: Re: Patch for remote files in dnd.el
Date: Fri, 15 Sep 2006 10:22:19 +0100 [thread overview]
Message-ID: <450A70CB.2050203@gnu.org> (raw)
In-Reply-To: <450A5209.9030101@swipnet.se>
It works, but I just noticed that so does using dnd-open-local-file
instead of dnd-open-unc-file, which avoids loading url*.elc if they are
not already (they are on Windows though, so in practice this may not
make much difference). So we could get rid of dnd-open-unc-file
altogether. Note that the optional must-exist parameter to
dnd-get-local-file-name does not work as advertised, and it is only ever
called with it set to t. The only thing preventing remote files working
on Windows before was the check in dnd-open-file. Since unc filenames
are handled the same way as local filenames on Windows, it is not
unreasonable to switch to using dnd-open-local-file.
Jan Djärv wrote:
>
> Shall this be installed? Can W32-users confirm that this works OK?
>
> Jan D.
>
> KOBAYASHI Yasuhiro skrev:
>> I tried the latest HEAD but I have the error which occured
>> with the filename with SPACEs or MULTIBYTEs.
>>
>> Debugger entered--Lisp error: (error "Invalid file url")
>> signal(error ("Invalid file url"))
>> error("Invalid file url")
>>
>> dnd-open-unc-file("file://NSZ/home/kobayays/My%20Documents/w_s3alog.csv"
>> private)
>>
>> dnd-open-file("file://NSZ/home/kobayays/My%20Documents/w_s3alog.csv"
>> private)
>> [...]
>>
>> How about the following?
>>
>> *** /tmp/dnd.el~ Fri Sep 8 08:35:07 2006
>> --- /tmp/dnd.el Fri Sep 8 08:34:33 2006
>> ***************
>> *** 181,187 ****
>> and must have the format file://hostname/file-name. ACTION is ignored.
>> //hostname/file-name is the unc path."
>> (let ((unc-file (if (string-match "^file:" uri)
>> ! (substring (uri) 5))))
>> (if (and unc-file (file-readable-p unc-file))
>> (progn
>> (if dnd-open-file-other-window
>> --- 181,187 ----
>> and must have the format file://hostname/file-name. ACTION is ignored.
>> //hostname/file-name is the unc path."
>> (let ((unc-file (if (string-match "^file:" uri)
>> ! (substring (url-unhex-string uri) 5))))
>> (if (and unc-file (file-readable-p unc-file))
>> (progn
>> (if dnd-open-file-other-window
>
next prev parent reply other threads:[~2006-09-15 9:22 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-27 22:22 Patch for remote files in dnd.el Jason Rumney
2006-07-28 7:25 ` Mathias Dahl
2006-07-28 12:37 ` Jason Rumney
2006-08-01 12:10 ` Mathias Dahl
2006-07-28 10:44 ` Jan Djärv
2006-07-28 11:32 ` Jason Rumney
2006-07-28 13:34 ` Richard Stallman
2006-07-28 19:04 ` Jason Rumney
2006-07-28 22:20 ` Jason Rumney
2006-07-29 17:10 ` Stefan Monnier
2006-08-01 4:58 ` Jan Djärv
2006-08-08 9:38 ` Jan Djärv
2006-07-29 2:59 ` Richard Stallman
2006-09-06 11:15 ` Jan Djärv
2006-09-06 11:31 ` David Kastrup
2006-09-06 11:48 ` Jason Rumney
2006-09-06 11:59 ` David Kastrup
2006-09-06 12:06 ` Jan Djärv
2006-09-06 13:03 ` Reiner Steib
2006-09-06 14:25 ` Michael Albinus
2006-09-07 6:54 ` Richard Stallman
2006-09-07 7:40 ` Michael Albinus
2006-09-06 14:13 ` Michael Albinus
2006-09-07 6:54 ` Richard Stallman
2006-09-07 7:31 ` YAMAMOTO Mitsuharu
2006-09-07 8:12 ` Jason Rumney
2006-09-07 8:25 ` YAMAMOTO Mitsuharu
2006-09-07 8:56 ` Jan Djärv
2006-09-07 15:50 ` Stuart D. Herring
2006-09-08 0:56 ` YAMAMOTO Mitsuharu
2006-09-07 8:25 ` Jan Djärv
[not found] ` <f7ccd24b0609070236r224ce34fobb9ceb0856a3ec39@mail.gmail.com>
[not found] ` <44FFED66.2060806@swipnet.se>
2006-09-07 10:01 ` Jan Djärv
2006-09-07 14:13 ` Stefan Monnier
2006-09-07 8:32 ` David Kastrup
2006-09-07 8:49 ` Jason Rumney
2006-09-08 11:55 ` Richard Stallman
2006-09-08 12:43 ` Jason Rumney
2006-09-08 13:01 ` Jan Djärv
2006-09-08 16:45 ` Richard Stallman
2006-09-09 6:25 ` Jan Djärv
2006-09-08 11:55 ` Richard Stallman
2006-09-08 11:55 ` Richard Stallman
2006-09-07 23:47 ` KOBAYASHI Yasuhiro
2006-09-08 8:25 ` Jason Rumney
2006-09-08 9:09 ` YAMAMOTO Mitsuharu
2006-09-15 7:11 ` Jan Djärv
2006-09-15 9:22 ` Jason Rumney [this message]
2006-09-15 9:29 ` Jan Djärv
2006-09-15 11:01 ` Jason Rumney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=450A70CB.2050203@gnu.org \
--to=jasonr@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=kobayays@otsukakj.co.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.